New issue
Advanced search Search tips

Issue 656807 link

Starred by 2 users
Status: Verified
Owner:
x...@chromium.org
Closed: Dec 2016
Cc:
dpa...@chromium.org
steve...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 653689



Sign in to add a comment

MD Settings: Cups: Migrate from paper-dropdown-menu-light to native select.

Project Member Reported by steve...@chromium.org, Oct 17 2016 
CUPS printing UI still uses paper-dropdown-menu in printing_page/cups_add_printer_dialog.html.

It needs to use <select> and the md-select CSS. See  issue 653689  and  issue 651513  for examples of other conversions.

Separating this work from  issue 653689 .
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a6d0114982b49799e7e28d1cd4fe61649ad77e9

commit 8a6d0114982b49799e7e28d1cd4fe61649ad77e9
Author: xdai <xdai@chromium.org>
Date: Wed Oct 26 01:57:48 2016

[CUPS] MD Settings: Migrate from paper-dropdown-menu-light to native select

BUG= 656807 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2452833002
Cr-Commit-Position: refs/heads/master@{#427577}

[modify] https://crrev.com/8a6d0114982b49799e7e28d1cd4fe61649ad77e9/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html
[modify] https://crrev.com/8a6d0114982b49799e7e28d1cd4fe61649ad77e9/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js

Comment 2 by dpa...@chromium.org, Nov 15 2016

Labels: Proj-MaterialDesign-WebUI

Comment 3 by steve...@chromium.org, Nov 22 2016

Blocking: 653689
Labels: -M-56 M-57
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3f24fcf763f2e749b7077aed2fd169d33df91d2

commit c3f24fcf763f2e749b7077aed2fd169d33df91d2
Author: xdai <xdai@chromium.org>
Date: Wed Dec 14 21:51:07 2016

[CUPS] Fix the width of the printer protocol dropdown menu.

BUG= 656807 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2570873003
Cr-Commit-Position: refs/heads/master@{#438639}

[modify] https://crrev.com/c3f24fcf763f2e749b7077aed2fd169d33df91d2/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html

Comment 5 by x...@chromium.org, Dec 14 2016

Status: Fixed (was: Assigned)

Comment 6 by skau@chromium.org, Dec 22 2016 

Issue 674312 has been merged into this issue.

Comment 7 by ka...@chromium.org, Dec 22 2016

Status: Assigned (was: Fixed)
Issue 674312 describes broken select menus. Reopening this one.
Close if issue 674312 is fixed with this change(s)?

Comment 8 by x...@chromium.org, Dec 22 2016

Status: Fixed (was: Assigned)
This one has been fixed. Issue 674312 should merge into  Issue 673961 , not this one.

Comment 9 by rookrishna@chromium.org, Mar 16 2017

Status: Verified (was: Fixed)
►

Sign in to add a comment