Update offline OIB to include "open online" |
|||
Issue description2 updates for the OIB - remove the offline badging in the OIB when the user taps in - if the user is online and viewing an offline version and clicks into the OIB add an "Open online" link action that reloads the page to the online version.
,
Oct 28 2016
I am working on design document for the change, although it is pretty small.
,
Oct 28 2016
,
Nov 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3895e09ff868cf3507b95c53a73618a8af69369e commit 3895e09ff868cf3507b95c53a73618a8af69369e Author: fgorski <fgorski@chromium.org> Date: Tue Nov 01 20:37:41 2016 [Offline pages] Introducing Open online button in OIB Changes WebsiteSettingsPopup * Adds a button to "Open online" with click handler * Passes a tab to WSP to be able to handle open online click BUG= 656804 Review-Url: https://codereview.chromium.org/2447413006 Cr-Commit-Position: refs/heads/master@{#429095} [modify] https://crrev.com/3895e09ff868cf3507b95c53a73618a8af69369e/chrome/android/java/res/layout/website_settings.xml [modify] https://crrev.com/3895e09ff868cf3507b95c53a73618a8af69369e/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java [modify] https://crrev.com/3895e09ff868cf3507b95c53a73618a8af69369e/chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java [modify] https://crrev.com/3895e09ff868cf3507b95c53a73618a8af69369e/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java [modify] https://crrev.com/3895e09ff868cf3507b95c53a73618a8af69369e/chrome/android/java/strings/android_chrome_strings.grd
,
Nov 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/78247f3f61fd14570b57e6ac4415f79bcda48e9c commit 78247f3f61fd14570b57e6ac4415f79bcda48e9c Author: fgorski <fgorski@chromium.org> Date: Tue Nov 08 00:44:37 2016 [Offline pages] Adding metrics for OIB's Open online button Adds metrics for the following aspects: * Open online button is shown when OIB is shown for offline page * Browser is online when open online button is clicked in OIB BUG= 656804 Review-Url: https://codereview.chromium.org/2459923002 Cr-Commit-Position: refs/heads/master@{#430447} [modify] https://crrev.com/78247f3f61fd14570b57e6ac4415f79bcda48e9c/chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java [modify] https://crrev.com/78247f3f61fd14570b57e6ac4415f79bcda48e9c/tools/metrics/histograms/histograms.xml
,
Nov 8 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by dim...@chromium.org
, Oct 19 2016Owner: fgor...@chromium.org
Status: Assigned (was: Untriaged)