Previews blacklist should have a short period host black list time for single opt outs |
|||
Issue descriptionWhen a user opts out of a preview, the preview host should be disallowed from previews for a short time. This is complementary to the j of k last previews navigations on the host rule (i.e., if j of the last k previews navigations to a host are opted out, that host is blacklisted). The timing on the single opt-out black out period should be on the order of seconds or minutes whereas the timing on the j of k rule is on the order of days or months. If a user wishes to temporarily use the page without previews for a few consecutive navigations, this will prevent the user from quickly opting out j times and triggering the j of k rule. This will also provide a mechanism for reloads not using any preview when previews has seen an opt out and wishes to show original regardless of the types of previews being looked at.
,
Oct 19 2016
To clarify, if a user opts out of a Preview, they will be opted out of all previews on that domain for X min. How does that opt out and subsequent navigations to the same domain without previews contribute towards the j of k rule? Are the navigations during the Xmin counted towards k?
,
Oct 19 2016
Correct. The opt out will contribute to the J and the k of the other rule. However, the subsequent navigations within x minutes will not, since k refers to only the last k previews navigations, the navigations that are served as non-preview due to this short period blackout will not be counted towards k nor j. For any of these rules, we only consider when the preview is actually shown (k) and we consider an opt out to be clicking "show original" (J).
,
Oct 19 2016
SGTM! Have we determined the Xmin, j, or k yet?
,
Oct 21 2016
j and k are defaulted to 2 and 4 for the host based rule (with a 30 day black out), 4 and 10 for the general non-host rule (100 year black out). For this xMin, it will default to 300 seconds (5 minutes). We can set all of these using finch however.
,
Oct 25 2016
,
Oct 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/960e2c0a2455a4be4e71b9b0923115785bf6cd1e commit 960e2c0a2455a4be4e71b9b0923115785bf6cd1e Author: ryansturm <ryansturm@chromium.org> Date: Tue Oct 25 21:26:07 2016 Adding a short blacklist period after every previews opt out Within a session, if a user opts out of a preview navigation, the user won't be shown any previews for a short duration in that session. This does not extend outside the session because the general rationale behind this is a user temporarily wanting to consume many non-previews navigations consecutively. BUG= 656802 Review-Url: https://codereview.chromium.org/2439203002 Cr-Commit-Position: refs/heads/master@{#427480} [modify] https://crrev.com/960e2c0a2455a4be4e71b9b0923115785bf6cd1e/components/previews/core/previews_black_list.cc [modify] https://crrev.com/960e2c0a2455a4be4e71b9b0923115785bf6cd1e/components/previews/core/previews_black_list.h [modify] https://crrev.com/960e2c0a2455a4be4e71b9b0923115785bf6cd1e/components/previews/core/previews_black_list_unittest.cc [modify] https://crrev.com/960e2c0a2455a4be4e71b9b0923115785bf6cd1e/components/previews/core/previews_experiments.cc [modify] https://crrev.com/960e2c0a2455a4be4e71b9b0923115785bf6cd1e/components/previews/core/previews_experiments.h
,
Oct 25 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by ryansturm@chromium.org
, Oct 17 2016Labels: -Pri-1 OS-All Pri-2
Summary: Previews blacklist should have a short period host black list time for single opt outs (was: Previews blacklist should have a short period host black list time)