New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 656791 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Oct 2016
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Remoting Mac .dmg file is generated with url escaped space characters

Project Member Reported by nicho...@chromium.org, Oct 17 2016

Issue description

Looks like the port to GN did not implement the nospace variable change in the way we use to use it.

At the moment package_name_nospace is set to host_name, where host_name is "Chrome Remote Desktop" which becomes encoded to "Chrome%20Remote%20Desktop" where it should have been "ChromeRemoteDesktop"

The root cause is the *_nospace variables are no longer using the following way used in gyp:

name_nospace': '<!(echo <(name) | sed "s/ //g")'

via: https://chromium.googlesource.com/chromium/src/+/843858c166713ac20b5533a1211181c0af1b7539%5E%21/#F6

Need to find a way to do this in gn.
 
Owner: ajnolley@chromium.org
Status: Fixed (was: Assigned)
AJ: Can you verify that the new Mac binary/installable is named correctly and it installable? Worked locally :)
It looks like CRD was not built as part of last night's M56 Chrome Downloads. I'll check this tomorrow. 
Status: Verified (was: Fixed)

Sign in to add a comment