Remoting Mac .dmg file is generated with url escaped space characters |
|||
Issue descriptionLooks like the port to GN did not implement the nospace variable change in the way we use to use it. At the moment package_name_nospace is set to host_name, where host_name is "Chrome Remote Desktop" which becomes encoded to "Chrome%20Remote%20Desktop" where it should have been "ChromeRemoteDesktop" The root cause is the *_nospace variables are no longer using the following way used in gyp: name_nospace': '<!(echo <(name) | sed "s/ //g")' via: https://chromium.googlesource.com/chromium/src/+/843858c166713ac20b5533a1211181c0af1b7539%5E%21/#F6 Need to find a way to do this in gn.
,
Oct 18 2016
AJ: Can you verify that the new Mac binary/installable is named correctly and it installable? Worked locally :)
,
Oct 18 2016
It looks like CRD was not built as part of last night's M56 Chrome Downloads. I'll check this tomorrow.
,
Jul 18 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Oct 18 2016