New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 656783 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 665179



Sign in to add a comment

Mash Locale Change Guard

Project Member Reported by e...@chromium.org, Oct 17 2016

Issue description

Port this.

(Also see  issue 557406  for the possible removal of this feature.)
 

Comment 1 by e...@chromium.org, Oct 17 2016

(I meant  issue 656200 .)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf3c339b9bc6b61a00d354d3857c7de9a7dd65aa

commit cf3c339b9bc6b61a00d354d3857c7de9a7dd65aa
Author: erg <erg@chromium.org>
Date: Tue Oct 18 20:48:57 2016

ash: Use mojo LocaleNotificationController interface.

This removes a direct coupling between chrome/ and ash/common/. This
also does cleanup on the ash side where the controller was the only
member of an observer interface, which was superfluous.

BUG= 656783 

Review-Url: https://codereview.chromium.org/2420753002
Cr-Commit-Position: refs/heads/master@{#426040}

[modify] https://crrev.com/cf3c339b9bc6b61a00d354d3857c7de9a7dd65aa/ash/BUILD.gn
[modify] https://crrev.com/cf3c339b9bc6b61a00d354d3857c7de9a7dd65aa/ash/common/mojo_interface_factory.cc
[modify] https://crrev.com/cf3c339b9bc6b61a00d354d3857c7de9a7dd65aa/ash/common/system/locale/locale_notification_controller.cc
[modify] https://crrev.com/cf3c339b9bc6b61a00d354d3857c7de9a7dd65aa/ash/common/system/locale/locale_notification_controller.h
[delete] https://crrev.com/2a040cae1c0b74ab0cd585d40f45d4d266fdc3bc/ash/common/system/locale/locale_observer.h
[modify] https://crrev.com/cf3c339b9bc6b61a00d354d3857c7de9a7dd65aa/ash/common/system/tray/system_tray_notifier.cc
[modify] https://crrev.com/cf3c339b9bc6b61a00d354d3857c7de9a7dd65aa/ash/common/system/tray/system_tray_notifier.h
[modify] https://crrev.com/cf3c339b9bc6b61a00d354d3857c7de9a7dd65aa/ash/common/wm_shell.cc
[modify] https://crrev.com/cf3c339b9bc6b61a00d354d3857c7de9a7dd65aa/ash/common/wm_shell.h
[modify] https://crrev.com/cf3c339b9bc6b61a00d354d3857c7de9a7dd65aa/ash/mus/manifest.json
[modify] https://crrev.com/cf3c339b9bc6b61a00d354d3857c7de9a7dd65aa/ash/public/interfaces/BUILD.gn
[add] https://crrev.com/cf3c339b9bc6b61a00d354d3857c7de9a7dd65aa/ash/public/interfaces/locale.mojom
[modify] https://crrev.com/cf3c339b9bc6b61a00d354d3857c7de9a7dd65aa/ash/shell.cc
[modify] https://crrev.com/cf3c339b9bc6b61a00d354d3857c7de9a7dd65aa/ash/shell.h
[modify] https://crrev.com/cf3c339b9bc6b61a00d354d3857c7de9a7dd65aa/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/cf3c339b9bc6b61a00d354d3857c7de9a7dd65aa/chrome/browser/chrome_content_browser_manifest_overlay.json
[modify] https://crrev.com/cf3c339b9bc6b61a00d354d3857c7de9a7dd65aa/chrome/browser/chromeos/locale_change_guard.cc
[modify] https://crrev.com/cf3c339b9bc6b61a00d354d3857c7de9a7dd65aa/chrome/browser/chromeos/locale_change_guard.h

Comment 3 by e...@chromium.org, Oct 18 2016

Status: Fixed (was: Assigned)
Blockedon: 665179
Blocking: 665179
Blockedon: -665179

Comment 7 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 8 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 9 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 10 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 12 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment