New issue
Advanced search Search tips

Issue 656782 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

Android accessibility word/character navigation broken for unfocused editable text fields

Project Member Reported by dmazz...@chromium.org, Oct 17 2016

Issue description

1. Enable TalkBack
2. Navigate to a web page with a text field
3. Enter multiple words of text
4. Now click on some other element so the text field no longer has focus
5. Navigate to the text field so that it has accessibility focus, but do not double-click on it. There should be no flashing insertion point.
6. Swipe up/down in TalkBack to change the granularity to words
7. Swipe left/right to move by word

This doesn't work, but moving by words DOES work if the text box is focused, and it DOES work if you move by words in static text

The underlying issue here is that we had two different implementations of the word / character granularity code:
1. For static text, we update our internal state to keep track of a fake cursor
2. For editable text, we update the actual selection

The purpose of #2 was to allow word/character navigation while editing a text field, but this breaks when you're trying to navigate within a text field that isn't currently focused.

The fix is to make sure we use technique #1 when navigating in a text field that isn't currently focused.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48cf22b54f806accf7dad031dc59cd29d6d51c34

commit 48cf22b54f806accf7dad031dc59cd29d6d51c34
Author: dmazzoni <dmazzoni@chromium.org>
Date: Tue Oct 25 17:28:27 2016

Android accessibility: fix word/character navigation in unfocused text fields

We have two different code paths for word / character granularity movement:
1. For static text, we update our internal state to keep track of a
   fake cursor
2. For editable text, we update the actual selection

The purpose of #2 was to allow word/character navigation while editing
a text field, but we weren't properly handling the case where it's an
editable text field that isn't currently focused. The fix is to make sure
we use code path #1 when navigating in a text field that isn't currently
focused.

BUG= 656782 

Review-Url: https://codereview.chromium.org/2420413006
Cr-Commit-Position: refs/heads/master@{#427392}

[modify] https://crrev.com/48cf22b54f806accf7dad031dc59cd29d6d51c34/content/browser/accessibility/browser_accessibility_manager_android.cc
[modify] https://crrev.com/48cf22b54f806accf7dad031dc59cd29d6d51c34/content/browser/accessibility/browser_accessibility_manager_android.h
[modify] https://crrev.com/48cf22b54f806accf7dad031dc59cd29d6d51c34/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
This issue is found fixed in current M56 build 56.0.2906.0

Sign in to add a comment