New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 656781 link

Starred by 11 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug


Sign in to add a comment

Implement Pointer Events getCoalescedEvents API

Project Member Reported by nzolghadr@chromium.org, Oct 17 2016

Issue description

There is an initial proposal of this API here:

https://github.com/w3c/pointerevents/pull/149

We would like to implement this API and have it experienced behind experimental flag.

 
Labels: -PointerEvents PointerEvent
Summary: Implement Pointer Events getCoalescedEvents API (was: implement Pointer Events getCoalescedEvents API)
Blockedon: 662403
Blockedon: 665937
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c53850d9abcf33808e245fc4f17145ca5822081d

commit c53850d9abcf33808e245fc4f17145ca5822081d
Author: nzolghadr <nzolghadr@chromium.org>
Date: Mon Jan 09 21:42:06 2017

Introducing WebCoalescedInputEvent and inclusion in content/common

BUG= 656781 

TBR=kmarshall@chromium.org

Review-Url: https://codereview.chromium.org/2576013002
Cr-Commit-Position: refs/heads/master@{#442360}

[modify] https://crrev.com/c53850d9abcf33808e245fc4f17145ca5822081d/blimp/client/core/input/blimp_input_handler_wrapper.cc
[modify] https://crrev.com/c53850d9abcf33808e245fc4f17145ca5822081d/blimp/client/core/input/blimp_input_handler_wrapper.h
[modify] https://crrev.com/c53850d9abcf33808e245fc4f17145ca5822081d/content/browser/devtools/protocol/input_handler.cc
[modify] https://crrev.com/c53850d9abcf33808e245fc4f17145ca5822081d/content/browser/renderer_host/input/gesture_event_queue.cc
[modify] https://crrev.com/c53850d9abcf33808e245fc4f17145ca5822081d/content/common/DEPS
[modify] https://crrev.com/c53850d9abcf33808e245fc4f17145ca5822081d/content/common/input/event_with_latency_info.cc
[modify] https://crrev.com/c53850d9abcf33808e245fc4f17145ca5822081d/content/common/input/event_with_latency_info.h
[modify] https://crrev.com/c53850d9abcf33808e245fc4f17145ca5822081d/content/common/input/input_event.h
[modify] https://crrev.com/c53850d9abcf33808e245fc4f17145ca5822081d/content/common/input/input_param_traits.cc
[modify] https://crrev.com/c53850d9abcf33808e245fc4f17145ca5822081d/content/common/input/input_param_traits.h
[modify] https://crrev.com/c53850d9abcf33808e245fc4f17145ca5822081d/content/common/input/web_touch_event_traits.h
[modify] https://crrev.com/c53850d9abcf33808e245fc4f17145ca5822081d/content/renderer/input/input_event_filter.cc
[modify] https://crrev.com/c53850d9abcf33808e245fc4f17145ca5822081d/content/renderer/input/input_event_filter.h
[modify] https://crrev.com/c53850d9abcf33808e245fc4f17145ca5822081d/content/renderer/input/input_event_filter_unittest.cc
[modify] https://crrev.com/c53850d9abcf33808e245fc4f17145ca5822081d/content/renderer/input/input_handler_manager.cc
[modify] https://crrev.com/c53850d9abcf33808e245fc4f17145ca5822081d/content/renderer/input/input_handler_manager.h
[modify] https://crrev.com/c53850d9abcf33808e245fc4f17145ca5822081d/content/renderer/input/input_handler_manager_client.h
[modify] https://crrev.com/c53850d9abcf33808e245fc4f17145ca5822081d/content/renderer/input/input_handler_wrapper.cc
[modify] https://crrev.com/c53850d9abcf33808e245fc4f17145ca5822081d/content/renderer/input/input_handler_wrapper.h
[modify] https://crrev.com/c53850d9abcf33808e245fc4f17145ca5822081d/content/renderer/input/main_thread_event_queue.cc
[modify] https://crrev.com/c53850d9abcf33808e245fc4f17145ca5822081d/content/renderer/input/main_thread_event_queue.h
[modify] https://crrev.com/c53850d9abcf33808e245fc4f17145ca5822081d/content/renderer/input/main_thread_event_queue_unittest.cc
[modify] https://crrev.com/c53850d9abcf33808e245fc4f17145ca5822081d/content/renderer/mus/compositor_mus_connection.cc
[modify] https://crrev.com/c53850d9abcf33808e245fc4f17145ca5822081d/content/renderer/mus/compositor_mus_connection.h
[modify] https://crrev.com/c53850d9abcf33808e245fc4f17145ca5822081d/content/renderer/mus/compositor_mus_connection_unittest.cc
[modify] https://crrev.com/c53850d9abcf33808e245fc4f17145ca5822081d/content/renderer/mus/render_widget_mus_connection.cc
[modify] https://crrev.com/c53850d9abcf33808e245fc4f17145ca5822081d/content/renderer/mus/render_widget_mus_connection.h
[modify] https://crrev.com/c53850d9abcf33808e245fc4f17145ca5822081d/third_party/WebKit/Source/core/events/PointerEventFactory.cpp
[modify] https://crrev.com/c53850d9abcf33808e245fc4f17145ca5822081d/third_party/WebKit/Source/platform/BUILD.gn
[add] https://crrev.com/c53850d9abcf33808e245fc4f17145ca5822081d/third_party/WebKit/Source/platform/exported/WebCoalescedInputEvent.cpp
[modify] https://crrev.com/c53850d9abcf33808e245fc4f17145ca5822081d/third_party/WebKit/Source/web/PageWidgetDelegate.cpp
[modify] https://crrev.com/c53850d9abcf33808e245fc4f17145ca5822081d/third_party/WebKit/Source/web/PageWidgetDelegate.h
[modify] https://crrev.com/c53850d9abcf33808e245fc4f17145ca5822081d/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/c53850d9abcf33808e245fc4f17145ca5822081d/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
[modify] https://crrev.com/c53850d9abcf33808e245fc4f17145ca5822081d/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/c53850d9abcf33808e245fc4f17145ca5822081d/third_party/WebKit/public/BUILD.gn
[add] https://crrev.com/c53850d9abcf33808e245fc4f17145ca5822081d/third_party/WebKit/public/platform/WebCoalescedInputEvent.h
[modify] https://crrev.com/c53850d9abcf33808e245fc4f17145ca5822081d/ui/events/blink/BUILD.gn
[modify] https://crrev.com/c53850d9abcf33808e245fc4f17145ca5822081d/ui/events/blink/DEPS
[modify] https://crrev.com/c53850d9abcf33808e245fc4f17145ca5822081d/ui/events/blink/event_with_callback.cc
[modify] https://crrev.com/c53850d9abcf33808e245fc4f17145ca5822081d/ui/events/blink/event_with_callback.h
[modify] https://crrev.com/c53850d9abcf33808e245fc4f17145ca5822081d/ui/events/blink/input_handler_proxy.cc
[modify] https://crrev.com/c53850d9abcf33808e245fc4f17145ca5822081d/ui/events/blink/input_handler_proxy.h
[modify] https://crrev.com/c53850d9abcf33808e245fc4f17145ca5822081d/ui/events/blink/input_handler_proxy_client.h
[modify] https://crrev.com/c53850d9abcf33808e245fc4f17145ca5822081d/ui/events/blink/input_handler_proxy_unittest.cc
[delete] https://crrev.com/f65aa1847f78fb5a5d944723de974906e987f544/ui/events/blink/scoped_web_input_event.cc
[delete] https://crrev.com/f65aa1847f78fb5a5d944723de974906e987f544/ui/events/blink/scoped_web_input_event.h
[modify] https://crrev.com/c53850d9abcf33808e245fc4f17145ca5822081d/ui/events/blink/web_input_event_traits.cc
[modify] https://crrev.com/c53850d9abcf33808e245fc4f17145ca5822081d/ui/events/blink/web_input_event_traits.h

Blockedon: 680678
Cc: nzolghadr@chromium.org
 Issue 613540  has been merged into this issue.

Comment 8 by foolip@chromium.org, Jan 24 2017

Blockedon: 684292
Cc: briander...@chromium.org jdduke@chromium.org
 Issue 454704  has been merged into this issue.
Status: Started (was: Assigned)
https://codereview.chromium.org/2479123003/
Status: Fixed (was: Started)
Blockedon: 694649
Project Member

Comment 15 by bugdroid1@chromium.org, Nov 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11031592b08f05444d01478cfe4645263202c480

commit 11031592b08f05444d01478cfe4645263202c480
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Mon Nov 27 22:46:44 2017

Remove CoalescedEvents runtime enabled feature.

We've shipped coalesced events API for a number of releases remove
the setting.

BUG= 656781 

Change-Id: I0dc8d10833a99cefbc4f4361349d1be83d1e6142
Reviewed-on: https://chromium-review.googlesource.com/790936
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519433}
[modify] https://crrev.com/11031592b08f05444d01478cfe4645263202c480/third_party/WebKit/Source/core/events/PointerEvent.idl
[modify] https://crrev.com/11031592b08f05444d01478cfe4645263202c480/third_party/WebKit/Source/core/events/PointerEventInit.idl
[modify] https://crrev.com/11031592b08f05444d01478cfe4645263202c480/third_party/WebKit/Source/platform/runtime_enabled_features.json5

Hi, I'm making a paint app, and I've found getCoalescedEvents incredibly useful, really bringing my app to a professional level art program. I read that this feature is removed from the spec and can be removed from browsers at anytime (this link: https://developer.mozilla.org/en-US/docs/Web/API/PointerEvent/getCoalescedEvents)

Is there anything that can be done so that this extremely useful API is not removed but becomes standard??

Thank you

I don't know why that is mentioned in the MDN. But that assessment it not correct. This feature is here to stay for now and there is no plan to remove it from anywhere. Not the spec nor the implementations. I'll follow up with MDN to fix that text. Thanks for the feedback btw. Could you also comment on github issue 

https://github.com/w3c/pointerevents/issues/22

as it is always helpful to hear developers feedback and makes it easier to push standards and new features.
btw since you are making a paint app you might be interested in another powerful feature pointerrawmove 
https://github.com/w3c/pointerevents/issues/214

in conjunction with off-screen canvas. This will let you reduce the latency you see in your paint app even further so it feels more like a paper drawing. Again the feedback on github issue is always appreciated.

Hi, that is great to hear.

This pointerrawmove also sounds very interesting.

Is there anything specific you want me to comment on on the github page for getCoalescedEvents ? Is there still an issue with getCoalescedEvents ??

getCoalescedEvents is not still in the main track of the pointerevents specification. So having developers that have some use for such an API make a more compelling case for a new API like this.

Sign in to add a comment