New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 656780 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Update sync code to not have comments directly following copyright

Project Member Reported by s...@chromium.org, Oct 17 2016

Issue description

The motivation here is that we don't want to have comments about a class or set of methods sitting at the top of a file, but rather right before they're used/defined. Violations can be found via

find components/sync/* | grep \\\.h | xargs head -5 | grep -v "include"  | grep -v "Copyright" | grep -v "source" | grep -v "LICENSE" | grep -B 3 "//" | grep ==

find components/sync/* | grep \\\.cc | xargs head -5 | grep -v "include"  | grep -v "Copyright" | grep -v "source" | grep -v "LICENSE" | grep -B 3 "//" | grep ==
 

Comment 1 by s...@chromium.org, Oct 18 2016

Owner: s...@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5e266155ae8b19552f638d85ef12b04dfaec651

commit d5e266155ae8b19552f638d85ef12b04dfaec651
Author: skym <skym@chromium.org>
Date: Tue Oct 18 15:40:05 2016

[Sync] Moved down comments directly following copyright.

BUG= 656780 

Review-Url: https://codereview.chromium.org/2425673003
Cr-Commit-Position: refs/heads/master@{#425971}

[modify] https://crrev.com/d5e266155ae8b19552f638d85ef12b04dfaec651/components/sync/base/immutable.h
[modify] https://crrev.com/d5e266155ae8b19552f638d85ef12b04dfaec651/components/sync/base/model_type.h
[modify] https://crrev.com/d5e266155ae8b19552f638d85ef12b04dfaec651/components/sync/base/pref_names.h
[modify] https://crrev.com/d5e266155ae8b19552f638d85ef12b04dfaec651/components/sync/base/progress_marker_map.h
[modify] https://crrev.com/d5e266155ae8b19552f638d85ef12b04dfaec651/components/sync/base/time.h
[modify] https://crrev.com/d5e266155ae8b19552f638d85ef12b04dfaec651/components/sync/base/weak_handle.h
[modify] https://crrev.com/d5e266155ae8b19552f638d85ef12b04dfaec651/components/sync/driver/sync_driver_switches.h
[modify] https://crrev.com/d5e266155ae8b19552f638d85ef12b04dfaec651/components/sync/engine/engine_components_factory_impl.h
[modify] https://crrev.com/d5e266155ae8b19552f638d85ef12b04dfaec651/components/sync/engine/model_safe_worker.h
[modify] https://crrev.com/d5e266155ae8b19552f638d85ef12b04dfaec651/components/sync/engine/polling_constants.h
[modify] https://crrev.com/d5e266155ae8b19552f638d85ef12b04dfaec651/components/sync/engine_impl/all_status.h
[modify] https://crrev.com/d5e266155ae8b19552f638d85ef12b04dfaec651/components/sync/engine_impl/conflict_resolver.h
[modify] https://crrev.com/d5e266155ae8b19552f638d85ef12b04dfaec651/components/sync/engine_impl/conflict_util.h
[modify] https://crrev.com/d5e266155ae8b19552f638d85ef12b04dfaec651/components/sync/engine_impl/cycle/nudge_tracker.h
[modify] https://crrev.com/d5e266155ae8b19552f638d85ef12b04dfaec651/components/sync/engine_impl/cycle/status_controller.h
[modify] https://crrev.com/d5e266155ae8b19552f638d85ef12b04dfaec651/components/sync/engine_impl/cycle/sync_cycle.h
[modify] https://crrev.com/d5e266155ae8b19552f638d85ef12b04dfaec651/components/sync/engine_impl/cycle/sync_cycle_context.h
[modify] https://crrev.com/d5e266155ae8b19552f638d85ef12b04dfaec651/components/sync/engine_impl/cycle/test_util.h
[modify] https://crrev.com/d5e266155ae8b19552f638d85ef12b04dfaec651/components/sync/engine_impl/net/url_translator.cc
[modify] https://crrev.com/d5e266155ae8b19552f638d85ef12b04dfaec651/components/sync/engine_impl/net/url_translator.h
[modify] https://crrev.com/d5e266155ae8b19552f638d85ef12b04dfaec651/components/sync/engine_impl/sync_manager_impl_unittest.cc
[modify] https://crrev.com/d5e266155ae8b19552f638d85ef12b04dfaec651/components/sync/engine_impl/sync_scheduler.h
[modify] https://crrev.com/d5e266155ae8b19552f638d85ef12b04dfaec651/components/sync/engine_impl/syncer_unittest.cc
[modify] https://crrev.com/d5e266155ae8b19552f638d85ef12b04dfaec651/components/sync/engine_impl/syncer_util.h
[modify] https://crrev.com/d5e266155ae8b19552f638d85ef12b04dfaec651/components/sync/engine_impl/traffic_logger.h
[modify] https://crrev.com/d5e266155ae8b19552f638d85ef12b04dfaec651/components/sync/engine_impl/update_applicator.h
[modify] https://crrev.com/d5e266155ae8b19552f638d85ef12b04dfaec651/components/sync/model/data_type_error_handler_mock.h
[modify] https://crrev.com/d5e266155ae8b19552f638d85ef12b04dfaec651/components/sync/model/time.h
[modify] https://crrev.com/d5e266155ae8b19552f638d85ef12b04dfaec651/components/sync/protocol/proto_enum_conversions.cc
[modify] https://crrev.com/d5e266155ae8b19552f638d85ef12b04dfaec651/components/sync/protocol/proto_enum_conversions.h
[modify] https://crrev.com/d5e266155ae8b19552f638d85ef12b04dfaec651/components/sync/protocol/proto_enum_conversions_unittest.cc
[modify] https://crrev.com/d5e266155ae8b19552f638d85ef12b04dfaec651/components/sync/protocol/proto_value_conversions.cc
[modify] https://crrev.com/d5e266155ae8b19552f638d85ef12b04dfaec651/components/sync/protocol/proto_value_conversions.h
[modify] https://crrev.com/d5e266155ae8b19552f638d85ef12b04dfaec651/components/sync/protocol/proto_value_conversions_unittest.cc
[modify] https://crrev.com/d5e266155ae8b19552f638d85ef12b04dfaec651/components/sync/syncable/change_reorder_buffer.h
[modify] https://crrev.com/d5e266155ae8b19552f638d85ef12b04dfaec651/components/sync/syncable/nigori_util.h
[modify] https://crrev.com/d5e266155ae8b19552f638d85ef12b04dfaec651/components/sync/syncable/syncable_enum_conversions.cc
[modify] https://crrev.com/d5e266155ae8b19552f638d85ef12b04dfaec651/components/sync/syncable/syncable_enum_conversions.h
[modify] https://crrev.com/d5e266155ae8b19552f638d85ef12b04dfaec651/components/sync/syncable/syncable_enum_conversions_unittest.cc
[modify] https://crrev.com/d5e266155ae8b19552f638d85ef12b04dfaec651/components/sync/syncable/test_user_share.h
[modify] https://crrev.com/d5e266155ae8b19552f638d85ef12b04dfaec651/components/sync/test/engine/fake_sync_scheduler.h
[modify] https://crrev.com/d5e266155ae8b19552f638d85ef12b04dfaec651/components/sync/test/engine/mock_connection_manager.cc
[modify] https://crrev.com/d5e266155ae8b19552f638d85ef12b04dfaec651/components/sync/test/engine/mock_connection_manager.h
[modify] https://crrev.com/d5e266155ae8b19552f638d85ef12b04dfaec651/components/sync/test/engine/test_directory_setter_upper.h
[modify] https://crrev.com/d5e266155ae8b19552f638d85ef12b04dfaec651/components/sync/test/engine/test_id_factory.h
[modify] https://crrev.com/d5e266155ae8b19552f638d85ef12b04dfaec651/components/sync/test/engine/test_syncable_utils.cc
[modify] https://crrev.com/d5e266155ae8b19552f638d85ef12b04dfaec651/components/sync/test/engine/test_syncable_utils.h

Comment 3 by s...@chromium.org, Oct 18 2016

Status: Fixed (was: Started)

Sign in to add a comment