See https://groups.google.com/a/chromium.org/forum/#!msg/chromium-dev/iQgMedVA8-k/d5FFqowzAwAJ Also note that comments should use "null", not "NULL" or "nullptr".
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d8162fe30531d1ef447fdff67edd9b8fc222b6a commit 8d8162fe30531d1ef447fdff67edd9b8fc222b6a Author: skym <skym@chromium.org> Date: Mon Oct 17 22:12:44 2016 [Sync] Replacing NULL with nullptr in code and null in comments for components/sync/ BUG= 656773 Review-Url: https://codereview.chromium.org/2427803002 Cr-Commit-Position: refs/heads/master@{#425788} [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/base/cancelation_signal.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/base/cancelation_signal.h [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/base/cryptographer.h [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/base/enum_set.h [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/base/sync_prefs.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/base/sync_prefs.h [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/base/weak_handle.h [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/device_info/device_info_data_type_controller_unittest.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/device_info/device_info_sync_service.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/driver/about_sync_util.h [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/driver/about_sync_util_unittest.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/driver/change_processor.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/driver/data_type_manager_impl_unittest.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/driver/directory_data_type_controller.h [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/driver/fake_data_type_controller.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/driver/fake_generic_change_processor.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/driver/frontend_data_type_controller.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/driver/generic_change_processor.h [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/driver/generic_change_processor_unittest.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/driver/glue/browser_thread_model_worker_unittest.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/driver/glue/sync_backend_host_core.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/driver/glue/sync_backend_host_core.h [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/driver/glue/sync_backend_host_impl.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/driver/glue/sync_backend_host_impl_unittest.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/driver/glue/sync_backend_host_mock.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/driver/glue/sync_backend_host_mock.h [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/driver/glue/sync_backend_registrar.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/driver/glue/sync_backend_registrar.h [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/driver/glue/sync_backend_registrar_unittest.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/driver/model_association_manager_unittest.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/driver/model_associator.h [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/driver/non_ui_data_type_controller.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/driver/non_ui_data_type_controller.h [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/driver/shared_change_processor.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/driver/shared_change_processor_unittest.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/driver/sync_api_component_factory.h [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/driver/sync_policy_handler_unittest.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/driver/ui_data_type_controller.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/driver/ui_data_type_controller_unittest.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/engine/attachments/attachment_downloader.h [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/engine/attachments/attachment_store_frontend_unittest.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/engine/engine_util.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/engine/model_safe_worker.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/engine/net/http_bridge.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/engine/net/http_bridge_unittest.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/engine/sync_manager.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/engine_impl/apply_control_data_updates_unittest.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/engine_impl/attachments/attachment_downloader_impl.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/engine_impl/commit.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/engine_impl/commit_contributor.h [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/engine_impl/cycle/directory_type_debug_info_emitter.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/engine_impl/cycle/sync_cycle.h [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/engine_impl/directory_commit_contribution.h [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/engine_impl/directory_update_handler_unittest.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/engine_impl/js_mutation_event_observer.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/engine_impl/model_type_registry.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/engine_impl/model_type_worker.h [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/engine_impl/net/server_connection_manager.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/engine_impl/net/server_connection_manager.h [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/engine_impl/net/sync_server_connection_manager.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/engine_impl/sync_encryption_handler_impl.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/engine_impl/sync_encryption_handler_impl_unittest.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/engine_impl/sync_manager_impl.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/engine_impl/sync_manager_impl_unittest.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/engine_impl/sync_scheduler_impl.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/engine_impl/sync_scheduler_impl_unittest.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/engine_impl/syncer_proto_util.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/engine_impl/syncer_proto_util_unittest.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/engine_impl/syncer_unittest.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/engine_impl/test_entry_factory.h [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/model/fake_syncable_service.h [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/model/syncable_service.h [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/model_impl/attachments/attachment_service_impl.h [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/model_impl/attachments/attachment_service_impl_unittest.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/protocol/proto_value_conversions_unittest.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/syncable/base_transaction.h [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/syncable/change_record_unittest.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/syncable/directory.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/syncable/directory.h [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/syncable/directory_backing_store.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/syncable/directory_backing_store_unittest.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/syncable/directory_unittest.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/syncable/entry.h [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/syncable/entry_kernel.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/syncable/entry_kernel.h [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/syncable/entry_kernel_unittest.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/syncable/model_neutral_mutable_entry.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/syncable/mutable_entry.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/syncable/nigori_util.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/syncable/parent_child_index.h [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/syncable/read_node.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/syncable/read_transaction.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/syncable/sync_db_util.h [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/syncable/syncable_unittest.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/syncable/syncable_write_transaction.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/syncable/test_user_share.h [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/syncable/write_node.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/syncable/write_node.h [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/syncable/write_transaction.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/test/engine/fake_model_worker.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/test/engine/mock_connection_manager.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/test/engine/mock_connection_manager.h [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/test/fake_server/android/fake_server_helper_android.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/test/fake_server/bookmark_entity_builder.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/test/fake_server/fake_server.h [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/test/fake_server/fake_server_verifier.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/tools/sync_client.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/tools/sync_listen_notifications.cc [modify] https://crrev.com/8d8162fe30531d1ef447fdff67edd9b8fc222b6a/components/sync/tools/testserver/run_sync_testserver.cc
This is now completed for components/sync, but still need to do this for: * components/browser_sync/ * components/sync_bookmarks/ * components/sync_sessions/ * chrome/browser/sync/
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/24ffc6beca26a97644288f92570901d7a73e7911 commit 24ffc6beca26a97644288f92570901d7a73e7911 Author: skym <skym@chromium.org> Date: Fri Oct 28 15:22:42 2016 [Sync] Replacing NULL with nullptr/null throughout sync code. BUG= 656773 Review-Url: https://codereview.chromium.org/2461463002 Cr-Commit-Position: refs/heads/master@{#428376} [modify] https://crrev.com/24ffc6beca26a97644288f92570901d7a73e7911/chrome/browser/sync/glue/synced_window_delegate_android.cc [modify] https://crrev.com/24ffc6beca26a97644288f92570901d7a73e7911/chrome/browser/sync/sessions/notification_service_sessions_router.cc [modify] https://crrev.com/24ffc6beca26a97644288f92570901d7a73e7911/chrome/browser/sync/sessions/sessions_sync_manager_unittest.cc [modify] https://crrev.com/24ffc6beca26a97644288f92570901d7a73e7911/chrome/browser/sync/sync_error_notifier_ash.cc [modify] https://crrev.com/24ffc6beca26a97644288f92570901d7a73e7911/chrome/browser/sync/sync_error_notifier_ash_unittest.cc [modify] https://crrev.com/24ffc6beca26a97644288f92570901d7a73e7911/chrome/browser/sync/sync_error_notifier_factory_ash.cc [modify] https://crrev.com/24ffc6beca26a97644288f92570901d7a73e7911/chrome/browser/sync/sync_global_error.cc [modify] https://crrev.com/24ffc6beca26a97644288f92570901d7a73e7911/chrome/browser/sync/sync_global_error_factory.cc [modify] https://crrev.com/24ffc6beca26a97644288f92570901d7a73e7911/chrome/browser/sync/sync_global_error_factory.h [modify] https://crrev.com/24ffc6beca26a97644288f92570901d7a73e7911/chrome/browser/sync/sync_global_error_unittest.cc [modify] https://crrev.com/24ffc6beca26a97644288f92570901d7a73e7911/chrome/browser/sync/sync_ui_util.cc [modify] https://crrev.com/24ffc6beca26a97644288f92570901d7a73e7911/chrome/browser/sync/sync_ui_util.h [modify] https://crrev.com/24ffc6beca26a97644288f92570901d7a73e7911/chrome/browser/sync/sync_ui_util_unittest.cc [modify] https://crrev.com/24ffc6beca26a97644288f92570901d7a73e7911/chrome/browser/sync/test/integration/bookmarks_helper.cc [modify] https://crrev.com/24ffc6beca26a97644288f92570901d7a73e7911/chrome/browser/sync/test/integration/fake_server_invalidation_service.cc [modify] https://crrev.com/24ffc6beca26a97644288f92570901d7a73e7911/chrome/browser/sync/test/integration/migration_watcher.cc [modify] https://crrev.com/24ffc6beca26a97644288f92570901d7a73e7911/chrome/browser/sync/test/integration/performance/autofill_sync_perf_test.cc [modify] https://crrev.com/24ffc6beca26a97644288f92570901d7a73e7911/chrome/browser/sync/test/integration/performance/bookmarks_sync_perf_test.cc [modify] https://crrev.com/24ffc6beca26a97644288f92570901d7a73e7911/chrome/browser/sync/test/integration/profile_sync_service_harness.cc [modify] https://crrev.com/24ffc6beca26a97644288f92570901d7a73e7911/chrome/browser/sync/test/integration/single_client_bookmarks_sync_test.cc [modify] https://crrev.com/24ffc6beca26a97644288f92570901d7a73e7911/chrome/browser/sync/test/integration/sync_app_list_helper.cc [modify] https://crrev.com/24ffc6beca26a97644288f92570901d7a73e7911/chrome/browser/sync/test/integration/sync_arc_package_helper.cc [modify] https://crrev.com/24ffc6beca26a97644288f92570901d7a73e7911/chrome/browser/sync/test/integration/sync_auth_test.cc [modify] https://crrev.com/24ffc6beca26a97644288f92570901d7a73e7911/chrome/browser/sync/test/integration/sync_datatype_helper.cc [modify] https://crrev.com/24ffc6beca26a97644288f92570901d7a73e7911/chrome/browser/sync/test/integration/sync_extension_helper.cc [modify] https://crrev.com/24ffc6beca26a97644288f92570901d7a73e7911/chrome/browser/sync/test/integration/sync_test.cc [modify] https://crrev.com/24ffc6beca26a97644288f92570901d7a73e7911/chrome/browser/sync/test/integration/sync_test.h [modify] https://crrev.com/24ffc6beca26a97644288f92570901d7a73e7911/chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc [modify] https://crrev.com/24ffc6beca26a97644288f92570901d7a73e7911/chrome/browser/sync/test/integration/typed_urls_helper.cc [modify] https://crrev.com/24ffc6beca26a97644288f92570901d7a73e7911/components/browser_sync/profile_sync_service.cc [modify] https://crrev.com/24ffc6beca26a97644288f92570901d7a73e7911/components/browser_sync/profile_sync_service.h [modify] https://crrev.com/24ffc6beca26a97644288f92570901d7a73e7911/components/browser_sync/profile_sync_service_autofill_unittest.cc [modify] https://crrev.com/24ffc6beca26a97644288f92570901d7a73e7911/components/browser_sync/profile_sync_service_bookmark_unittest.cc [modify] https://crrev.com/24ffc6beca26a97644288f92570901d7a73e7911/components/browser_sync/profile_sync_service_typed_url_unittest.cc [modify] https://crrev.com/24ffc6beca26a97644288f92570901d7a73e7911/components/browser_sync/test_profile_sync_service.h [modify] https://crrev.com/24ffc6beca26a97644288f92570901d7a73e7911/components/sync_bookmarks/bookmark_change_processor.cc [modify] https://crrev.com/24ffc6beca26a97644288f92570901d7a73e7911/components/sync_bookmarks/bookmark_change_processor.h [modify] https://crrev.com/24ffc6beca26a97644288f92570901d7a73e7911/components/sync_bookmarks/bookmark_model_associator.cc [modify] https://crrev.com/24ffc6beca26a97644288f92570901d7a73e7911/components/sync_bookmarks/bookmark_model_associator.h [modify] https://crrev.com/24ffc6beca26a97644288f92570901d7a73e7911/components/sync_sessions/favicon_cache.cc [modify] https://crrev.com/24ffc6beca26a97644288f92570901d7a73e7911/components/sync_sessions/session_data_type_controller_unittest.cc [modify] https://crrev.com/24ffc6beca26a97644288f92570901d7a73e7911/components/sync_sessions/sessions_sync_manager.cc [modify] https://crrev.com/24ffc6beca26a97644288f92570901d7a73e7911/components/sync_sessions/sync_sessions_metrics.cc [modify] https://crrev.com/24ffc6beca26a97644288f92570901d7a73e7911/components/sync_sessions/synced_session_tracker.h
Comment 1 by s...@chromium.org
, Oct 17 2016