[Remoting Android] Add OpenGL ES version requirement in the manifest |
|||||||||
Issue descriptionWe should add a required OpenGL ES version to the android manifest. It's unlikely that not defining this requirement will cause any problem since devices that support Android 2.0+ should already support ES 2.0. However, adding this to the manifest makes it clear what minimum OpenGL version we want to support and prevents potential compatibility problem if my assumption is incorrect.
,
Oct 17 2016
,
Oct 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ca8acc542f210dbc2037f2f7830c6838de5e809 commit 6ca8acc542f210dbc2037f2f7830c6838de5e809 Author: yuweih <yuweih@chromium.org> Date: Mon Oct 17 20:15:11 2016 [Remoting Android] Add minimum OpenGL ES version requirement This CL adds the OpenGL ES requirement. Although devices that support Android 2.0+ should already support ES 2.0, adding this to the manifest makes it clear what minimum version we want to support. BUG= 656754 Review-Url: https://codereview.chromium.org/2429603002 Cr-Commit-Position: refs/heads/master@{#425765} [modify] https://crrev.com/6ca8acc542f210dbc2037f2f7830c6838de5e809/remoting/android/java/AndroidManifest.xml.jinja2
,
Oct 17 2016
This change will only affect the Chrome Remote Desktop client and will not affect the Chrome browser.
,
Oct 17 2016
Your change meets the bar and is auto-approved for M55 (branch: 2883)
,
Oct 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8fc214d7850962498859a59398efc8d037a2c61c commit 8fc214d7850962498859a59398efc8d037a2c61c Author: Yuwei Huang <yuweih@chromium.org> Date: Mon Oct 17 21:56:32 2016 [Remoting Android] Add minimum OpenGL ES version requirement This CL adds the OpenGL ES requirement. Although devices that support Android 2.0+ should already support ES 2.0, adding this to the manifest makes it clear what minimum version we want to support. BUG= 656754 Review-Url: https://codereview.chromium.org/2429603002 Cr-Commit-Position: refs/heads/master@{#425765} (cherry picked from commit 6ca8acc542f210dbc2037f2f7830c6838de5e809) Review URL: https://codereview.chromium.org/2427673003 . Cr-Commit-Position: refs/branch-heads/2883@{#161} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/8fc214d7850962498859a59398efc8d037a2c61c/remoting/android/java/AndroidManifest.xml.jinja2
,
Oct 17 2016
,
Oct 18 2016
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8fc214d7850962498859a59398efc8d037a2c61c commit 8fc214d7850962498859a59398efc8d037a2c61c Author: Yuwei Huang <yuweih@chromium.org> Date: Mon Oct 17 21:56:32 2016 [Remoting Android] Add minimum OpenGL ES version requirement This CL adds the OpenGL ES requirement. Although devices that support Android 2.0+ should already support ES 2.0, adding this to the manifest makes it clear what minimum version we want to support. BUG= 656754 Review-Url: https://codereview.chromium.org/2429603002 Cr-Commit-Position: refs/heads/master@{#425765} (cherry picked from commit 6ca8acc542f210dbc2037f2f7830c6838de5e809) Review URL: https://codereview.chromium.org/2427673003 . Cr-Commit-Position: refs/branch-heads/2883@{#161} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/8fc214d7850962498859a59398efc8d037a2c61c/remoting/android/java/AndroidManifest.xml.jinja2
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840 |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by joedow@chromium.org
, Oct 17 2016