ghostscript: AUXEXTRALIBS not set correctly |
|||||||
Issue descriptionAUXEXTRALIBS is the option to set extra library for aux tools, tools compiled for the host to compile the target ghostscipt. It is set once in auxflags.mak.in AUXEXTRALIBS=@LIBS@ And set again in Makefile.in. The second set is incorrect, because it will get the options for the target build. In particular, -lpaper is added, while the aux tools are configured with --without-libpaper. We have a workaround in virtual target chromium os sdk (CL/399645), but the fix should be in ghostscript.
,
Oct 21 2016
Brian, do you have time/bandwidth for this? If not, assign back to me
,
Oct 21 2016
I can probably get to this sometime. It's not urgent, but I do have some context for it already.
,
Nov 21 2016
,
Jun 6 2017
Brian, is this still an issue?
,
Jun 6 2017
Technically, yes. We're currently pulling in an extra dependency to the SDK to workaround Ghostscript's bad autoconf.
,
Jun 6 2017
It actually looks like upstream Ghostscript merged different work (with additional bugfixes) to master, and it doesn't have the $subject bug. So I backported that here: https://chromium-review.googlesource.com/526340 ghostscript-gpl: sync CCAUX work with upstream https://chromium-review.googlesource.com/526341 target-chromium-os-sdk: drop unneeded libpaper dep I'm running this through the builders (heavily backlogged, so it'll be a while...)
,
Jun 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/ee5aab286a9f1c5048370ddff1e1052a7e4befaa commit ee5aab286a9f1c5048370ddff1e1052a7e4befaa Author: Brian Norris <briannorris@chromium.org> Date: Thu Jun 08 06:45:32 2017 ghostscript-gpl: sync CCAUX work with upstream Ghostscript folks seem to have reworked a few things and fixed bugs from their latest 'CCAUX-configure' branch before merging it to their master branch. We would like at least one of those: Particularly, Makefile.in was including the whole 'auxflags.mak' file, but then it would re-set the AUXEXTRALIBS variable to something that included some cross-targeted linker flags. The version that was merged stopped including auxflags.mak, and then got the correct AUXEXTRALIBS. BUG= chromium:656742 TEST=chromiumos-sdk builder; also a few local builds, to make sure cross-compilation works, and that I can `sudo emerge --unmerge libpaper` and still build Change-Id: I9e67584a6c54735fe1e2638059ea669b468bf5f1 Signed-off-by: Brian Norris <briannorris@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/526340 Reviewed-by: Sean Kau <skau@chromium.org> [modify] https://crrev.com/ee5aab286a9f1c5048370ddff1e1052a7e4befaa/app-text/ghostscript-gpl/files/ghostscript-gpl-9.19-ccaux.patch [rename] https://crrev.com/ee5aab286a9f1c5048370ddff1e1052a7e4befaa/app-text/ghostscript-gpl/ghostscript-gpl-9.19-r8.ebuild
,
Jun 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/1ecc2795b53d6048ce502e44a6e936afaf7021fc commit 1ecc2795b53d6048ce502e44a6e936afaf7021fc Author: Brian Norris <briannorris@chromium.org> Date: Thu Jun 08 06:45:32 2017 target-chromium-os-sdk: drop unneeded libpaper dep Now that the Ghostscript ebuild is fixed to not require libpaper in the SDK, let's revert commit 44f1564239a1 ("target-chromium-os-sdk: Add lcms/libpaper needed by ghostscript tools."). BUG= chromium:656742 TEST=chromiumos-sdk builder Change-Id: I6e1357d778ec9652eac89399c7fd596e83175446 Signed-off-by: Brian Norris <briannorris@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/526341 Tested-by: Sean Kau <skau@chromium.org> Reviewed-by: Sean Kau <skau@chromium.org> [rename] https://crrev.com/1ecc2795b53d6048ce502e44a6e936afaf7021fc/virtual/target-chromium-os-sdk/target-chromium-os-sdk-1-r76.ebuild [modify] https://crrev.com/1ecc2795b53d6048ce502e44a6e936afaf7021fc/virtual/target-chromium-os-sdk/target-chromium-os-sdk-1.ebuild
,
Jun 8 2017
,
Jan 22 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by briannorris@chromium.org
, Oct 17 2016