New issue
Advanced search Search tips

Issue 656741 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Deprecate "root" and "use_mirror" build properties.

Project Member Reported by d...@chromium.org, Oct 17 2016

Issue description

These are dated and should not be integrated into the core recipe engine.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/124f02dd3006293789d17557aea29dfbb8f911e0

commit 124f02dd3006293789d17557aea29dfbb8f911e0
Author: dnj <dnj@chromium.org>
Date: Mon Oct 17 19:11:20 2016

Remove use of "use_mirror" recipe property.

The "use_mirror" property is set by the recipe engine when in a
production environment to signal to the "gclient" recipe module that the SVN
GOLO mirror should be used instead of the default SVN URL. Since we're
not on SVN, this is now meaningless. It will be deprecated in recipe
engine, so remove references.

The "perf_dashboard" recipe has been using this property as a test to see if
it is running on a production system. This test has been replaced with
the identical logic that the recipe engine was using to set
"use_mirror". A build property has been added to indicate production
runs, and a note has been added to indicate that the perf dashboard bot
should explicitly specify this as a property rather than infer it from
the environment.

BUG= chromium:656741 
TEST=expectations
R=iannucci@chromium.org, martiniss@chromium.org

Review-Url: https://codereview.chromium.org/2427763002

[modify] https://crrev.com/124f02dd3006293789d17557aea29dfbb8f911e0/scripts/slave/recipe_modules/perf_dashboard/api.py
[modify] https://crrev.com/124f02dd3006293789d17557aea29dfbb8f911e0/scripts/slave/recipe_modules/perf_dashboard/example.expected/linux.json
[rename] https://crrev.com/124f02dd3006293789d17557aea29dfbb8f911e0/scripts/slave/recipe_modules/perf_dashboard/example.expected/linux_testing.json
[modify] https://crrev.com/124f02dd3006293789d17557aea29dfbb8f911e0/scripts/slave/recipe_modules/perf_dashboard/example.expected/mac.json
[copy] https://crrev.com/124f02dd3006293789d17557aea29dfbb8f911e0/scripts/slave/recipe_modules/perf_dashboard/example.expected/mac_testing.json
[delete] https://crrev.com/9f623ff560eeca917efb9b799a1ca3137f9dcaa0/scripts/slave/recipe_modules/perf_dashboard/example.expected/mac_use_mirror.json
[modify] https://crrev.com/124f02dd3006293789d17557aea29dfbb8f911e0/scripts/slave/recipe_modules/perf_dashboard/example.expected/win.json
[rename] https://crrev.com/124f02dd3006293789d17557aea29dfbb8f911e0/scripts/slave/recipe_modules/perf_dashboard/example.expected/win_testing.json
[modify] https://crrev.com/124f02dd3006293789d17557aea29dfbb8f911e0/scripts/slave/recipe_modules/perf_dashboard/example.py
[modify] https://crrev.com/124f02dd3006293789d17557aea29dfbb8f911e0/scripts/tools/run_recipe.py

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/829daf60e51ee9e6c78bea29918def500427ac76

commit 829daf60e51ee9e6c78bea29918def500427ac76
Author: recipe-roller <recipe-roller@chromium.org>
Date: Mon Oct 17 22:31:12 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/69fc06f12bb5fc602161bd2169cb54a03fe5634b Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/61728af22d26f33d09ed715d0c43f6051ee9c1ea Fix compile on the Blimp Client Engine Integration bot (shenghuazhang@chromium.org)
  https://crrev.com/f7b18bcd210f254d4b61c92b2a94942fe9b83927 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/dd839c91b9b2e7f1b45683dfe1e7ac68f01157a6 Modify 'build_dir' for run_mb() to avoid double 'Debug' (shenghuazhang@chromium.org)
  https://crrev.com/7eea10901de0274a5be22fdf6479e1109582900a Skia trigger recipe: change remote recipe condition (borenet@chromium.org)
  https://crrev.com/0b094b378658afa9436b1107859128456cd1c08d Add GomaCanaryiOS to chromium.fyi (smut@google.com)
  https://crrev.com/97367d4e07794d107d6075ff86ce898631169e73 Add option to use goma module in chromium.compile (tikuta@chromium.org)
  https://crrev.com/d44afde07794016523aceefdd1de603fc2f75459 V8: Run simple-leak-check step on release and trybot (machenbach@chromium.org)
  https://crrev.com/92dfa57e7376ea9ee60ce378cf16ae290cd9aea3 V8: Bump timeout on arm64 sim nosnap (machenbach@chromium.org)
  https://crrev.com/6b546c5afd0b236ef02e3dfb029d2d630582786c Revert of V8: Run simple-leak-check step on release and trybot (patchset #1 id:1 of https://codereview.chromium.org/2415243003/ ) (machenbach@chromium.org)
  https://crrev.com/94aa3062f0f4cc2542d375cf45706c7e2742c714 libyuv: Switch bots over to GN by default. (kjellander@chromium.org)
  https://crrev.com/ab47d254ddf187fa3b3c0231ea1882557b589f7b Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/3d9ee695a52c6ea7c00b60ae7ce8de03bbf626ed libyuv: Switch {client,tryserver}.libyuv to GN (kjellander@chromium.org)
  https://crrev.com/ded9582695d74387b613dcbcad04936bff12d88b libyuv: Disable signing for iOS (kjellander@chromium.org)
  https://crrev.com/1a9cedbf5751bb8b7d4a59ef43f9618b87b0b97f Updating flags necessary for upload_perf_dashboard_results.py (eyaich@chromium.org)
  https://crrev.com/1088f8337678d51a96fa44917bc9efc64270b0e4 Add the Syzygy x64 bots to the Syzygy waterfall. (sebmarchand@chromium.org)
  https://crrev.com/7ae96413206814a587e3e5921017762be6257983 Use the Chromium-side script to run the PGO benchmarks. (sebmarchand@chromium.org)
  https://crrev.com/02bbb17974a70e1bb198ee4243d830ff258d1bb8 Add IGNORE_DEPS_CHANGES flag and coverage builder. (dnj@chromium.org)
  https://crrev.com/78c3859a73773c4d7eff4ed38c796c147bae998c Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/c0b4818f62ae008fa858794ac278ce7f65cdf92d In archive_layout_test_results, only support archiving to GS. (qyearsley@chromium.org)
  https://crrev.com/65dc88015fad41b08d59d3f47ce157c3d5f8b051 V8: Add valgrind deps to linux64 bots (machenbach@chromium.org)
  https://crrev.com/9f623ff560eeca917efb9b799a1ca3137f9dcaa0 Revert of Add IGNORE_DEPS_CHANGES flag and coverage builder. (patchset #3 id:40001 of https://codereview.chromium.org/2418233002/ ) (dnj@chromium.org)
  https://crrev.com/124f02dd3006293789d17557aea29dfbb8f911e0 Remove use of "use_mirror" recipe property. (dnj@chromium.org)
  https://crrev.com/13c03fad59862d90b2b6bb2372a37ab414074228 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/2d442327bbfad0eb211466afbfe2f5a17c4561da Stop archiving redundant copy of {full,failing}_results.json. (qyearsley@chromium.org)
  https://crrev.com/506376486f9bd8973f5b96a02eddd449a3ef52e2 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/c9ebbd24639c8fb9f7fd2a36032614830e1e5285 Fix logic to detect Gerrit CL in CQ (rmistry@google.com)
  https://crrev.com/1dbb595dbfa4ebf73ee036cd66275af24253a99d Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/48df58136dc1847cd158eaa330f5dd457265d654 Gerrit git cl: make it work with minimal file. (tandrii@chromium.org)
  https://crrev.com/d437d76b64e083f2fb2ff3a7b38638d06642e270 Reland "Remove SVN and File support from gclient" (agable@chromium.org)
  https://crrev.com/aa9e16acd4e74f35dc738b98cd03b2c0b30bfefb Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/1c822ade1f731ec35a3d2d3be8805f773df22c4c Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
recipe_engine:
  https://crrev.com/a15c8474d308784e94fe4e15deb7c7860d717059 Reland: Add post_process hooks to recipe testing facilities. (iannucci@chromium.org)
  https://crrev.com/7076377b62701f77783d2d5e002fe2708ffab273 Fix VerifySubset when comparing empty lists (martiniss@chromium.org)
  https://crrev.com/bb6caf8060139fd4bcefee43f54ae00150e7ce3a Remove 'use_mirror' and 'root' properties. (dnj@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= 656555 , chromium:656741 ,654806, chromium:656731 ,641588,chromium:633253, 656573 , 655810 , chromium:652188 , 655864 ,chromium:648308, chromium:656042 , 309849 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2422383003
Cr-Commit-Position: refs/heads/master@{#425793}

[modify] https://crrev.com/829daf60e51ee9e6c78bea29918def500427ac76/infra/config/recipes.cfg

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/5b2ce2fc72bd22cf493e59189a780cd00f15e5d8

commit 5b2ce2fc72bd22cf493e59189a780cd00f15e5d8
Author: recipe-roller <recipe-roller@chromium.org>
Date: Tue Oct 18 00:55:28 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/9f623ff560eeca917efb9b799a1ca3137f9dcaa0 Revert of Add IGNORE_DEPS_CHANGES flag and coverage builder. (patchset #3 id:40001 of https://codereview.chromium.org/2418233002/ ) (dnj@chromium.org)
  https://crrev.com/124f02dd3006293789d17557aea29dfbb8f911e0 Remove use of "use_mirror" recipe property. (dnj@chromium.org)
  https://crrev.com/13c03fad59862d90b2b6bb2372a37ab414074228 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/2d442327bbfad0eb211466afbfe2f5a17c4561da Stop archiving redundant copy of {full,failing}_results.json. (qyearsley@chromium.org)
  https://crrev.com/506376486f9bd8973f5b96a02eddd449a3ef52e2 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/5993e5340c3d0e30c1c07528f424177cf7c83acc Give ownership of recipes/bisect* to bisect team. (robertocn@chromium.org)
depot_tools:
  https://crrev.com/aa9e16acd4e74f35dc738b98cd03b2c0b30bfefb Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/1c822ade1f731ec35a3d2d3be8805f773df22c4c Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
recipe_engine:
  https://crrev.com/7076377b62701f77783d2d5e002fe2708ffab273 Fix VerifySubset when comparing empty lists (martiniss@chromium.org)
  https://crrev.com/bb6caf8060139fd4bcefee43f54ae00150e7ce3a Remove 'use_mirror' and 'root' properties. (dnj@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= chromium:656741 ,chromium:648308, chromium:656731 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2426803002

[modify] https://crrev.com/5b2ce2fc72bd22cf493e59189a780cd00f15e5d8/infra/config/recipes.cfg

Comment 4 by d...@chromium.org, Oct 18 2016

Status: Fixed (was: Untriaged)

Sign in to add a comment