New issue
Advanced search Search tips

Issue 656738 link

Starred by 1 user
Status: Verified
Owner:
gogerald@chromium.org
Closed: Oct 2016
Cc:
hwi@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Opening a card editor to fix the billing address should not bring up a keyboard

Project Member Reported by rouslan@chromium.org, Oct 17 2016 
Steps to reproduce the problem:

1) Settings -> Autofill forms -> Add a credit card.
2) Name: "Bob"
3) Number "4111 1111 1111 1111"
(Do not set the billing address.)
4) Open "rsolomakhin.github.io/pr" and click "Buy"
5) Select the "Visa*1111" credit card.

Observed: Credit card editor opens with numerical keyboard.

Expected: Credit card editor opens without keyboard. Preferably, the billing address dropdown should have an error icon set. (Currently the user sees the error icon only if they click "Done" in this UI.)
actual.png
180 KB View Download
expected.png
144 KB View Download

Comment 1 by rouslan@chromium.org, Oct 18 2016

Cc: hwi@chromium.org
gogerald@, please take a video of your http://crrev.com/2429703003 fix in action and attach here for hwi@ to review the UX. Thank you!

Video record commands:
$ VIDEO=/sdcard/video.mp4
$ adb shell screenrecord $VIDEO
$ adb pull $VIDEO
$ adb shell rm $VIDEO

Comment 2 by gogerald@chromium.org, Oct 18 2016 

See attached file,
2016_10_18_17_07_42.mp4
6.1 MB View Download

Comment 3 by rouslan@chromium.org, Oct 18 2016 

hwi@: I think this looks good. Would you agree?

Comment 4 by hwi@chromium.org, Oct 18 2016 

Thanks for working on this, gogerald@ and rouslan@. We have another cleanup proposal that's coming up your way soon e.g. title string change, spacing polish, error styling, etc. Until we get to it, this LGTM to fix the keyboard issue, which is more urgent. Thanks a lot!
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a99e608c125e3f5dc1437bf1bbf299c75762c4ad

commit a99e608c125e3f5dc1437bf1bbf299c75762c4ad
Author: gogerald <gogerald@chromium.org>
Date: Tue Oct 18 23:10:23 2016

Show errors and hide keyboard for opening card editor to fix required fields

BUG= 656738 

Review-Url: https://codereview.chromium.org/2429703003
Cr-Commit-Position: refs/heads/master@{#426081}

[modify] https://crrev.com/a99e608c125e3f5dc1437bf1bbf299c75762c4ad/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java

Comment 6 by gogerald@chromium.org, Oct 19 2016

Status: Fixed (was: Assigned)

Comment 7 by arunshan@chromium.org, Oct 20 2016

Status: Verified (was: Fixed)
This issue is fixed in current M56 56.0.2895.3. UI appears as the expected.png image in the comment #0

Comment 8 by lafo...@chromium.org, Jun 27 2017

Components: -UI>Browser>Autofill>Payments UI>Browser>Payments
►

Sign in to add a comment