Only match host port pair when determining if a proxy is a data reduction proxy |
||||||||
Issue descriptionDataReductionProxyConfig::IsDataReductionProxy() compares a given proxy server with the list of proxy servers when determining if a given proxy is a data reduction proxy or not. However, that function returns false if the given proxy has a different scheme (e.g., QUIC) than the scheme of the data reduction proxy stored in the config. To fix this, DataReductionProxyConfig::IsDataReductionProxy() should only compare the proxy host port pairs (and not the scheme). This ensures that a valid data reduction QUIC proxy is actually determined as a data reduction proxy.
,
Oct 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/663c27f0b48b3f49725eb2095f716db80d49fad5 commit 663c27f0b48b3f49725eb2095f716db80d49fad5 Author: tbansal <tbansal@chromium.org> Date: Mon Oct 17 20:11:33 2016 Only match host port pair when determining if a proxy is a data reduction proxy This ensures that a valid data reduction QUIC proxy is actually determined as a data reduction proxy. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.android:android_cronet BUG= 656727 Review-Url: https://codereview.chromium.org/2424973002 Cr-Commit-Position: refs/heads/master@{#425764} [modify] https://crrev.com/663c27f0b48b3f49725eb2095f716db80d49fad5/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc [modify] https://crrev.com/663c27f0b48b3f49725eb2095f716db80d49fad5/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc
,
Oct 18 2016
,
Oct 18 2016
Your change meets the bar and is auto-approved for M55 (branch: 2883)
,
Oct 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3687d9bae01fac3c606fd8ef9305b54b0a1ff8c1 commit 3687d9bae01fac3c606fd8ef9305b54b0a1ff8c1 Author: Tarun Bansal <tbansal@google.com> Date: Tue Oct 18 20:39:03 2016 Only match host port pair when determining if a proxy is a data reduction proxy This ensures that a valid data reduction QUIC proxy is actually determined as a data reduction proxy. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.android:android_cronet BUG= 656727 Review-Url: https://codereview.chromium.org/2424973002 Cr-Commit-Position: refs/heads/master@{#425764} (cherry picked from commit 663c27f0b48b3f49725eb2095f716db80d49fad5) Review URL: https://codereview.chromium.org/2430803002 . Cr-Commit-Position: refs/branch-heads/2883@{#181} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/3687d9bae01fac3c606fd8ef9305b54b0a1ff8c1/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc [modify] https://crrev.com/3687d9bae01fac3c606fd8ef9305b54b0a1ff8c1/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc
,
Oct 27 2016
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3687d9bae01fac3c606fd8ef9305b54b0a1ff8c1 commit 3687d9bae01fac3c606fd8ef9305b54b0a1ff8c1 Author: Tarun Bansal <tbansal@google.com> Date: Tue Oct 18 20:39:03 2016 Only match host port pair when determining if a proxy is a data reduction proxy This ensures that a valid data reduction QUIC proxy is actually determined as a data reduction proxy. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.android:android_cronet BUG= 656727 Review-Url: https://codereview.chromium.org/2424973002 Cr-Commit-Position: refs/heads/master@{#425764} (cherry picked from commit 663c27f0b48b3f49725eb2095f716db80d49fad5) Review URL: https://codereview.chromium.org/2430803002 . Cr-Commit-Position: refs/branch-heads/2883@{#181} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/3687d9bae01fac3c606fd8ef9305b54b0a1ff8c1/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc [modify] https://crrev.com/3687d9bae01fac3c606fd8ef9305b54b0a1ff8c1/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840
,
Feb 22 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by tbansal@chromium.org
, Oct 17 2016