New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 656725 link

Starred by 1 user
Status: Duplicate
Merged: issue 659066
Owner: ----
Closed: Oct 2016
Cc:
perezju@chromium.org
█ jasontiller@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

3.4%-5.6% regression in memory.top_10_mobile at 425422:425604

Project Member Reported by jasontiller@chromium.org, Oct 17 2016 
See the link to graphs below.
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Oct 17 2016 


===== BISECT JOB RESULTS =====
Status: failed


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N  Good?
chromium@425422  4766925  5340.53  5  good
chromium@425604  5002240  9605.97  5  bad

Bisect job ran on: android_one_perf_bisect
Bug ID: 656725

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile
Test Metric: memory:chrome:all_processes:reported_by_os:system_memory:java_heap:proportional_resident_size_avg/background/after_https_m_facebook_com_rihanna
Relative Change: 4.94%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_one_perf_bisect/builds/1715
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8998532044225979056


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5259594765434880

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Oct 17 2016 


===== BISECT JOB RESULTS =====
Status: failed


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N   Good?
chromium@425421  4630869  8962.55  12  good
chromium@425604  4641792  8732.7   12  bad

Bisect job ran on: android_one_perf_bisect
Bug ID: 656725

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=after.http.m.youtube.com.results.q.science memory.top_10_mobile
Test Metric: memory:chrome:all_processes:reported_by_os:system_memory:java_heap:proportional_resident_size_avg/background/after_http_m_youtube_com_results_q_science
Relative Change: 0.19%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_one_perf_bisect/builds/1717
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8998525022914404288


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5838248058814464

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Oct 17 2016 

Bisect failed: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5_perf_bisect/builds/4246
Failure reason: the build has failed due to infrastructure failure.
Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, Oct 18 2016 


===== BISECT JOB RESULTS =====
Status: failed


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N  Good?
chromium@425421  4626227  3426.96  5  good
chromium@425604  4637184  8319.02  8  bad

Bisect job ran on: android_one_perf_bisect
Bug ID: 656725

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=after.http.m.youtube.com.results.q.science memory.top_10_mobile
Test Metric: memory:chrome:all_processes:reported_by_os:system_memory:java_heap:proportional_resident_size_avg/background/after_http_m_youtube_com_results_q_science
Relative Change: 0.28%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_one_perf_bisect/builds/1718
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8998509237263781040


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5833455949053952

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Comment 11 by perezju@chromium.org, Oct 18 2016

Cc: perezju@chromium.org
Project Member

Comment 12 by 42576172...@developer.gserviceaccount.com, Oct 18 2016 


===== BISECT JOB RESULTS =====
Status: failed


===== TESTED REVISIONS =====
Revision         Mean      Std Dev  N  Good?
chromium@425415  91770880  835393   5  good
chromium@425604  95137792  832224   5  bad

Bisect job ran on: android_nexus5_perf_bisect
Bug ID: 656725

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=http.m.youtube.com.results.q.science memory.top_10_mobile
Test Metric: memory:chrome:all_processes:reported_by_os:gpu_memory:proportional_resident_size_avg/foreground/http_m_youtube_com_results_q_science
Relative Change: 3.67%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5_perf_bisect/builds/4255
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8998452379460607728


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5778800611164160

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Project Member

Comment 14 by 42576172...@developer.gserviceaccount.com, Oct 19 2016 

Bisect failed: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_one_perf_bisect/builds/1736
Failure reason: the build has failed due to infrastructure failure.
Project Member

Comment 16 by 42576172...@developer.gserviceaccount.com, Oct 26 2016

Mergedinto: 659066
Status: Duplicate (was: Untriaged)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Remove unsafe getFontMetrics methods
Author  : eae
Commit description:
  
Remove the ComputedStyle::getFontMetrics and Font::getFontMetrics helper
methods as they both assume that the primaryFont method always returns a
valid SimpleFontDataObject. That assumption is both incorrect and unsafe
as it can return nullptr in case fallback to the last-resort-font fails.

By replacing the convince calls with explicit calls and null checks that
type of problems becomes more apparent and can be handled appropriately.

R=wkorman@chromium.org
BUG=655815
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2416033003
Cr-Commit-Position: refs/heads/master@{#425437}
Commit  : fdcbab80bc37108f6e03d6906f27831228690350
Date    : Fri Oct 14 19:51:13 2016


===== TESTED REVISIONS =====
Revision         Mean      Std Dev  N   Good?
chromium@425350  11149482  2471517  18  good
chromium@425425  9984397   4081577  12  good
chromium@425435  10286591  3882403  27  good
chromium@425436  9984397   4081577  12  good
chromium@425437  11523280  6303464  27  bad    <--
chromium@425438  13133766  4551659  18  bad
chromium@425440  13643491  4106017  12  bad
chromium@425444  15172664  0.0      5   bad
chromium@425463  12851597  5420844  12  bad
chromium@425500  12482957  5399023  12  bad
chromium@425650  12605837  5329209  18  bad

Bisect job ran on: android_nexus5_perf_bisect
Bug ID: 656725

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=http.m.youtube.com.results.q.science memory.top_10_mobile
Test Metric: memory:chrome:all_processes:reported_by_chrome:gpu:effective_size_avg/foreground/http_m_youtube_com_results_q_science
Relative Change: 18.15%
Score: 0.0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5_perf_bisect/builds/4296
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8997724263408679728


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5243749054021632

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Project Member

Comment 20 by 42576172...@developer.gserviceaccount.com, Apr 11 2017 


=== BISECT JOB RESULTS ===
Perf regression found but unable to narrow commit range

Build failures prevented the bisect from narrowing the range further.


Bisect Details
  Configuration: android_nexus5_perf_bisect
  Benchmark    : memory.top_10_mobile
  Metric       : memory:chrome:all_processes:reported_by_os:gpu_memory:proportional_resident_size_avg/foreground/http_m_youtube_com_results_q_science

Suspected Commit Range
  1 commits in range
  https://chromium.googlesource.com/chromium/src/+log/0b18f8385af6097264889f6e368bbd3b31c11b09..3d5a0fb164db4c2c24e83fe859463aa4268918a4


Revision             Result                  N
chromium@425415      91770880 +- 835393      5      good
chromium@425604      95137792 +- 832224      5      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=http.m.youtube.com.results.q.science memory.top_10_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8982592624234089440

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5778800611164160


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
►

Sign in to add a comment