New issue
Advanced search Search tips

Issue 656709 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Feature



Sign in to add a comment

Add Chrome's executable when launching the CCT

Project Member Reported by alito@chromium.org, Oct 17 2016

Issue description

The CCT should receive Chrome's executable path as a flag when launched from Chrome.
 

Comment 1 by alito@chromium.org, Oct 17 2016

This was fixed in the following CL: https://codereview.chromium.org/2421683002/ and has been in Canary for a few days now.

Comment 2 by alito@chromium.org, Oct 17 2016

Status: Fixed (was: Untriaged)

Comment 3 by alito@chromium.org, Oct 17 2016

Labels: Merge-Request-55
We would like to merge this change into M55. It is a two-line change that adds a command-line flag when launching the CCT (chrome cleanup tool) and I have tested that it works on the Canary channel.

Comment 4 by gov...@chromium.org, Oct 17 2016

Is this change applicable to all OS or any specific OS?

Comment 5 by alito@chromium.org, Oct 17 2016

Labels: OS-Windows
This is a Windows-only feature.

Comment 6 by dimu@chromium.org, Oct 18 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 18 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/646d0ec1b8e6c264402af29e47a3171da93e76db

commit 646d0ec1b8e6c264402af29e47a3171da93e76db
Author: Chris Sharp <csharp@chromium.org>
Date: Tue Oct 18 19:21:24 2016

Add Chrome's executable path when launching the CCT.

BUG= 656709 
TBR=alito@chromium.org

Review-Url: https://codereview.chromium.org/2421683002
Cr-Commit-Position: refs/heads/master@{#425416}
(cherry picked from commit 48849c8947b9eab911644d910625f0aee9209500)

Review URL: https://codereview.chromium.org/2429893002 .

Cr-Commit-Position: refs/branch-heads/2883@{#179}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/646d0ec1b8e6c264402af29e47a3171da93e76db/chrome/browser/safe_browsing/srt_global_error_win.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/646d0ec1b8e6c264402af29e47a3171da93e76db

commit 646d0ec1b8e6c264402af29e47a3171da93e76db
Author: Chris Sharp <csharp@chromium.org>
Date: Tue Oct 18 19:21:24 2016

Add Chrome's executable path when launching the CCT.

BUG= 656709 
TBR=alito@chromium.org

Review-Url: https://codereview.chromium.org/2421683002
Cr-Commit-Position: refs/heads/master@{#425416}
(cherry picked from commit 48849c8947b9eab911644d910625f0aee9209500)

Review URL: https://codereview.chromium.org/2429893002 .

Cr-Commit-Position: refs/branch-heads/2883@{#179}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/646d0ec1b8e6c264402af29e47a3171da93e76db/chrome/browser/safe_browsing/srt_global_error_win.cc

Comment 9 by dimu@google.com, Nov 4 2016

[Automated comment] removing mislabelled merge-merged-2840

Comment 10 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840

Sign in to add a comment