Add Chrome's executable when launching the CCT |
||||||||
Issue descriptionThe CCT should receive Chrome's executable path as a flag when launched from Chrome.
,
Oct 17 2016
,
Oct 17 2016
We would like to merge this change into M55. It is a two-line change that adds a command-line flag when launching the CCT (chrome cleanup tool) and I have tested that it works on the Canary channel.
,
Oct 17 2016
Is this change applicable to all OS or any specific OS?
,
Oct 17 2016
This is a Windows-only feature.
,
Oct 18 2016
Your change meets the bar and is auto-approved for M55 (branch: 2883)
,
Oct 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/646d0ec1b8e6c264402af29e47a3171da93e76db commit 646d0ec1b8e6c264402af29e47a3171da93e76db Author: Chris Sharp <csharp@chromium.org> Date: Tue Oct 18 19:21:24 2016 Add Chrome's executable path when launching the CCT. BUG= 656709 TBR=alito@chromium.org Review-Url: https://codereview.chromium.org/2421683002 Cr-Commit-Position: refs/heads/master@{#425416} (cherry picked from commit 48849c8947b9eab911644d910625f0aee9209500) Review URL: https://codereview.chromium.org/2429893002 . Cr-Commit-Position: refs/branch-heads/2883@{#179} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/646d0ec1b8e6c264402af29e47a3171da93e76db/chrome/browser/safe_browsing/srt_global_error_win.cc
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/646d0ec1b8e6c264402af29e47a3171da93e76db commit 646d0ec1b8e6c264402af29e47a3171da93e76db Author: Chris Sharp <csharp@chromium.org> Date: Tue Oct 18 19:21:24 2016 Add Chrome's executable path when launching the CCT. BUG= 656709 TBR=alito@chromium.org Review-Url: https://codereview.chromium.org/2421683002 Cr-Commit-Position: refs/heads/master@{#425416} (cherry picked from commit 48849c8947b9eab911644d910625f0aee9209500) Review URL: https://codereview.chromium.org/2429893002 . Cr-Commit-Position: refs/branch-heads/2883@{#179} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/646d0ec1b8e6c264402af29e47a3171da93e76db/chrome/browser/safe_browsing/srt_global_error_win.cc
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840 |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by alito@chromium.org
, Oct 17 2016