New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 656706 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 309237



Sign in to add a comment

Move MediaKeys::Exception to CdmPromise::Exception

Project Member Reported by xhw...@chromium.org, Oct 17 2016

Issue description

This exception is only used in the context of CdmPromise, so CdmPromise::Exception makes more sense.
 

Comment 1 by xhw...@chromium.org, Oct 17 2016

Blocking: 309237

Comment 2 by coron...@gmail.com, Oct 22 2016

I 'm working on this https://codereview.chromium.org/2444683002.

Comment 3 by xhw...@chromium.org, Oct 24 2016

Cc: coron...@gmail.com
corona10: Thank you so much for the help!
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f1c7d36ea538592da4305f4e0742ec8d524e680

commit 1f1c7d36ea538592da4305f4e0742ec8d524e680
Author: corona10 <corona10@gmail.com>
Date: Thu Oct 27 17:08:10 2016

Move MediaKeys::Exception to CdmPromise::Exception

BUG= 656706 

Review-Url: https://codereview.chromium.org/2444683002
Cr-Commit-Position: refs/heads/master@{#428061}

[modify] https://crrev.com/1f1c7d36ea538592da4305f4e0742ec8d524e680/chromecast/media/cdm/cast_cdm_proxy.cc
[modify] https://crrev.com/1f1c7d36ea538592da4305f4e0742ec8d524e680/content/renderer/media/cdm/ppapi_decryptor.cc
[modify] https://crrev.com/1f1c7d36ea538592da4305f4e0742ec8d524e680/content/renderer/pepper/content_decryptor_delegate.cc
[modify] https://crrev.com/1f1c7d36ea538592da4305f4e0742ec8d524e680/media/base/android/media_drm_bridge.cc
[modify] https://crrev.com/1f1c7d36ea538592da4305f4e0742ec8d524e680/media/base/android/media_drm_bridge.h
[modify] https://crrev.com/1f1c7d36ea538592da4305f4e0742ec8d524e680/media/base/cdm_callback_promise.cc
[modify] https://crrev.com/1f1c7d36ea538592da4305f4e0742ec8d524e680/media/base/cdm_callback_promise.h
[modify] https://crrev.com/1f1c7d36ea538592da4305f4e0742ec8d524e680/media/base/cdm_initialized_promise.cc
[modify] https://crrev.com/1f1c7d36ea538592da4305f4e0742ec8d524e680/media/base/cdm_initialized_promise.h
[modify] https://crrev.com/1f1c7d36ea538592da4305f4e0742ec8d524e680/media/base/cdm_promise.h
[modify] https://crrev.com/1f1c7d36ea538592da4305f4e0742ec8d524e680/media/base/cdm_promise_adapter.cc
[modify] https://crrev.com/1f1c7d36ea538592da4305f4e0742ec8d524e680/media/base/cdm_promise_adapter.h
[modify] https://crrev.com/1f1c7d36ea538592da4305f4e0742ec8d524e680/media/base/ipc/media_param_traits_macros.h
[modify] https://crrev.com/1f1c7d36ea538592da4305f4e0742ec8d524e680/media/base/media_keys.h
[modify] https://crrev.com/1f1c7d36ea538592da4305f4e0742ec8d524e680/media/blink/cdm_result_promise.h
[modify] https://crrev.com/1f1c7d36ea538592da4305f4e0742ec8d524e680/media/blink/cdm_result_promise_helper.cc
[modify] https://crrev.com/1f1c7d36ea538592da4305f4e0742ec8d524e680/media/blink/cdm_result_promise_helper.h
[modify] https://crrev.com/1f1c7d36ea538592da4305f4e0742ec8d524e680/media/blink/new_session_cdm_result_promise.cc
[modify] https://crrev.com/1f1c7d36ea538592da4305f4e0742ec8d524e680/media/blink/new_session_cdm_result_promise.h
[modify] https://crrev.com/1f1c7d36ea538592da4305f4e0742ec8d524e680/media/cdm/aes_decryptor.cc
[modify] https://crrev.com/1f1c7d36ea538592da4305f4e0742ec8d524e680/media/cdm/aes_decryptor_unittest.cc
[modify] https://crrev.com/1f1c7d36ea538592da4305f4e0742ec8d524e680/media/cdm/cdm_adapter.cc
[modify] https://crrev.com/1f1c7d36ea538592da4305f4e0742ec8d524e680/media/cdm/cdm_adapter_unittest.cc
[modify] https://crrev.com/1f1c7d36ea538592da4305f4e0742ec8d524e680/media/cdm/ppapi/external_clear_key/clear_key_cdm.cc
[modify] https://crrev.com/1f1c7d36ea538592da4305f4e0742ec8d524e680/media/cdm/ppapi/external_clear_key/clear_key_cdm.h
[modify] https://crrev.com/1f1c7d36ea538592da4305f4e0742ec8d524e680/media/mojo/clients/mojo_cdm.cc
[modify] https://crrev.com/1f1c7d36ea538592da4305f4e0742ec8d524e680/media/mojo/interfaces/content_decryption_module.mojom
[modify] https://crrev.com/1f1c7d36ea538592da4305f4e0742ec8d524e680/media/mojo/interfaces/content_decryption_module.typemap
[modify] https://crrev.com/1f1c7d36ea538592da4305f4e0742ec8d524e680/media/mojo/services/mojo_cdm_promise.cc
[modify] https://crrev.com/1f1c7d36ea538592da4305f4e0742ec8d524e680/media/mojo/services/mojo_cdm_promise.h
[modify] https://crrev.com/1f1c7d36ea538592da4305f4e0742ec8d524e680/media/mojo/services/mojo_cdm_service.cc
[modify] https://crrev.com/1f1c7d36ea538592da4305f4e0742ec8d524e680/media/remoting/proto/remoting_rpc_message.proto
[modify] https://crrev.com/1f1c7d36ea538592da4305f4e0742ec8d524e680/media/remoting/rpc/proto_enum_utils.cc
[modify] https://crrev.com/1f1c7d36ea538592da4305f4e0742ec8d524e680/media/remoting/rpc/proto_enum_utils.h
[modify] https://crrev.com/1f1c7d36ea538592da4305f4e0742ec8d524e680/media/remoting/rpc/proto_utils.cc
[modify] https://crrev.com/1f1c7d36ea538592da4305f4e0742ec8d524e680/media/remoting/rpc/proto_utils.h
[modify] https://crrev.com/1f1c7d36ea538592da4305f4e0742ec8d524e680/media/test/pipeline_integration_test.cc

Comment 5 by coron...@gmail.com, Oct 28 2016

We move MediaKeys::Exception to CdmPromise::Exception.
And we don't need "media/base/media_keys.h" in "media/base/cdm_promise.h" and "media/base/cdm_callback_promise.h".
But bot fail to compile on win_clang and win_chromium_compile_dbg_ng.
This issue should be solved.
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e462aab03239f5ddfcec2adc598e5d775fb70e2

commit 6e462aab03239f5ddfcec2adc598e5d775fb70e2
Author: jrummell <jrummell@chromium.org>
Date: Thu Jul 13 20:49:47 2017

Fix media_mojo builds

Previously media/mojo/sevices:lib was done as a source_set due to issue
670094. Now that that issue is fixed, the intermediate "lib" target is
no longer needed.

Removing the suppression of duplicate symbols revealed that some of the
CdmPromiseTemplate methods end up in multiple modules when doing a
component build. So fix CdmPromiseTemplate<>::GetResolveParameterType()
implementation to avoid this.

This also enables //media/mojo/services/media_service_unittests on
Windows (which was disabled due to linking issues that are now fixed).

BUG= 676418 , 676055 , 656706 
TEST=media_mojo tests compile and run

Review-Url: https://codereview.chromium.org/2737513004
Cr-Commit-Position: refs/heads/master@{#486472}

[modify] https://crrev.com/6e462aab03239f5ddfcec2adc598e5d775fb70e2/media/BUILD.gn
[modify] https://crrev.com/6e462aab03239f5ddfcec2adc598e5d775fb70e2/media/base/cdm_callback_promise.h
[modify] https://crrev.com/6e462aab03239f5ddfcec2adc598e5d775fb70e2/media/base/cdm_promise.cc
[modify] https://crrev.com/6e462aab03239f5ddfcec2adc598e5d775fb70e2/media/base/cdm_promise.h
[modify] https://crrev.com/6e462aab03239f5ddfcec2adc598e5d775fb70e2/media/cdm/BUILD.gn
[modify] https://crrev.com/6e462aab03239f5ddfcec2adc598e5d775fb70e2/media/mojo/BUILD.gn
[modify] https://crrev.com/6e462aab03239f5ddfcec2adc598e5d775fb70e2/media/mojo/services/BUILD.gn
[modify] https://crrev.com/6e462aab03239f5ddfcec2adc598e5d775fb70e2/media/remoting/proto_utils.h

Comment 7 by xhw...@chromium.org, Jan 10 2018

Status: Fixed (was: Available)
This is fixed by #6.

Sign in to add a comment