New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 656689 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Update sync code to use base::MakeUnique instead .reset(new

Project Member Reported by s...@chromium.org, Oct 17 2016

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Oct 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc10e451dad389a56e8fd16f8125eed397387177

commit dc10e451dad389a56e8fd16f8125eed397387177
Author: skym <skym@chromium.org>
Date: Mon Oct 17 20:08:21 2016

[Sync] Rewriting ".reset(new" pattern to use "= base::MakeUnique" instead.

BUG= 656689 

Review-Url: https://codereview.chromium.org/2422253002
Cr-Commit-Position: refs/heads/master@{#425761}

[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/chrome/browser/sync/chrome_sync_client.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/chrome/browser/sync/profile_sync_service_android.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/chrome/browser/sync/sessions/sessions_sync_manager_unittest.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/chrome/browser/sync/sync_error_notifier_ash_unittest.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/chrome/browser/sync/sync_startup_tracker_unittest.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/chrome/browser/sync/test/integration/sync_arc_package_helper.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/chrome/browser/sync/test/integration/sync_test.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/browser_sync/abstract_profile_sync_service_test.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/browser_sync/profile_sync_service.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/browser_sync/profile_sync_service_autofill_unittest.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/browser_sync/profile_sync_service_bookmark_unittest.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/browser_sync/profile_sync_service_startup_unittest.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/browser_sync/profile_sync_service_unittest.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/base/cryptographer.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/base/proto_value_ptr_unittest.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/device_info/device_info_data_type_controller_unittest.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/device_info/device_info_service_unittest.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/device_info/device_info_sync_service_unittest.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/device_info/local_device_info_provider_impl.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/device_info/local_device_info_provider_impl_unittest.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/device_info/local_device_info_provider_mock.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/driver/backend_migrator_unittest.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/driver/data_type_manager_impl_unittest.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/driver/frontend_data_type_controller_unittest.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/driver/generic_change_processor.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/driver/generic_change_processor_unittest.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/driver/glue/sync_backend_host_core.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/driver/glue/sync_backend_host_impl.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/driver/glue/sync_backend_host_impl_unittest.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/driver/glue/sync_backend_registrar.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/driver/glue/sync_backend_registrar_unittest.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/driver/model_type_controller_unittest.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/driver/shared_change_processor_unittest.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/driver/startup_controller_unittest.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/engine/attachments/fake_attachment_downloader.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/engine/attachments/on_disk_attachment_store.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/engine/fake_sync_manager.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/engine/net/http_bridge.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/engine_impl/apply_control_data_updates_unittest.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/engine_impl/attachments/attachment_downloader_impl.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/engine_impl/attachments/attachment_downloader_impl_unittest.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/engine_impl/attachments/attachment_uploader_impl_unittest.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/engine_impl/cycle/sync_cycle.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/engine_impl/directory_update_handler.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/engine_impl/directory_update_handler_unittest.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/engine_impl/model_type_registry.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/engine_impl/model_type_registry_unittest.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/engine_impl/model_type_worker_unittest.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/engine_impl/sync_encryption_handler_impl_unittest.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/engine_impl/sync_manager_impl.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/engine_impl/sync_scheduler_impl.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/engine_impl/sync_scheduler_impl_unittest.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/engine_impl/syncer_unittest.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/engine_impl/syncer_util_unittest.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/engine_impl/worker_entity_tracker.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/model/attachments/attachment_service_proxy_unittest.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/model/fake_model_type_service.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/model/sync_error.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/model_impl/attachments/attachment_service_impl.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/model_impl/attachments/attachment_service_impl_unittest.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/model_impl/attachments/task_queue.h
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/model_impl/attachments/task_queue_unittest.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/model_impl/model_type_store_backend_unittest.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/model_impl/model_type_store_impl.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/model_impl/shared_model_type_processor_unittest.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/syncable/directory_backing_store.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/syncable/directory_unittest.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/syncable/syncable_unittest.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/syncable/test_user_share.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/test/engine/test_directory_setter_upper.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/tools/sync_client.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync/tools/sync_listen_notifications.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync_bookmarks/bookmark_data_type_controller_unittest.cc
[modify] https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177/components/sync_sessions/session_data_type_controller_unittest.cc

Comment 2 by s...@chromium.org, Oct 18 2016

Status: Fixed (was: Started)

Sign in to add a comment