New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 656646 link

Starred by 2 users
Status: Fixed
Owner:
treib@chromium.org
Closed: Oct 2016
Cc:
█ sfiera@chromium.org
ntp-dev+bugs@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 514752



Sign in to add a comment

Cleanup desktop NTP UMA

Project Member Reported by treib@chromium.org, Oct 17 2016 
Some things that should be cleaned up:

- The multi-iframe NTP still sends a bunch of logging events. Half of them are ignored by NTPUserDataLogger. IMO we should just remove all logging code for the multi-iframe NTP.

- NTPLoggingEventType.NTP_TILE should be removed in favor of NTP_(CLIENT|SERVER)_SIDE_SUGGESTION.

- In fact, probably both of these events can be removed in favor of LogMostVisitedImpression, which also logs the tile source (client/server).
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 24 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/839adb262e0fc64ea007c26bcdb6e115c1b28c8a

commit 839adb262e0fc64ea007c26bcdb6e115c1b28c8a
Author: treib <treib@chromium.org>
Date: Mon Oct 24 13:30:33 2016

Cleanup desktop NTP metrics recording

- Remove all logging code from the multi-iframe NTP
- Remove NTPLoggingEventType.NTP_TILE, use NTP_*_SIDE_SUGGESTIONS instead
- Other small cleanups

BUG= 656646 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2429523002
Cr-Commit-Position: refs/heads/master@{#427056}

[modify] https://crrev.com/839adb262e0fc64ea007c26bcdb6e115c1b28c8a/chrome/browser/resources/local_ntp/most_visited_single.js
[modify] https://crrev.com/839adb262e0fc64ea007c26bcdb6e115c1b28c8a/chrome/browser/resources/local_ntp/most_visited_thumbnail.js
[modify] https://crrev.com/839adb262e0fc64ea007c26bcdb6e115c1b28c8a/chrome/browser/resources/local_ntp/most_visited_title.js
[modify] https://crrev.com/839adb262e0fc64ea007c26bcdb6e115c1b28c8a/chrome/browser/resources/local_ntp/most_visited_util.js
[modify] https://crrev.com/839adb262e0fc64ea007c26bcdb6e115c1b28c8a/chrome/browser/ui/search/search_ipc_router_unittest.cc
[modify] https://crrev.com/839adb262e0fc64ea007c26bcdb6e115c1b28c8a/chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc
[modify] https://crrev.com/839adb262e0fc64ea007c26bcdb6e115c1b28c8a/chrome/browser/ui/webui/ntp/ntp_user_data_logger.h
[modify] https://crrev.com/839adb262e0fc64ea007c26bcdb6e115c1b28c8a/chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc
[modify] https://crrev.com/839adb262e0fc64ea007c26bcdb6e115c1b28c8a/chrome/common/search/ntp_logging_events.h
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 24 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/839adb262e0fc64ea007c26bcdb6e115c1b28c8a

commit 839adb262e0fc64ea007c26bcdb6e115c1b28c8a
Author: treib <treib@chromium.org>
Date: Mon Oct 24 13:30:33 2016

Cleanup desktop NTP metrics recording

- Remove all logging code from the multi-iframe NTP
- Remove NTPLoggingEventType.NTP_TILE, use NTP_*_SIDE_SUGGESTIONS instead
- Other small cleanups

BUG= 656646 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2429523002
Cr-Commit-Position: refs/heads/master@{#427056}

[modify] https://crrev.com/839adb262e0fc64ea007c26bcdb6e115c1b28c8a/chrome/browser/resources/local_ntp/most_visited_single.js
[modify] https://crrev.com/839adb262e0fc64ea007c26bcdb6e115c1b28c8a/chrome/browser/resources/local_ntp/most_visited_thumbnail.js
[modify] https://crrev.com/839adb262e0fc64ea007c26bcdb6e115c1b28c8a/chrome/browser/resources/local_ntp/most_visited_title.js
[modify] https://crrev.com/839adb262e0fc64ea007c26bcdb6e115c1b28c8a/chrome/browser/resources/local_ntp/most_visited_util.js
[modify] https://crrev.com/839adb262e0fc64ea007c26bcdb6e115c1b28c8a/chrome/browser/ui/search/search_ipc_router_unittest.cc
[modify] https://crrev.com/839adb262e0fc64ea007c26bcdb6e115c1b28c8a/chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc
[modify] https://crrev.com/839adb262e0fc64ea007c26bcdb6e115c1b28c8a/chrome/browser/ui/webui/ntp/ntp_user_data_logger.h
[modify] https://crrev.com/839adb262e0fc64ea007c26bcdb6e115c1b28c8a/chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc
[modify] https://crrev.com/839adb262e0fc64ea007c26bcdb6e115c1b28c8a/chrome/common/search/ntp_logging_events.h

Comment 4 by treib@chromium.org, Oct 25 2016

Status: Fixed (was: Started)
►

Sign in to add a comment