New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 656634 link

Starred by 1 user
Status: Fixed
Owner:
█ dgn@chromium.org
Not on Chrome anymore
Closed: Oct 2016
Cc:
ntp-dev+bugs@chromium.org
█ rachelis@chromium.org
█ nepper@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Update the Empty state card strings

Project Member Reported by dgn@chromium.org, Oct 17 2016 
Approved mocks: https://docs.google.com/presentation/d/1IT0NPdbZqV_uumideOjv9IuEjyqpDHfEWYZkXjSlTdA/edit#slide=id.g127ed73201_1_149

Before:
Done for now
More articles will appear when the time is right.

After:
That's all for now
Your suggested articles appear here.

Comment 1 by treib@chromium.org, Oct 17 2016

Cc: ntp-dev+bugs@chromium.org
Labels: -M55 M-56
I think it's too late for string changes in M55, this will have to wait until M56.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9116cbaf9ff03d697add0a6b2206f306ac55301b

commit 9116cbaf9ff03d697add0a6b2206f306ac55301b
Author: dgn <dgn@chromium.org>
Date: Tue Oct 18 17:22:32 2016

[NTP Client] Update the strings for the empty state cards

Does not add or change any resource id.

BUG= 656634 

Review-Url: https://codereview.chromium.org/2424033002
Cr-Commit-Position: refs/heads/master@{#426000}

[modify] https://crrev.com/9116cbaf9ff03d697add0a6b2206f306ac55301b/components/ntp_snippets_strings.grdp

Comment 3 by dgn@chromium.org, Oct 20 2016

Status: Fixed (was: Started)
►

Sign in to add a comment