histograms.xml presubmit should require either unit or enum |
|||||
Issue descriptionIt's very common to get histogram reviews that have neither a unit nor enum. In these cases, usually it is numeric and they left off the unit. We should require this - should be easier to check for either unit or enum.
,
Oct 18 2016
I kind of feel so. I don't mind something like "engagement score" in that case.
,
Oct 18 2016
I don't really feel that strongly in this case. However I dislike it when there's no unit at all when there clearly should be one ... so I think requiring unit or enum seems better overall.
,
Oct 18 2017
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 18 2017
Still relevant.
,
Oct 18
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 18
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by isherman@chromium.org
, Oct 17 2016