New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 656625 link

Starred by 3 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

histograms.xml presubmit should require either unit or enum

Project Member Reported by rkaplow@chromium.org, Oct 17 2016

Issue description

It's very common to get histogram reviews that have neither a unit nor enum. In these cases, usually it is numeric and they left off the unit. We should require this - should be easier to check for either unit or enum.

 
I've seen a few histograms that intentionally omitted the units, like site engagement histograms where the units are kind of an abstract engagement score.  Do we want to require histograms like this to also specify a unit?
I kind of feel so. I don't mind something like "engagement score" in that case.
I don't really feel that strongly in this case. However I dislike it when there's no unit at all when there clearly should be one ... so I think requiring unit or enum seems better overall.

Project Member

Comment 4 by sheriffbot@chromium.org, Oct 18 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Components: -Internals>Metrics Internals>Metrics>UMA
Labels: -Hotlist-Recharge-Cold
Status: Available (was: Untriaged)
Still relevant.
Project Member

Comment 6 by sheriffbot@chromium.org, Oct 18

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Recharge-Cold Hotlist-GoodFirstBug

Sign in to add a comment