New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 656622 link

Starred by 1 user
Status: Verified
Owner:
clemensh@chromium.org
Closed: Oct 2016
Cc:
machenb...@chromium.org
█ kozyatinskiy@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Launch-OWP
Launch-Accessibility: ----
Launch-Exp-Leadership: ----
Launch-Leadership: ----
Launch-Legal: ----
Launch-M-Approved: ----
Launch-M-Target: ----
Launch-Privacy: ----
Launch-Security: ----
Launch-Test: ----
Launch-UI: ----
Rollout-Type: ----



Sign in to add a comment

Layout Test inspector/sources/debugger-pause/debugger-eval-while-paused-throws.html needs rebaseline

Project Member Reported by clemensh@chromium.org, Oct 17 2016 
A change to debugger-script.js causes line numbers to change.
This bug tracks the Rebaselining process.

CL: https://codereview.chromium.org/2415073003/
was reverted in: https://codereview.chromium.org/2427633002/

Because of this change in the output of the layout test:
-     at eval (eval at evaluate (:117:21), <anonymous>:1:1)
+     at eval (eval at evaluate (:119:21), <anonymous>:1:1)
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c99c0494b615e2bf342ea9f9d37cc5085b6b2652

commit c99c0494b615e2bf342ea9f9d37cc5085b6b2652
Author: clemensh <clemensh@chromium.org>
Date: Mon Oct 17 17:02:51 2016

Mark one layout test NeedsManualRebaseline

Line number will change because of a change to debugger-script.js in V8.

R=jochen@chromium.org, kozyatinskiy@chromium.org
BUG= 656622 

Review-Url: https://codereview.chromium.org/2423113002
Cr-Commit-Position: refs/heads/master@{#425703}

[modify] https://crrev.com/c99c0494b615e2bf342ea9f9d37cc5085b6b2652/third_party/WebKit/LayoutTests/TestExpectations
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/ea51b8a764a80f047979e577c9d5945f0c83f362

commit ea51b8a764a80f047979e577c9d5945f0c83f362
Author: clemensh <clemensh@chromium.org>
Date: Tue Oct 18 08:19:00 2016

[debug] [reland] Consistently use script from FrameMirror

... instead of getting it from the FunctionMirror. For WASM frames
(including asm.js -> WASM), the function is either unresolved or does
not contain the script.

The added test case failed before this CL.

R=kozyatinskiy@chromium.org, yangguo@chromium.org, titzer@chromium.org
BUG= v8:4203 ,  chromium:656622 

Committed: https://crrev.com/ce32e2ffd835062d764f3c0ee6a32543417cb615
Review-Url: https://codereview.chromium.org/2415073003
Cr-Original-Commit-Position: refs/heads/master@{#40348}
Cr-Commit-Position: refs/heads/master@{#40387}

[modify] https://crrev.com/ea51b8a764a80f047979e577c9d5945f0c83f362/src/debug/mirrors.js
[modify] https://crrev.com/ea51b8a764a80f047979e577c9d5945f0c83f362/src/inspector/debugger-script.js
[modify] https://crrev.com/ea51b8a764a80f047979e577c9d5945f0c83f362/src/inspector/debugger_script_externs.js
[add] https://crrev.com/ea51b8a764a80f047979e577c9d5945f0c83f362/test/inspector/debugger/asm-js-stack-expected.txt
[add] https://crrev.com/ea51b8a764a80f047979e577c9d5945f0c83f362/test/inspector/debugger/asm-js-stack.js
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/880f4966dd58919a2b32c6a8d4f11579bb1aa004

commit 880f4966dd58919a2b32c6a8d4f11579bb1aa004
Author: clemensh <clemensh@chromium.org>
Date: Wed Oct 19 15:11:12 2016

Mark layout test NeedsRebaseline

V8 change has landed, regenerate expected output now.

V8 CL: https://codereview.chromium.org/2415073003.
Set NeedsManualRebaseline in https://codereview.chromium.org/2423113002.

BUG= 656622 
R=jochen@chromium.org, kozyatinskiy@chromium.org

Review-Url: https://chromiumcodereview.appspot.com/2428633003
Cr-Commit-Position: refs/heads/master@{#426193}

[modify] https://crrev.com/880f4966dd58919a2b32c6a8d4f11579bb1aa004/third_party/WebKit/LayoutTests/TestExpectations

Comment 5 by clemensh@chromium.org, Oct 19 2016 

Is it OK that we get other positions now on android (still the old ones)? How does that happen?
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8798e8897cf96b2aa478d821005ecfc282d1e60c

commit 8798e8897cf96b2aa478d821005ecfc282d1e60c
Author: shimazu <shimazu@chromium.org>
Date: Fri Oct 21 07:16:50 2016

Reland of Mark layout test NeedsRebaseline

My patch ( https://crrev.com/2415873002 ) overwrote a patch
( https://crrev.com/2428633003 ) by mistake, so this patch relands it.

Original issue's description:
> V8 change has landed, regenerate expected output now.
>
> V8 CL: https://codereview.chromium.org/2415073003.
> Set NeedsManualRebaseline in https://codereview.chromium.org/2423113002.
>
> BUG= 656622 
> R=jochen@chromium.org, kozyatinskiy@chromium.org
>
> Review-Url: https://chromiumcodereview.appspot.com/2428633003
> Cr-Commit-Position: refs/heads/master@{#426193}

BUG= 656622 
NOTRY=true

Review-Url: https://chromiumcodereview.appspot.com/2443513002
Cr-Commit-Position: refs/heads/master@{#426746}

[modify] https://crrev.com/8798e8897cf96b2aa478d821005ecfc282d1e60c/third_party/WebKit/LayoutTests/TestExpectations
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/194a578e9c943b3f203fbc008d639a260b90e87c

commit 194a578e9c943b3f203fbc008d639a260b90e87c
Author: machenbach <machenbach@chromium.org>
Date: Fri Oct 21 12:27:48 2016

Request new layout test baseline for V8 change

Was rebaselined while
https://chromiumcodereview.appspot.com/2423153002 landed in
V8, which changed the line numbers again.

BUG= 656622 , 652939 , v8:5510 

TBR=clemensh@chromium.org, kozyatinskiy@chromium.org
NOTRY=true

Review-Url: https://chromiumcodereview.appspot.com/2442733002
Cr-Commit-Position: refs/heads/master@{#426774}

[modify] https://crrev.com/194a578e9c943b3f203fbc008d639a260b90e87c/third_party/WebKit/LayoutTests/TestExpectations

Comment 10 by clemensh@chromium.org, Oct 25 2016

Status: Verified (was: Started)
►

Sign in to add a comment