Tracking bug for moving voice search code into Chromium.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/976869e5ad80f517cc8d7515aec8c7916275d745 commit 976869e5ad80f517cc8d7515aec8c7916275d745 Author: rohitrao <rohitrao@chromium.org> Date: Mon Oct 17 20:06:31 2016 [ios] Adds configuration helper files for voice search. Also adds a provider API in ChromeBrowserProvider to return the list of available voice search languages. BUG= 656617 TEST=No visible impact. Voice search languages should continue to appear in Settings. Review-Url: https://codereview.chromium.org/2425713002 Cr-Commit-Position: refs/heads/master@{#425760} [add] https://crrev.com/976869e5ad80f517cc8d7515aec8c7916275d745/ios/chrome/browser/voice/BUILD.gn [add] https://crrev.com/976869e5ad80f517cc8d7515aec8c7916275d745/ios/chrome/browser/voice/OWNERS [add] https://crrev.com/976869e5ad80f517cc8d7515aec8c7916275d745/ios/chrome/browser/voice/speech_input_locale.h [add] https://crrev.com/976869e5ad80f517cc8d7515aec8c7916275d745/ios/chrome/browser/voice/speech_input_locale_config.h [add] https://crrev.com/976869e5ad80f517cc8d7515aec8c7916275d745/ios/chrome/browser/voice/speech_input_locale_config.mm [add] https://crrev.com/976869e5ad80f517cc8d7515aec8c7916275d745/ios/chrome/browser/voice/speech_input_locale_config_impl.h [add] https://crrev.com/976869e5ad80f517cc8d7515aec8c7916275d745/ios/chrome/browser/voice/speech_input_locale_config_impl.mm [add] https://crrev.com/976869e5ad80f517cc8d7515aec8c7916275d745/ios/chrome/browser/voice/speech_input_locale_match_config.h [add] https://crrev.com/976869e5ad80f517cc8d7515aec8c7916275d745/ios/chrome/browser/voice/speech_input_locale_match_config.mm [modify] https://crrev.com/976869e5ad80f517cc8d7515aec8c7916275d745/ios/public/provider/chrome/browser/BUILD.gn [modify] https://crrev.com/976869e5ad80f517cc8d7515aec8c7916275d745/ios/public/provider/chrome/browser/chrome_browser_provider.h [modify] https://crrev.com/976869e5ad80f517cc8d7515aec8c7916275d745/ios/public/provider/chrome/browser/chrome_browser_provider.mm [modify] https://crrev.com/976869e5ad80f517cc8d7515aec8c7916275d745/ios/public/provider/chrome/browser/test_chrome_browser_provider.h [modify] https://crrev.com/976869e5ad80f517cc8d7515aec8c7916275d745/ios/public/provider/chrome/browser/test_chrome_browser_provider.mm [add] https://crrev.com/976869e5ad80f517cc8d7515aec8c7916275d745/ios/public/provider/chrome/browser/voice/voice_search_language.h [add] https://crrev.com/976869e5ad80f517cc8d7515aec8c7916275d745/ios/public/provider/chrome/browser/voice/voice_search_language.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9cf76a0b0de2b5e5f2cc80a3df5a0e7a309b4cef commit 9cf76a0b0de2b5e5f2cc80a3df5a0e7a309b4cef Author: rohitrao <rohitrao@chromium.org> Date: Wed Oct 19 13:15:23 2016 [ios] Adds a provider API for AudioSessionController. Creates VoiceSearchProvider to act as a namespace for provider APIs related to voice search. Also adds TestAudioSessionController and TestVoiceSearchProvider for use in unittests. BUG= 656617 TEST=No visible (or audible) impact. Review-Url: https://chromiumcodereview.appspot.com/2432563002 Cr-Commit-Position: refs/heads/master@{#426170} [modify] https://crrev.com/9cf76a0b0de2b5e5f2cc80a3df5a0e7a309b4cef/ios/public/provider/chrome/browser/BUILD.gn [modify] https://crrev.com/9cf76a0b0de2b5e5f2cc80a3df5a0e7a309b4cef/ios/public/provider/chrome/browser/chrome_browser_provider.h [modify] https://crrev.com/9cf76a0b0de2b5e5f2cc80a3df5a0e7a309b4cef/ios/public/provider/chrome/browser/chrome_browser_provider.mm [modify] https://crrev.com/9cf76a0b0de2b5e5f2cc80a3df5a0e7a309b4cef/ios/public/provider/chrome/browser/test_chrome_browser_provider.h [modify] https://crrev.com/9cf76a0b0de2b5e5f2cc80a3df5a0e7a309b4cef/ios/public/provider/chrome/browser/test_chrome_browser_provider.mm [add] https://crrev.com/9cf76a0b0de2b5e5f2cc80a3df5a0e7a309b4cef/ios/public/provider/chrome/browser/voice/BUILD.gn [add] https://crrev.com/9cf76a0b0de2b5e5f2cc80a3df5a0e7a309b4cef/ios/public/provider/chrome/browser/voice/audio_session_controller.h [add] https://crrev.com/9cf76a0b0de2b5e5f2cc80a3df5a0e7a309b4cef/ios/public/provider/chrome/browser/voice/test_audio_session_controller.cc [add] https://crrev.com/9cf76a0b0de2b5e5f2cc80a3df5a0e7a309b4cef/ios/public/provider/chrome/browser/voice/test_audio_session_controller.h [add] https://crrev.com/9cf76a0b0de2b5e5f2cc80a3df5a0e7a309b4cef/ios/public/provider/chrome/browser/voice/test_voice_search_provider.h [add] https://crrev.com/9cf76a0b0de2b5e5f2cc80a3df5a0e7a309b4cef/ios/public/provider/chrome/browser/voice/test_voice_search_provider.mm [add] https://crrev.com/9cf76a0b0de2b5e5f2cc80a3df5a0e7a309b4cef/ios/public/provider/chrome/browser/voice/voice_search_provider.h [add] https://crrev.com/9cf76a0b0de2b5e5f2cc80a3df5a0e7a309b4cef/ios/public/provider/chrome/browser/voice/voice_search_provider.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/22b6c6a2de2c7ec45d547ffca4aebc9739fba3c4 commit 22b6c6a2de2c7ec45d547ffca4aebc9739fba3c4 Author: sdefresne <sdefresne@chromium.org> Date: Wed Oct 19 23:54:31 2016 Forward declare test class as friend of SpeechInputLocaleConfigImpl. SpeechInputLocaleConfigImplTest wants to create a local instance of SpeechInputLocaleConfigImpl (to avoid pollution by other tests) so declare it as friend class. BUG= 656617 Review-Url: https://chromiumcodereview.appspot.com/2436873003 Cr-Commit-Position: refs/heads/master@{#426341} [modify] https://crrev.com/22b6c6a2de2c7ec45d547ffca4aebc9739fba3c4/ios/chrome/browser/voice/speech_input_locale_config_impl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3152599bcce134b11eb8b6c5229bc8d4fd772e70 commit 3152599bcce134b11eb8b6c5229bc8d4fd772e70 Author: rohitrao <rohitrao@chromium.org> Date: Fri Oct 21 15:11:57 2016 [ios] Adds GoogleLogoService to help with fetching doodles. BUG= 656617 Review-Url: https://chromiumcodereview.appspot.com/2434143003 Cr-Commit-Position: refs/heads/master@{#426795} [modify] https://crrev.com/3152599bcce134b11eb8b6c5229bc8d4fd772e70/ios/chrome/browser/BUILD.gn [modify] https://crrev.com/3152599bcce134b11eb8b6c5229bc8d4fd772e70/ios/chrome/browser/DEPS [modify] https://crrev.com/3152599bcce134b11eb8b6c5229bc8d4fd772e70/ios/chrome/browser/browser_state/browser_state_keyed_service_factories.mm [add] https://crrev.com/3152599bcce134b11eb8b6c5229bc8d4fd772e70/ios/chrome/browser/google/google_logo_service.h [add] https://crrev.com/3152599bcce134b11eb8b6c5229bc8d4fd772e70/ios/chrome/browser/google/google_logo_service.mm [add] https://crrev.com/3152599bcce134b11eb8b6c5229bc8d4fd772e70/ios/chrome/browser/google/google_logo_service_factory.h [add] https://crrev.com/3152599bcce134b11eb8b6c5229bc8d4fd772e70/ios/chrome/browser/google/google_logo_service_factory.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3bfc33b5c3c4d405709f311a76c1646fcb0ba6dd commit 3bfc33b5c3c4d405709f311a76c1646fcb0ba6dd Author: rohitrao <rohitrao@chromium.org> Date: Tue Oct 25 12:58:01 2016 [ios] Adds the LogoAnimationController protocol. BUG= 656617 Review-Url: https://codereview.chromium.org/2448823002 Cr-Commit-Position: refs/heads/master@{#427329} [modify] https://crrev.com/3bfc33b5c3c4d405709f311a76c1646fcb0ba6dd/ios/public/provider/chrome/browser/BUILD.gn [add] https://crrev.com/3bfc33b5c3c4d405709f311a76c1646fcb0ba6dd/ios/public/provider/chrome/browser/voice/logo_animation_controller.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5fb238c24cae7ec3e97a09226a26d292f73851dc commit 5fb238c24cae7ec3e97a09226a26d292f73851dc Author: rohitrao <rohitrao@chromium.org> Date: Tue Oct 25 18:41:56 2016 [ios] Adds support for parsing Text-to-Speech search results. BUG= 656617 Review-Url: https://codereview.chromium.org/2449593002 Cr-Commit-Position: refs/heads/master@{#427423} [modify] https://crrev.com/5fb238c24cae7ec3e97a09226a26d292f73851dc/ios/chrome/BUILD.gn [add] https://crrev.com/5fb238c24cae7ec3e97a09226a26d292f73851dc/ios/chrome/browser/ui/voice/BUILD.gn [add] https://crrev.com/5fb238c24cae7ec3e97a09226a26d292f73851dc/ios/chrome/browser/ui/voice/text_to_speech_player+subclassing.h [add] https://crrev.com/5fb238c24cae7ec3e97a09226a26d292f73851dc/ios/chrome/browser/ui/voice/text_to_speech_player.h [add] https://crrev.com/5fb238c24cae7ec3e97a09226a26d292f73851dc/ios/chrome/browser/ui/voice/text_to_speech_player.mm [add] https://crrev.com/5fb238c24cae7ec3e97a09226a26d292f73851dc/ios/chrome/browser/ui/voice/text_to_speech_player_unittest.mm [add] https://crrev.com/5fb238c24cae7ec3e97a09226a26d292f73851dc/ios/chrome/browser/ui/voice/voice_search_notification_names.h [add] https://crrev.com/5fb238c24cae7ec3e97a09226a26d292f73851dc/ios/chrome/browser/ui/voice/voice_search_notification_names.mm [modify] https://crrev.com/5fb238c24cae7ec3e97a09226a26d292f73851dc/ios/chrome/browser/voice/BUILD.gn [add] https://crrev.com/5fb238c24cae7ec3e97a09226a26d292f73851dc/ios/chrome/browser/voice/text_to_speech_listener.h [add] https://crrev.com/5fb238c24cae7ec3e97a09226a26d292f73851dc/ios/chrome/browser/voice/text_to_speech_listener.mm [add] https://crrev.com/5fb238c24cae7ec3e97a09226a26d292f73851dc/ios/chrome/browser/voice/text_to_speech_listener_unittest.mm [add] https://crrev.com/5fb238c24cae7ec3e97a09226a26d292f73851dc/ios/chrome/browser/voice/text_to_speech_parser.h [add] https://crrev.com/5fb238c24cae7ec3e97a09226a26d292f73851dc/ios/chrome/browser/voice/text_to_speech_parser.mm [add] https://crrev.com/5fb238c24cae7ec3e97a09226a26d292f73851dc/ios/chrome/browser/voice/text_to_speech_parser_unittest.mm [add] https://crrev.com/5fb238c24cae7ec3e97a09226a26d292f73851dc/ios/chrome/browser/voice/voice_search_url_rewriter.h [add] https://crrev.com/5fb238c24cae7ec3e97a09226a26d292f73851dc/ios/chrome/browser/voice/voice_search_url_rewriter.mm [add] https://crrev.com/5fb238c24cae7ec3e97a09226a26d292f73851dc/ios/chrome/test/data/voice/test_sound.m4a
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a144a499aedea3fe48969f7bb0c16ae5538ccd09 commit a144a499aedea3fe48969f7bb0c16ae5538ccd09 Author: rohitrao <rohitrao@chromium.org> Date: Wed Oct 26 22:07:38 2016 [ios] Adds a VoiceSearchController interface to the provider layer. Also moves the voice search pref constants into the provider layer. BUG= 656617 Review-Url: https://codereview.chromium.org/2453003002 Cr-Commit-Position: refs/heads/master@{#427841} [modify] https://crrev.com/a144a499aedea3fe48969f7bb0c16ae5538ccd09/ios/chrome/browser/BUILD.gn [modify] https://crrev.com/a144a499aedea3fe48969f7bb0c16ae5538ccd09/ios/chrome/browser/pref_names.cc [modify] https://crrev.com/a144a499aedea3fe48969f7bb0c16ae5538ccd09/ios/chrome/browser/pref_names.h [modify] https://crrev.com/a144a499aedea3fe48969f7bb0c16ae5538ccd09/ios/chrome/browser/prefs/BUILD.gn [modify] https://crrev.com/a144a499aedea3fe48969f7bb0c16ae5538ccd09/ios/chrome/browser/prefs/browser_prefs.mm [modify] https://crrev.com/a144a499aedea3fe48969f7bb0c16ae5538ccd09/ios/chrome/browser/voice/BUILD.gn [add] https://crrev.com/a144a499aedea3fe48969f7bb0c16ae5538ccd09/ios/chrome/browser/voice/voice_search_prefs_registration.cc [add] https://crrev.com/a144a499aedea3fe48969f7bb0c16ae5538ccd09/ios/chrome/browser/voice/voice_search_prefs_registration.h [modify] https://crrev.com/a144a499aedea3fe48969f7bb0c16ae5538ccd09/ios/chrome/browser/voice/voice_search_url_rewriter.mm [modify] https://crrev.com/a144a499aedea3fe48969f7bb0c16ae5538ccd09/ios/public/provider/chrome/browser/BUILD.gn [modify] https://crrev.com/a144a499aedea3fe48969f7bb0c16ae5538ccd09/ios/public/provider/chrome/browser/chrome_browser_provider.mm [add] https://crrev.com/a144a499aedea3fe48969f7bb0c16ae5538ccd09/ios/public/provider/chrome/browser/voice/voice_search_controller.h [add] https://crrev.com/a144a499aedea3fe48969f7bb0c16ae5538ccd09/ios/public/provider/chrome/browser/voice/voice_search_controller.mm [add] https://crrev.com/a144a499aedea3fe48969f7bb0c16ae5538ccd09/ios/public/provider/chrome/browser/voice/voice_search_controller_delegate.h [add] https://crrev.com/a144a499aedea3fe48969f7bb0c16ae5538ccd09/ios/public/provider/chrome/browser/voice/voice_search_prefs.cc [add] https://crrev.com/a144a499aedea3fe48969f7bb0c16ae5538ccd09/ios/public/provider/chrome/browser/voice/voice_search_prefs.h [modify] https://crrev.com/a144a499aedea3fe48969f7bb0c16ae5538ccd09/ios/public/provider/chrome/browser/voice/voice_search_provider.h [modify] https://crrev.com/a144a499aedea3fe48969f7bb0c16ae5538ccd09/ios/public/provider/chrome/browser/voice/voice_search_provider.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5ab2f2496b2a2d8ec69c7f1603cbba0c5c4766b7 commit 5ab2f2496b2a2d8ec69c7f1603cbba0c5c4766b7 Author: rohitrao <rohitrao@chromium.org> Date: Thu Oct 27 13:38:38 2016 [ios] Adds protocols for voice search. BUG= 656617 Review-Url: https://codereview.chromium.org/2459533002 Cr-Commit-Position: refs/heads/master@{#428012} [modify] https://crrev.com/5ab2f2496b2a2d8ec69c7f1603cbba0c5c4766b7/ios/public/provider/chrome/browser/BUILD.gn [add] https://crrev.com/5ab2f2496b2a2d8ec69c7f1603cbba0c5c4766b7/ios/public/provider/chrome/browser/voice/voice_search_bar.h [add] https://crrev.com/5ab2f2496b2a2d8ec69c7f1603cbba0c5c4766b7/ios/public/provider/chrome/browser/voice/voice_search_bar_owner.h [add] https://crrev.com/5ab2f2496b2a2d8ec69c7f1603cbba0c5c4766b7/ios/public/provider/chrome/browser/voice/voice_search_presenter.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e716b15586e831dd2939fd301127e7398f71ad03 commit e716b15586e831dd2939fd301127e7398f71ad03 Author: rohitrao <rohitrao@chromium.org> Date: Thu Oct 27 18:03:23 2016 [ios] Adds VoiceSearchBar creation methods to VoiceSearchProvider. BUG= 656617 Review-Url: https://codereview.chromium.org/2455503007 Cr-Commit-Position: refs/heads/master@{#428076} [modify] https://crrev.com/e716b15586e831dd2939fd301127e7398f71ad03/ios/public/provider/chrome/browser/voice/voice_search_provider.h [modify] https://crrev.com/e716b15586e831dd2939fd301127e7398f71ad03/ios/public/provider/chrome/browser/voice/voice_search_provider.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f0ace0aa09d3c41551bac36f5846b29bc6b0db7 commit 8f0ace0aa09d3c41551bac36f5846b29bc6b0db7 Author: rohitrao <rohitrao@chromium.org> Date: Fri Oct 28 11:41:23 2016 [ios] Adds the LogoVendor protocol. BUG= 656617 Review-Url: https://codereview.chromium.org/2456013003 Cr-Commit-Position: refs/heads/master@{#428336} [modify] https://crrev.com/8f0ace0aa09d3c41551bac36f5846b29bc6b0db7/ios/public/provider/chrome/browser/BUILD.gn [modify] https://crrev.com/8f0ace0aa09d3c41551bac36f5846b29bc6b0db7/ios/public/provider/chrome/browser/chrome_browser_provider.h [modify] https://crrev.com/8f0ace0aa09d3c41551bac36f5846b29bc6b0db7/ios/public/provider/chrome/browser/chrome_browser_provider.mm [add] https://crrev.com/8f0ace0aa09d3c41551bac36f5846b29bc6b0db7/ios/public/provider/chrome/browser/ui/logo_vendor.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d2b3e48271c11701aae1fdb32188b3390664fa35 commit d2b3e48271c11701aae1fdb32188b3390664fa35 Author: rohitrao <rohitrao@chromium.org> Date: Fri Oct 28 16:54:16 2016 [ios] Adds VoiceSearchProvider::IsVoiceSearchEnabled(). The other provider methods must not be called if voice search is disabled. BUG= 656617 Review-Url: https://codereview.chromium.org/2457093002 Cr-Commit-Position: refs/heads/master@{#428393} [modify] https://crrev.com/d2b3e48271c11701aae1fdb32188b3390664fa35/ios/public/provider/chrome/browser/voice/voice_search_provider.h [modify] https://crrev.com/d2b3e48271c11701aae1fdb32188b3390664fa35/ios/public/provider/chrome/browser/voice/voice_search_provider.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f97c352e354918c16ccd96c0095b289b98a5293c commit f97c352e354918c16ccd96c0095b289b98a5293c Author: rohitrao <rohitrao@chromium.org> Date: Thu Nov 03 15:18:56 2016 [ios] Adds ChromiumBrowserProvider. This class provides fallback functionality for certain browser features such as voice search. BUG= 656617 TEST=None Review-Url: https://codereview.chromium.org/2463463002 Cr-Commit-Position: refs/heads/master@{#429592} [add] https://crrev.com/f97c352e354918c16ccd96c0095b289b98a5293c/ios/chrome/browser/providers/BUILD.gn [add] https://crrev.com/f97c352e354918c16ccd96c0095b289b98a5293c/ios/chrome/browser/providers/chromium_browser_provider.h [add] https://crrev.com/f97c352e354918c16ccd96c0095b289b98a5293c/ios/chrome/browser/providers/chromium_browser_provider.mm [add] https://crrev.com/f97c352e354918c16ccd96c0095b289b98a5293c/ios/chrome/browser/providers/chromium_logo_controller.h [add] https://crrev.com/f97c352e354918c16ccd96c0095b289b98a5293c/ios/chrome/browser/providers/chromium_logo_controller.mm [add] https://crrev.com/f97c352e354918c16ccd96c0095b289b98a5293c/ios/chrome/browser/providers/chromium_voice_search_provider.h [add] https://crrev.com/f97c352e354918c16ccd96c0095b289b98a5293c/ios/chrome/browser/providers/chromium_voice_search_provider.mm [modify] https://crrev.com/f97c352e354918c16ccd96c0095b289b98a5293c/ios/public/provider/chrome/browser/ui/logo_vendor.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3bd77d8cd3d2c36cacabb0a2df8c3f3ab6bd8d2e commit 3bd77d8cd3d2c36cacabb0a2df8c3f3ab6bd8d2e Author: rohitrao <rohitrao@chromium.org> Date: Mon Nov 07 19:21:14 2016 [ios] Removes calls to the deprecated GetAvailableVoiceSearchLanguages(). BUG= 656617 Review-Url: https://codereview.chromium.org/2477423002 Cr-Commit-Position: refs/heads/master@{#430339} [modify] https://crrev.com/3bd77d8cd3d2c36cacabb0a2df8c3f3ab6bd8d2e/ios/chrome/browser/voice/speech_input_locale_config_impl.mm
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/fc5d1ca5b75dcc5106e4d903f0e30198c882d110 commit fc5d1ca5b75dcc5106e4d903f0e30198c882d110 Author: Rohit Rao <rohitrao@google.com> Date: Wed Nov 09 14:55:22 2016
Comment 1 by bugdroid1@chromium.org
, Oct 17 2016