New issue
Advanced search Search tips

Issue 656607 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 750407



Sign in to add a comment

Implement annotations for network requests

Project Member Reported by rhalavati@chromium.org, Oct 17 2016

Issue description

The objective of this is to implement annotations of network requests that can be extracted at compile time.
 
Showing comments 212 - 311 of 311 Older
Project Member

Comment 212 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e4a16b8422b24ceddea707d29bba9886fa8a46f

commit 7e4a16b8422b24ceddea707d29bba9886fa8a46f
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Thu Oct 26 05:16:57 2017

Network traffic annotation proto updated.

Network traffic annotation proto updated:
1- Optional 'empty_policy_justification' tag moved from TrafficSemantics
   to TrafficPolicy as it didn't have any use case in the former and it
   can be used in the latter for the new socket cases in net.
2- The desciption of 'setting' tag updated and it won't suggest using
   'NA' when there is no settings, because in many annotations we have
   a decription of why there is no settings or alternative approaches to
   stop the request.

Bug: 656607
Change-Id: Ice9631d8127bb3235a2a75166386e9ddf05f1a83
Reviewed-on: https://chromium-review.googlesource.com/732979
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511745}
[modify] https://crrev.com/7e4a16b8422b24ceddea707d29bba9886fa8a46f/tools/traffic_annotation/auditor/instance.cc
[modify] https://crrev.com/7e4a16b8422b24ceddea707d29bba9886fa8a46f/tools/traffic_annotation/auditor/traffic_annotation_auditor_ui.cc
[modify] https://crrev.com/7e4a16b8422b24ceddea707d29bba9886fa8a46f/tools/traffic_annotation/traffic_annotation.proto

Project Member

Comment 213 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e290f176907c293600367f527f936edb186cf4a6

commit e290f176907c293600367f527f936edb186cf4a6
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Thu Oct 26 09:39:59 2017

Annotation.xml update mechanism and errors updated.

Traffic annotation auditor was updated as follows:
1- If a new annotation is found, it is added to annotations.xml for all
   supported platforms, to minimize the need to run the auditor on all
   platforms to updated os_list.
2- If annotation.xml requires updates and it is run in test mode, the
   list of updates are added to output errors.

Bug: 656607
Bug: 690323
Change-Id: Icbdceddfc9a3e31cf9be397e19b002597119bb61
Reviewed-on: https://chromium-review.googlesource.com/730687
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511773}
[modify] https://crrev.com/e290f176907c293600367f527f936edb186cf4a6/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/e290f176907c293600367f527f936edb186cf4a6/tools/traffic_annotation/auditor/BUILD.gn
[modify] https://crrev.com/e290f176907c293600367f527f936edb186cf4a6/tools/traffic_annotation/auditor/README.md
[modify] https://crrev.com/e290f176907c293600367f527f936edb186cf4a6/tools/traffic_annotation/auditor/auditor_result.cc
[modify] https://crrev.com/e290f176907c293600367f527f936edb186cf4a6/tools/traffic_annotation/auditor/auditor_result.h
[add] https://crrev.com/e290f176907c293600367f527f936edb186cf4a6/tools/traffic_annotation/auditor/tests/annotations_diff12.txt
[add] https://crrev.com/e290f176907c293600367f527f936edb186cf4a6/tools/traffic_annotation/auditor/tests/annotations_diff13.txt
[add] https://crrev.com/e290f176907c293600367f527f936edb186cf4a6/tools/traffic_annotation/auditor/tests/annotations_diff23.txt
[add] https://crrev.com/e290f176907c293600367f527f936edb186cf4a6/tools/traffic_annotation/auditor/tests/annotations_sample1.xml
[add] https://crrev.com/e290f176907c293600367f527f936edb186cf4a6/tools/traffic_annotation/auditor/tests/annotations_sample2.xml
[add] https://crrev.com/e290f176907c293600367f527f936edb186cf4a6/tools/traffic_annotation/auditor/tests/annotations_sample3.xml
[modify] https://crrev.com/e290f176907c293600367f527f936edb186cf4a6/tools/traffic_annotation/auditor/traffic_annotation_auditor.h
[modify] https://crrev.com/e290f176907c293600367f527f936edb186cf4a6/tools/traffic_annotation/auditor/traffic_annotation_auditor_ui.cc
[modify] https://crrev.com/e290f176907c293600367f527f936edb186cf4a6/tools/traffic_annotation/auditor/traffic_annotation_auditor_unittest.cc
[modify] https://crrev.com/e290f176907c293600367f527f936edb186cf4a6/tools/traffic_annotation/auditor/traffic_annotation_exporter.cc
[modify] https://crrev.com/e290f176907c293600367f527f936edb186cf4a6/tools/traffic_annotation/auditor/traffic_annotation_exporter.h
[modify] https://crrev.com/e290f176907c293600367f527f936edb186cf4a6/tools/traffic_annotation/summary/annotations.xml

Project Member

Comment 214 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f66cdd604fcd9274770160a6671f47840dea5c2c

commit f66cdd604fcd9274770160a6671f47840dea5c2c
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Thu Oct 26 12:29:02 2017

Network Traffic Annotation Auditor's TSV output updated.

The TSV output of Network Traffic Annotation Auditor creates links to
CodeSearch for file paths, instead of just file paths.

Bug: 656607
Bug: 690323
Change-Id: I53c659f713eea5a21d83d223fd96892657c15310
Reviewed-on: https://chromium-review.googlesource.com/739142
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511793}
[modify] https://crrev.com/f66cdd604fcd9274770160a6671f47840dea5c2c/tools/traffic_annotation/auditor/traffic_annotation_auditor_ui.cc

Project Member

Comment 215 by bugdroid1@chromium.org, Nov 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e7ffe4f5229b33c77767761bc7e599d8e78e955

commit 2e7ffe4f5229b33c77767761bc7e599d8e78e955
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Mon Nov 13 11:19:35 2017

Users guide added for Network Traffic Annotations.

A users guide is added to docs/ for network traffic annotations.
Annotations proto file's comments are updated.

Bug: 656607
Change-Id: I524d0017a9b74c618b6f7088583706eab2bf0fcc
Reviewed-on: https://chromium-review.googlesource.com/753085
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515924}
[add] https://crrev.com/2e7ffe4f5229b33c77767761bc7e599d8e78e955/docs/network_traffic_annotations.md
[modify] https://crrev.com/2e7ffe4f5229b33c77767761bc7e599d8e78e955/tools/traffic_annotation/traffic_annotation.proto

Project Member

Comment 216 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b5a50da2da400702b436f65150023a113622a78

commit 2b5a50da2da400702b436f65150023a113622a78
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Tue Nov 14 11:31:13 2017

Activating Network Traffic Annotation Tests.

A test is added to the trybots to check network traffic annotation's
syntax, coverage, and other probable errors.

Bug: 656607
Bug: 690323
Change-Id: Idf7a987fd5e75713a03421e8c7cb0b9c5caeaf55
Reviewed-on: https://chromium-review.googlesource.com/704735
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516268}
[modify] https://crrev.com/2b5a50da2da400702b436f65150023a113622a78/testing/scripts/check_network_annotations.py
[modify] https://crrev.com/2b5a50da2da400702b436f65150023a113622a78/tools/traffic_annotation/auditor/traffic_annotation_auditor_ui.cc
[modify] https://crrev.com/2b5a50da2da400702b436f65150023a113622a78/tools/traffic_annotation/auditor/traffic_annotation_exporter.cc
[modify] https://crrev.com/2b5a50da2da400702b436f65150023a113622a78/tools/traffic_annotation/scripts/check_annotations.py
[modify] https://crrev.com/2b5a50da2da400702b436f65150023a113622a78/tools/traffic_annotation/summary/annotations.xml

Project Member

Comment 217 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7e55d99e5d4567684e7caa83a81500938eda17e

commit b7e55d99e5d4567684e7caa83a81500938eda17e
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Tue Nov 21 08:00:57 2017

Adding a traffic annotation presubmit checker for Windows.

To provide transparency on Chromium's requests to the network, we add
network traffic annotations to all functions that call out to the
network.
This CL adds the tooling required on Windows to ensure that all of the
functions are correctly annotated and the annotations are syntactically
correct and semantically complete.

Bug: 690323
Bug: 656607
Change-Id: I56ca754cf320db62cacf954c8e0bc64db2ce301a
Reviewed-on: https://chromium-review.googlesource.com/779139
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518173}
[modify] https://crrev.com/b7e55d99e5d4567684e7caa83a81500938eda17e/DEPS
[modify] https://crrev.com/b7e55d99e5d4567684e7caa83a81500938eda17e/testing/buildbot/chromium.win.json
[modify] https://crrev.com/b7e55d99e5d4567684e7caa83a81500938eda17e/tools/traffic_annotation/.gitignore
[modify] https://crrev.com/b7e55d99e5d4567684e7caa83a81500938eda17e/tools/traffic_annotation/README.md
[add] https://crrev.com/b7e55d99e5d4567684e7caa83a81500938eda17e/tools/traffic_annotation/bin/win32/traffic_annotation_auditor.exe.sha1
[add] https://crrev.com/b7e55d99e5d4567684e7caa83a81500938eda17e/tools/traffic_annotation/bin/win32/traffic_annotation_extractor.exe.sha1
[modify] https://crrev.com/b7e55d99e5d4567684e7caa83a81500938eda17e/tools/traffic_annotation/scripts/check_annotations.py

Project Member

Comment 218 by bugdroid1@chromium.org, Nov 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e247e4076e4539bd15874f59ec264c500b1ebca2

commit e247e4076e4539bd15874f59ec264c500b1ebca2
Author: rhalavati@google.com <rhalavati@google.com>
Date: Fri Nov 24 13:05:17 2017

Adding a switch to traffic annotation auditor to use compile_commands.

Traffic annotation auditor uses git to extract the list of files that
need auditing. This will fail if build switches are used that modify
files (like jumbo). This CL adds a switch that forces auditor to use
compile_commands.json instead of git to extract files list.
The CL also disables the test on annotations.xml if auditor is not run
on the complete repository and path filters are provided.

Bug: 656607
Bug: 690323
Change-Id: I7b206798623bdfbf3611a982e7d97e8369b901d8
Reviewed-on: https://chromium-review.googlesource.com/789031
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519095}
[modify] https://crrev.com/e247e4076e4539bd15874f59ec264c500b1ebca2/tools/traffic_annotation/auditor/auditor_result.cc
[modify] https://crrev.com/e247e4076e4539bd15874f59ec264c500b1ebca2/tools/traffic_annotation/auditor/traffic_annotation_auditor.cc
[modify] https://crrev.com/e247e4076e4539bd15874f59ec264c500b1ebca2/tools/traffic_annotation/auditor/traffic_annotation_auditor.h
[modify] https://crrev.com/e247e4076e4539bd15874f59ec264c500b1ebca2/tools/traffic_annotation/auditor/traffic_annotation_auditor_ui.cc

Project Member

Comment 219 by bugdroid1@chromium.org, Nov 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c56d17048ae4886edba18e26d6d02128ae1e8a3b

commit c56d17048ae4886edba18e26d6d02128ae1e8a3b
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Thu Nov 30 09:23:01 2017

Mutable Partial Network Traffic Annotation Tag Mojo interface added.

Mojo interface added for MutablePartialNetworkTrafficAnnotationTag.
This interface is now required for
public_ip_address_geolocation_provider and will also be required for
all Mojo interfaces that pass a partial network traffic annotation tag.

Bug: 656607
Change-Id: I61dd345a0a60166413c2126c89098e9e1f031f43
Reviewed-on: https://chromium-review.googlesource.com/787250
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Renjie Liu <renjieliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520484}
[modify] https://crrev.com/c56d17048ae4886edba18e26d6d02128ae1e8a3b/docs/network_traffic_annotations.md
[modify] https://crrev.com/c56d17048ae4886edba18e26d6d02128ae1e8a3b/net/traffic_annotation/network_traffic_annotation.h
[modify] https://crrev.com/c56d17048ae4886edba18e26d6d02128ae1e8a3b/services/network/public/cpp/BUILD.gn
[modify] https://crrev.com/c56d17048ae4886edba18e26d6d02128ae1e8a3b/services/network/public/cpp/mutable_network_traffic_annotation_tag.typemap
[add] https://crrev.com/c56d17048ae4886edba18e26d6d02128ae1e8a3b/services/network/public/cpp/mutable_network_traffic_annotation_tag_struct_traits_unittest.cc
[add] https://crrev.com/c56d17048ae4886edba18e26d6d02128ae1e8a3b/services/network/public/cpp/mutable_partial_network_traffic_annotation_tag.typemap
[add] https://crrev.com/c56d17048ae4886edba18e26d6d02128ae1e8a3b/services/network/public/cpp/mutable_partial_network_traffic_annotation_tag_struct_traits.h
[add] https://crrev.com/c56d17048ae4886edba18e26d6d02128ae1e8a3b/services/network/public/cpp/mutable_partial_network_traffic_annotation_tag_struct_traits_unittest.cc
[modify] https://crrev.com/c56d17048ae4886edba18e26d6d02128ae1e8a3b/services/network/public/cpp/typemaps.gni
[modify] https://crrev.com/c56d17048ae4886edba18e26d6d02128ae1e8a3b/services/network/public/interfaces/BUILD.gn
[modify] https://crrev.com/c56d17048ae4886edba18e26d6d02128ae1e8a3b/services/network/public/interfaces/mutable_network_traffic_annotation_tag.mojom
[add] https://crrev.com/c56d17048ae4886edba18e26d6d02128ae1e8a3b/services/network/public/interfaces/mutable_partial_network_traffic_annotation_tag.mojom

Is where a way currently to view traffic annotations for network data sent from browser? If not - will it be revealed in chrome://net-internals page or will it be a separate tool? 
Who supposed to be the users of this feature? Admins looking at network traffic, browser users?
Project Member

Comment 221 by bugdroid1@chromium.org, Dec 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5

commit a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5
Author: rhalavati@google.com <rhalavati@google.com>
Date: Wed Dec 06 09:06:08 2017

Traffic Annotation argument added to Socket::Write().

We are adding network traffic annotation to all data send requests in
Chrome to provide transparency and audibility.
This CL is the first step in adding this argument to sockets data send.
In this CL the argument is added to "Write" function of
"net/socket/socket.h", and all files affected by this change are
minimally updated to compile. The added argument to all functions
has a default value to minimize code change. Once all callers have been
updated to pass a traffic annotation, the default will be removed.

Bug: 656607
Change-Id: Ib3bef20ffa8d58d9b2fedc8b6970ff0cf66f844b
Reviewed-on: https://chromium-review.googlesource.com/806219
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522049}
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/chrome/browser/devtools/device/usb/android_usb_socket.cc
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/chrome/browser/devtools/device/usb/android_usb_socket.h
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/chrome/browser/extensions/api/socket/mock_tcp_client_socket.h
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/chrome/browser/extensions/api/socket/tcp_socket_unittest.cc
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/chrome/browser/extensions/api/socket/tls_socket_unittest.cc
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/chromecast/net/fake_stream_socket.cc
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/chromecast/net/fake_stream_socket.h
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/chromecast/net/mock_stream_socket.cc
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/chromecast/net/mock_stream_socket.h
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/components/cast_channel/cast_socket_unittest.cc
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/components/cast_channel/cast_transport_unittest.cc
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/content/browser/renderer_host/p2p/socket_host_test_utils.cc
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/content/browser/renderer_host/p2p/socket_host_test_utils.h
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/jingle/glue/fake_ssl_client_socket.cc
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/jingle/glue/fake_ssl_client_socket.h
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/jingle/glue/fake_ssl_client_socket_unittest.cc
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/jingle/glue/proxy_resolving_client_socket.cc
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/jingle/glue/proxy_resolving_client_socket.h
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/net/dns/address_sorter_posix_unittest.cc
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/net/http/http_proxy_client_socket.cc
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/net/http/http_proxy_client_socket.h
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/net/http/http_proxy_client_socket_wrapper.cc
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/net/http/http_proxy_client_socket_wrapper.h
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/net/quic/chromium/quic_proxy_client_socket.cc
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/net/quic/chromium/quic_proxy_client_socket.h
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/net/server/http_server_unittest.cc
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/net/socket/client_socket_pool_base_unittest.cc
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/net/socket/fuzzed_datagram_client_socket.cc
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/net/socket/fuzzed_datagram_client_socket.h
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/net/socket/fuzzed_socket.cc
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/net/socket/fuzzed_socket.h
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/net/socket/fuzzed_socket_factory.cc
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/net/socket/socket.h
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/net/socket/socket_posix.cc
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/net/socket/socket_posix.h
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/net/socket/socket_test_util.cc
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/net/socket/socket_test_util.h
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/net/socket/socks5_client_socket.cc
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/net/socket/socks5_client_socket.h
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/net/socket/socks_client_socket.cc
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/net/socket/socks_client_socket.h
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/net/socket/socks_client_socket_unittest.cc
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/net/socket/ssl_client_socket_impl.cc
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/net/socket/ssl_client_socket_impl.h
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/net/socket/ssl_client_socket_unittest.cc
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/net/socket/ssl_server_socket_impl.cc
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/net/socket/ssl_server_socket_unittest.cc
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/net/socket/tcp_client_socket.cc
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/net/socket/tcp_client_socket.h
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/net/socket/tcp_socket_posix.cc
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/net/socket/tcp_socket_posix.h
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/net/socket/tcp_socket_win.cc
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/net/socket/tcp_socket_win.h
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/net/socket/transport_client_socket_pool_test_util.cc
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/net/socket/udp_client_socket.cc
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/net/socket/udp_client_socket.h
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/net/socket/udp_socket_posix.cc
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/net/socket/udp_socket_posix.h
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/net/socket/udp_socket_win.cc
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/net/socket/udp_socket_win.h
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/net/socket/unix_domain_client_socket_posix.cc
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/net/socket/unix_domain_client_socket_posix.h
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/net/socket/websocket_endpoint_lock_manager_unittest.cc
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/net/spdy/chromium/spdy_proxy_client_socket.cc
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/net/spdy/chromium/spdy_proxy_client_socket.h
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/net/spdy/chromium/spdy_test_util_common.cc
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/net/traffic_annotation/network_traffic_annotation.h
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/remoting/base/buffered_socket_writer.cc
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/remoting/base/buffered_socket_writer.h
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/remoting/base/buffered_socket_writer_unittest.cc
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/remoting/protocol/channel_multiplexer.cc
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/remoting/protocol/fake_stream_socket.cc
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/remoting/protocol/fake_stream_socket.h
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/remoting/protocol/p2p_stream_socket.h
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/remoting/protocol/pseudotcp_adapter.cc
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/remoting/protocol/pseudotcp_adapter.h
[modify] https://crrev.com/a2b2cfcee178bb28f0b6c8ba6026a2a7121201c5/remoting/protocol/ssl_hmac_channel_authenticator.cc

220:

Hi a-v-y@,

The annotations are being added to provide more transparency to Chrome's communications and can be used by admins who want to know what's behind the comms or privacy sensitive users.
We have plans to publish them, but we are still deciding how (and the annotations are still not complete).
We also have plans to add it to chrome://net-internals.
Project Member

Comment 223 by bugdroid1@chromium.org, Dec 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f94cd970d4d308804921830ee6f88096eda5a828

commit f94cd970d4d308804921830ee6f88096eda5a828
Author: rhalavati@google.com <rhalavati@google.com>
Date: Thu Dec 07 06:09:40 2017

Refactoring remoting classes for sockets annotations.

We are adding network traffic annotations to sockets. Some remoting
classes are refactored to transfer the annotations to the underlying
sockets.

Bug: 656607
Change-Id: Id2deafff189259a808896cb9b426a91fc45c54bf
Reviewed-on: https://chromium-review.googlesource.com/810786
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522358}
[modify] https://crrev.com/f94cd970d4d308804921830ee6f88096eda5a828/remoting/base/buffered_socket_writer.cc
[modify] https://crrev.com/f94cd970d4d308804921830ee6f88096eda5a828/remoting/base/buffered_socket_writer.h
[modify] https://crrev.com/f94cd970d4d308804921830ee6f88096eda5a828/remoting/base/buffered_socket_writer_unittest.cc
[modify] https://crrev.com/f94cd970d4d308804921830ee6f88096eda5a828/remoting/protocol/channel_multiplexer.cc
[modify] https://crrev.com/f94cd970d4d308804921830ee6f88096eda5a828/remoting/protocol/channel_multiplexer.h
[modify] https://crrev.com/f94cd970d4d308804921830ee6f88096eda5a828/remoting/protocol/channel_multiplexer_unittest.cc
[modify] https://crrev.com/f94cd970d4d308804921830ee6f88096eda5a828/remoting/protocol/client_video_dispatcher_unittest.cc
[modify] https://crrev.com/f94cd970d4d308804921830ee6f88096eda5a828/remoting/protocol/connection_tester.cc
[modify] https://crrev.com/f94cd970d4d308804921830ee6f88096eda5a828/remoting/protocol/fake_authenticator.cc
[modify] https://crrev.com/f94cd970d4d308804921830ee6f88096eda5a828/remoting/protocol/fake_stream_socket.h
[modify] https://crrev.com/f94cd970d4d308804921830ee6f88096eda5a828/remoting/protocol/p2p_stream_socket.h
[modify] https://crrev.com/f94cd970d4d308804921830ee6f88096eda5a828/remoting/protocol/pseudotcp_adapter.cc
[modify] https://crrev.com/f94cd970d4d308804921830ee6f88096eda5a828/remoting/protocol/pseudotcp_adapter.h
[modify] https://crrev.com/f94cd970d4d308804921830ee6f88096eda5a828/remoting/protocol/pseudotcp_adapter_unittest.cc
[modify] https://crrev.com/f94cd970d4d308804921830ee6f88096eda5a828/remoting/protocol/ssl_hmac_channel_authenticator.cc
[modify] https://crrev.com/f94cd970d4d308804921830ee6f88096eda5a828/remoting/protocol/stream_message_pipe_adapter.cc
[modify] https://crrev.com/f94cd970d4d308804921830ee6f88096eda5a828/remoting/signaling/xmpp_signal_strategy.cc

Project Member

Comment 224 by bugdroid1@chromium.org, Dec 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/690bbea66eb241ee40cd7f622f40ab84b439c6a3

commit 690bbea66eb241ee40cd7f622f40ab84b439c6a3
Author: rhalavati@google.com <rhalavati@google.com>
Date: Fri Dec 08 09:05:46 2017

Remove default traffic annotation from TCPSocketPosix::Write().

The default network traffic annotation value is removed from the
TCPSocketPosix::Write() function, propagating the required value to
other classes and tests.

Bug: 656607
Change-Id: Ie76cf6d8e8b2c5cc70f804108900868817ef66d7
Reviewed-on: https://chromium-review.googlesource.com/814194
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522741}
[modify] https://crrev.com/690bbea66eb241ee40cd7f622f40ab84b439c6a3/content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc
[modify] https://crrev.com/690bbea66eb241ee40cd7f622f40ab84b439c6a3/device/bluetooth/DEPS
[modify] https://crrev.com/690bbea66eb241ee40cd7f622f40ab84b439c6a3/device/bluetooth/bluetooth_socket_net.cc
[modify] https://crrev.com/690bbea66eb241ee40cd7f622f40ab84b439c6a3/net/socket/socket_posix.h
[modify] https://crrev.com/690bbea66eb241ee40cd7f622f40ab84b439c6a3/net/socket/tcp_socket_posix.h
[modify] https://crrev.com/690bbea66eb241ee40cd7f622f40ab84b439c6a3/net/socket/tcp_socket_unittest.cc

Project Member

Comment 225 by bugdroid1@chromium.org, Dec 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac28b5d25ae942bea4c5d5110cf33b3e159f5827

commit ac28b5d25ae942bea4c5d5110cf33b3e159f5827
Author: rhalavati@google.com <rhalavati@google.com>
Date: Fri Dec 08 09:06:19 2017

Remove default traffic annotation value from TCPClientSocket::Write().

The default network traffic annotation value is removed from the
TCPClientSocket::Write() function, propagating the required value to
other classes and tests.

Bug: 656607
Change-Id: I960b511edfe4cb8d09e64c9804591098b2e1e381
Reviewed-on: https://chromium-review.googlesource.com/809111
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522742}
[modify] https://crrev.com/ac28b5d25ae942bea4c5d5110cf33b3e159f5827/chrome/test/chromedriver/net/websocket.cc
[modify] https://crrev.com/ac28b5d25ae942bea4c5d5110cf33b3e159f5827/extensions/browser/api/socket/tcp_socket.cc
[modify] https://crrev.com/ac28b5d25ae942bea4c5d5110cf33b3e159f5827/net/server/http_server_unittest.cc
[modify] https://crrev.com/ac28b5d25ae942bea4c5d5110cf33b3e159f5827/net/socket/tcp_client_socket.h

Project Member

Comment 226 by bugdroid1@chromium.org, Dec 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86d902fb84107d677f8a4ebc5df8f705be9dae74

commit 86d902fb84107d677f8a4ebc5df8f705be9dae74
Author: rhalavati@google.com <rhalavati@google.com>
Date: Mon Dec 11 07:18:59 2017

Traffic Annotation Auditor is refactored.

Traffic anntation auditor is refactoring to be prepared for running on
partial set of files. In this CL 4 changes are made:
1- Selection of files that need process is updated so that git would be
   called only if path_filters are not presented or they include
   directories.
2- Unittests are ignored when files are filtered to make tests faster.
3- Hash code collision and repeated errors are separated.
4- All tests related to IDs are moved from TrafficAnnotationAuditor to
   the new class TrafficAnnotationIDChecker to make further aggregation
   of existing and new annotations easier.

Bug: 656607
Change-Id: Ifdcc2cdaa9802414c62dce1fa9f54a3eab0f40d1
Reviewed-on: https://chromium-review.googlesource.com/805755
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523052}
[modify] https://crrev.com/86d902fb84107d677f8a4ebc5df8f705be9dae74/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/86d902fb84107d677f8a4ebc5df8f705be9dae74/tools/traffic_annotation/auditor/BUILD.gn
[modify] https://crrev.com/86d902fb84107d677f8a4ebc5df8f705be9dae74/tools/traffic_annotation/auditor/auditor_result.cc
[modify] https://crrev.com/86d902fb84107d677f8a4ebc5df8f705be9dae74/tools/traffic_annotation/auditor/auditor_result.h
[modify] https://crrev.com/86d902fb84107d677f8a4ebc5df8f705be9dae74/tools/traffic_annotation/auditor/instance.cc
[modify] https://crrev.com/86d902fb84107d677f8a4ebc5df8f705be9dae74/tools/traffic_annotation/auditor/instance.h
[modify] https://crrev.com/86d902fb84107d677f8a4ebc5df8f705be9dae74/tools/traffic_annotation/auditor/traffic_annotation_auditor.cc
[modify] https://crrev.com/86d902fb84107d677f8a4ebc5df8f705be9dae74/tools/traffic_annotation/auditor/traffic_annotation_auditor.h
[modify] https://crrev.com/86d902fb84107d677f8a4ebc5df8f705be9dae74/tools/traffic_annotation/auditor/traffic_annotation_auditor_ui.cc
[modify] https://crrev.com/86d902fb84107d677f8a4ebc5df8f705be9dae74/tools/traffic_annotation/auditor/traffic_annotation_auditor_unittest.cc
[modify] https://crrev.com/86d902fb84107d677f8a4ebc5df8f705be9dae74/tools/traffic_annotation/auditor/traffic_annotation_file_filter.cc
[add] https://crrev.com/86d902fb84107d677f8a4ebc5df8f705be9dae74/tools/traffic_annotation/auditor/traffic_annotation_id_checker.cc
[add] https://crrev.com/86d902fb84107d677f8a4ebc5df8f705be9dae74/tools/traffic_annotation/auditor/traffic_annotation_id_checker.h
[modify] https://crrev.com/86d902fb84107d677f8a4ebc5df8f705be9dae74/tools/traffic_annotation/summary/annotations.xml

Project Member

Comment 227 by bugdroid1@chromium.org, Dec 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dffd5dc48c06a528e891868f3af7ef91d9950b94

commit dffd5dc48c06a528e891868f3af7ef91d9950b94
Author: rhalavati@google.com <rhalavati@google.com>
Date: Mon Dec 11 15:39:23 2017

Extend annotations.xml.

Extends annotations.xml to include incomplete annotations, file paths,
and the list of fields in the incomplete annotations.

Bug: 656607
Bug: 788035
Change-Id: Ibabbbd91fa8d618571d3fe00dc32fd0aec0277ed
Reviewed-on: https://chromium-review.googlesource.com/817749
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523102}
[modify] https://crrev.com/dffd5dc48c06a528e891868f3af7ef91d9950b94/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/dffd5dc48c06a528e891868f3af7ef91d9950b94/tools/traffic_annotation/auditor/instance.cc
[modify] https://crrev.com/dffd5dc48c06a528e891868f3af7ef91d9950b94/tools/traffic_annotation/auditor/instance.h
[modify] https://crrev.com/dffd5dc48c06a528e891868f3af7ef91d9950b94/tools/traffic_annotation/auditor/traffic_annotation_auditor.cc
[modify] https://crrev.com/dffd5dc48c06a528e891868f3af7ef91d9950b94/tools/traffic_annotation/auditor/traffic_annotation_auditor.h
[modify] https://crrev.com/dffd5dc48c06a528e891868f3af7ef91d9950b94/tools/traffic_annotation/auditor/traffic_annotation_auditor_unittest.cc
[modify] https://crrev.com/dffd5dc48c06a528e891868f3af7ef91d9950b94/tools/traffic_annotation/auditor/traffic_annotation_exporter.cc
[modify] https://crrev.com/dffd5dc48c06a528e891868f3af7ef91d9950b94/tools/traffic_annotation/auditor/traffic_annotation_exporter.h
[modify] https://crrev.com/dffd5dc48c06a528e891868f3af7ef91d9950b94/tools/traffic_annotation/summary/annotations.xml

Project Member

Comment 228 by bugdroid1@chromium.org, Dec 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7eb3cf345dc7832b8a4a91c4132138c669f67eb7

commit 7eb3cf345dc7832b8a4a91c4132138c669f67eb7
Author: rhalavati@google.com <rhalavati@google.com>
Date: Tue Dec 12 05:58:59 2017

Remove default traffic annotation value from 2 classes.

The default network traffic annotation value is removed from the Write
function of the following classes:
 - HttpProxyClientSocket
 - HttpProxyClientSocketWrapper

Bug: 656607
Change-Id: Iae5bb59c2391504e457a323fa178673d70676696
Reviewed-on: https://chromium-review.googlesource.com/817416
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523351}
[modify] https://crrev.com/7eb3cf345dc7832b8a4a91c4132138c669f67eb7/net/http/http_proxy_client_socket.h
[modify] https://crrev.com/7eb3cf345dc7832b8a4a91c4132138c669f67eb7/net/http/http_proxy_client_socket_wrapper.h

Project Member

Comment 229 by bugdroid1@chromium.org, Dec 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a080ff61d4f917ee65bc8dade96984eba830265c

commit a080ff61d4f917ee65bc8dade96984eba830265c
Author: rhalavati@google.com <rhalavati@google.com>
Date: Tue Dec 12 11:02:44 2017

Remove default traffic annotation value from FakeSocket.

The default network traffic annotation value is removed from
FakeSocket.

Bug: 656607
Change-Id: Ie52e1f41de788e0d7119ddc77c6d7641c192b56e
Reviewed-on: https://chromium-review.googlesource.com/817441
Reviewed-by: Eric Roman <eroman@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523398}
[modify] https://crrev.com/a080ff61d4f917ee65bc8dade96984eba830265c/content/browser/renderer_host/p2p/socket_host_test_utils.cc
[modify] https://crrev.com/a080ff61d4f917ee65bc8dade96984eba830265c/content/browser/renderer_host/p2p/socket_host_test_utils.h

Project Member

Comment 230 by bugdroid1@chromium.org, Dec 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06f568655fe9786c87ba25f7f2b7d6827c5503d1

commit 06f568655fe9786c87ba25f7f2b7d6827c5503d1
Author: glevin <glevin@chromium.org>
Date: Tue Dec 12 17:07:05 2017

Add network traffic annotations for Quirks

Bug: 656607
Change-Id: I0719514369f834d93049d0161d2e1d33b9713c87
Reviewed-on: https://chromium-review.googlesource.com/817368
Commit-Queue: Greg Levin <glevin@chromium.org>
Reviewed-by: Greg Levin <glevin@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523459}
[modify] https://crrev.com/06f568655fe9786c87ba25f7f2b7d6827c5503d1/components/quirks/quirks_manager.cc

Project Member

Comment 231 by bugdroid1@chromium.org, Dec 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec4e68e98f2048861ea4262ad011ba49800481ca

commit ec4e68e98f2048861ea4262ad011ba49800481ca
Author: rhalavati@google.com <rhalavati@google.com>
Date: Wed Dec 13 07:47:28 2017

Add Traffic Annotation to interfaces of AdbClientSocket.

Network Traffic Annotation is added to the socket write of the
AdbClientSocket class.

Bug: 656607
Change-Id: I1e05fc201290e0c55b78b8b03aee79284ffd7b4d
Reviewed-on: https://chromium-review.googlesource.com/813757
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523715}
[modify] https://crrev.com/ec4e68e98f2048861ea4262ad011ba49800481ca/chrome/browser/devtools/device/adb/adb_client_socket.cc

Project Member

Comment 233 by bugdroid1@chromium.org, Dec 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/437ba3c4c4987abb77b5907e3bce97642ba917ab

commit 437ba3c4c4987abb77b5907e3bce97642ba917ab
Author: rhalavati@google.com <rhalavati@google.com>
Date: Wed Dec 13 13:27:25 2017

Run Traffic Annotation tests on Trybot only on modified files.

Traffic annotations test script on trybot is updated to only consider
the list of changed files.

Bug: 788035
Bug: 656607
Change-Id: Ib02f971edc65076c44f4aecf0589b30d381e00f7
Reviewed-on: https://chromium-review.googlesource.com/813635
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523761}
[modify] https://crrev.com/437ba3c4c4987abb77b5907e3bce97642ba917ab/tools/traffic_annotation/scripts/check_annotations.py

Project Member

Comment 234 by bugdroid1@chromium.org, Dec 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/578968d45a60fd4da2f79d4fe69a73c0083f0e21

commit 578968d45a60fd4da2f79d4fe69a73c0083f0e21
Author: rhalavati@google.com <rhalavati@google.com>
Date: Wed Dec 13 15:39:32 2017

Remove unused code and comments for socket annotations.

Not required codes and comments related to sockets annotations are
removed from several classes. The changes include:
 - Default network traffic annotation values are removed and test tags
   are added instead if required.
 - Code to store annotations in sockets is removed.
 - Comments regarding annotations storage is removed.

Bug: 656607
Change-Id: I716dd482a6e868ba3b634437c434950db6073332
Reviewed-on: https://chromium-review.googlesource.com/823965
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523778}
[modify] https://crrev.com/578968d45a60fd4da2f79d4fe69a73c0083f0e21/chrome/browser/devtools/device/usb/android_usb_socket.h
[modify] https://crrev.com/578968d45a60fd4da2f79d4fe69a73c0083f0e21/chrome/test/chromedriver/net/adb_client_socket.cc
[modify] https://crrev.com/578968d45a60fd4da2f79d4fe69a73c0083f0e21/chromecast/net/BUILD.gn
[modify] https://crrev.com/578968d45a60fd4da2f79d4fe69a73c0083f0e21/chromecast/net/fake_stream_socket.h
[modify] https://crrev.com/578968d45a60fd4da2f79d4fe69a73c0083f0e21/chromecast/net/fake_stream_socket_unittest.cc
[modify] https://crrev.com/578968d45a60fd4da2f79d4fe69a73c0083f0e21/jingle/glue/fake_ssl_client_socket.h
[modify] https://crrev.com/578968d45a60fd4da2f79d4fe69a73c0083f0e21/jingle/glue/fake_ssl_client_socket_unittest.cc
[modify] https://crrev.com/578968d45a60fd4da2f79d4fe69a73c0083f0e21/jingle/glue/proxy_resolving_client_socket.h
[modify] https://crrev.com/578968d45a60fd4da2f79d4fe69a73c0083f0e21/media/cast/net/udp_transport.cc
[modify] https://crrev.com/578968d45a60fd4da2f79d4fe69a73c0083f0e21/net/quic/chromium/quic_proxy_client_socket.h
[modify] https://crrev.com/578968d45a60fd4da2f79d4fe69a73c0083f0e21/net/quic/chromium/quic_proxy_client_socket_unittest.cc
[modify] https://crrev.com/578968d45a60fd4da2f79d4fe69a73c0083f0e21/net/socket/fuzzed_datagram_client_socket.cc
[modify] https://crrev.com/578968d45a60fd4da2f79d4fe69a73c0083f0e21/net/socket/fuzzed_datagram_client_socket.h
[modify] https://crrev.com/578968d45a60fd4da2f79d4fe69a73c0083f0e21/net/socket/fuzzed_socket.cc
[modify] https://crrev.com/578968d45a60fd4da2f79d4fe69a73c0083f0e21/net/socket/fuzzed_socket.h
[modify] https://crrev.com/578968d45a60fd4da2f79d4fe69a73c0083f0e21/net/socket/fuzzed_socket_factory.cc
[modify] https://crrev.com/578968d45a60fd4da2f79d4fe69a73c0083f0e21/net/socket/socket.h
[modify] https://crrev.com/578968d45a60fd4da2f79d4fe69a73c0083f0e21/net/socket/socket_posix.cc
[modify] https://crrev.com/578968d45a60fd4da2f79d4fe69a73c0083f0e21/net/socket/socket_test_util.cc
[modify] https://crrev.com/578968d45a60fd4da2f79d4fe69a73c0083f0e21/net/socket/socks5_client_socket.h
[modify] https://crrev.com/578968d45a60fd4da2f79d4fe69a73c0083f0e21/net/socket/socks5_client_socket_unittest.cc
[modify] https://crrev.com/578968d45a60fd4da2f79d4fe69a73c0083f0e21/net/socket/socks_client_socket.h
[modify] https://crrev.com/578968d45a60fd4da2f79d4fe69a73c0083f0e21/net/socket/ssl_client_socket_impl.h
[modify] https://crrev.com/578968d45a60fd4da2f79d4fe69a73c0083f0e21/net/socket/ssl_client_socket_unittest.cc
[modify] https://crrev.com/578968d45a60fd4da2f79d4fe69a73c0083f0e21/net/socket/ssl_server_socket_unittest.cc
[modify] https://crrev.com/578968d45a60fd4da2f79d4fe69a73c0083f0e21/net/socket/tcp_socket_win.cc
[modify] https://crrev.com/578968d45a60fd4da2f79d4fe69a73c0083f0e21/net/socket/tcp_socket_win.h
[modify] https://crrev.com/578968d45a60fd4da2f79d4fe69a73c0083f0e21/net/socket/udp_client_socket.h
[modify] https://crrev.com/578968d45a60fd4da2f79d4fe69a73c0083f0e21/net/socket/udp_socket_perftest.cc
[modify] https://crrev.com/578968d45a60fd4da2f79d4fe69a73c0083f0e21/net/socket/udp_socket_unittest.cc
[modify] https://crrev.com/578968d45a60fd4da2f79d4fe69a73c0083f0e21/net/socket/udp_socket_win.cc
[modify] https://crrev.com/578968d45a60fd4da2f79d4fe69a73c0083f0e21/net/socket/udp_socket_win.h
[modify] https://crrev.com/578968d45a60fd4da2f79d4fe69a73c0083f0e21/net/socket/unix_domain_client_socket_posix.h
[modify] https://crrev.com/578968d45a60fd4da2f79d4fe69a73c0083f0e21/net/spdy/chromium/spdy_proxy_client_socket.h
[modify] https://crrev.com/578968d45a60fd4da2f79d4fe69a73c0083f0e21/net/spdy/chromium/spdy_proxy_client_socket_unittest.cc
[modify] https://crrev.com/578968d45a60fd4da2f79d4fe69a73c0083f0e21/remoting/host/security_key/security_key_auth_handler_posix_unittest.cc
[modify] https://crrev.com/578968d45a60fd4da2f79d4fe69a73c0083f0e21/remoting/protocol/pseudotcp_adapter.cc

Project Member

Comment 235 by bugdroid1@chromium.org, Dec 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/459b93c23f41ddb61e32c87dde3ce2b2929ed2c4

commit 459b93c23f41ddb61e32c87dde3ce2b2929ed2c4
Author: rhalavati@google.com <rhalavati@google.com>
Date: Thu Dec 14 06:06:22 2017

Correct typo in ADBClientSocket traffic annotation.

Typo corrected in ADBClientSocket's network traffic annotation.

Bug: 656607
Change-Id: I627e41fc48b778e6b8b2ba423707984a02002f71
Reviewed-on: https://chromium-review.googlesource.com/824242
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524011}
[modify] https://crrev.com/459b93c23f41ddb61e32c87dde3ce2b2929ed2c4/chrome/browser/devtools/device/adb/adb_client_socket.cc

Project Member

Comment 236 by bugdroid1@chromium.org, Dec 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1029a00b55cf283fb4c0fbb082037b9888c1ba90

commit 1029a00b55cf283fb4c0fbb082037b9888c1ba90
Author: rhalavati@google.com <rhalavati@google.com>
Date: Mon Dec 18 17:52:00 2017

Tunnel traffic annotation in BufferedSocketWriter.

Network Traffic Annotation which is received in BufferedSocket::Write is
passed to the actual socket.

Bug: 656607
Change-Id: Ic5c7eb8faff9eb840d9965b0911c0032d6845994
Reviewed-on: https://chromium-review.googlesource.com/827063
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524738}
[modify] https://crrev.com/1029a00b55cf283fb4c0fbb082037b9888c1ba90/remoting/base/buffered_socket_writer.cc

Project Member

Comment 237 by bugdroid1@chromium.org, Dec 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1c21b821b0bac5e8b6155da8f2c3fd3407bf8e9

commit c1c21b821b0bac5e8b6155da8f2c3fd3407bf8e9
Author: rhalavati@google.com <rhalavati@google.com>
Date: Tue Dec 19 14:10:22 2017

Update Network Traffic Annotations summary.

Network traffic annotations summary (annotations.xml) is updated.

Bug: 656607
Change-Id: I78bf9c763f191589ee171e6feceea7eb73b458de
Reviewed-on: https://chromium-review.googlesource.com/824168
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525015}
[modify] https://crrev.com/c1c21b821b0bac5e8b6155da8f2c3fd3407bf8e9/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/c1c21b821b0bac5e8b6155da8f2c3fd3407bf8e9/tools/traffic_annotation/summary/annotations.xml

Project Member

Comment 238 by bugdroid1@chromium.org, Dec 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8cf5d288da3014b41c95d73ffbac57dd70ef6fe

commit d8cf5d288da3014b41c95d73ffbac57dd70ef6fe
Author: rhalavati@google.com <rhalavati@google.com>
Date: Wed Dec 20 16:37:43 2017

Update traffic annotation auditor's TSV report.

Added last updated place holder and content hash code to network traffic
annotation auditor's TSV report, to be used for keeping up the
annotations trix.

Bug: 656607
Change-Id: If7e998250d827daedb9653e0a5d20135130a7325
Reviewed-on: https://chromium-review.googlesource.com/836589
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525346}
[modify] https://crrev.com/d8cf5d288da3014b41c95d73ffbac57dd70ef6fe/tools/traffic_annotation/auditor/instance.cc
[modify] https://crrev.com/d8cf5d288da3014b41c95d73ffbac57dd70ef6fe/tools/traffic_annotation/auditor/instance.h
[modify] https://crrev.com/d8cf5d288da3014b41c95d73ffbac57dd70ef6fe/tools/traffic_annotation/auditor/traffic_annotation_auditor_ui.cc
[modify] https://crrev.com/d8cf5d288da3014b41c95d73ffbac57dd70ef6fe/tools/traffic_annotation/auditor/traffic_annotation_exporter.cc

Project Member

Comment 239 by bugdroid1@chromium.org, Dec 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6814327cbe988e35d7278977e3403d1759c7dc68

commit 6814327cbe988e35d7278977e3403d1759c7dc68
Author: rhalavati@google.com <rhalavati@google.com>
Date: Thu Dec 21 09:14:19 2017

Add network traffic annotation to PepperTCPSocketMessageFilter.

Network traffic annotation tag is added to socket write function in
PepperTCPSocketMessageFilter.

Bug: 656607
Change-Id: Ia9be35558f35db3bbca77ef1b58cd42452227e4c
Reviewed-on: https://chromium-review.googlesource.com/821544
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525653}
[modify] https://crrev.com/6814327cbe988e35d7278977e3403d1759c7dc68/content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc

Project Member

Comment 240 by bugdroid1@chromium.org, Dec 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a76f5dd4073c4a0d6af0d49dfb6f7e000be3a0d

commit 4a76f5dd4073c4a0d6af0d49dfb6f7e000be3a0d
Author: rhalavati@google.com <rhalavati@google.com>
Date: Thu Dec 21 19:00:38 2017

Add traffic annotation to Cast Transport.

Network traffic annotation is added to CastTransportImpl::SendMessage()
to be passed to the underlying socket. This change is propagated to
consumers of this function, so that the annotation would be provided
from the source of the request.

Bug: 656607
Change-Id: I05de11bd4d9ed62b57868c563a6e1f711707b9d3
Reviewed-on: https://chromium-review.googlesource.com/833877
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525757}
[modify] https://crrev.com/4a76f5dd4073c4a0d6af0d49dfb6f7e000be3a0d/components/cast_channel/BUILD.gn
[modify] https://crrev.com/4a76f5dd4073c4a0d6af0d49dfb6f7e000be3a0d/components/cast_channel/cast_socket.cc
[modify] https://crrev.com/4a76f5dd4073c4a0d6af0d49dfb6f7e000be3a0d/components/cast_channel/cast_socket_unittest.cc
[modify] https://crrev.com/4a76f5dd4073c4a0d6af0d49dfb6f7e000be3a0d/components/cast_channel/cast_test_util.h
[modify] https://crrev.com/4a76f5dd4073c4a0d6af0d49dfb6f7e000be3a0d/components/cast_channel/cast_transport.cc
[modify] https://crrev.com/4a76f5dd4073c4a0d6af0d49dfb6f7e000be3a0d/components/cast_channel/cast_transport.h
[modify] https://crrev.com/4a76f5dd4073c4a0d6af0d49dfb6f7e000be3a0d/components/cast_channel/cast_transport_unittest.cc
[modify] https://crrev.com/4a76f5dd4073c4a0d6af0d49dfb6f7e000be3a0d/components/cast_channel/keep_alive_delegate.cc
[modify] https://crrev.com/4a76f5dd4073c4a0d6af0d49dfb6f7e000be3a0d/components/cast_channel/keep_alive_delegate_unittest.cc
[modify] https://crrev.com/4a76f5dd4073c4a0d6af0d49dfb6f7e000be3a0d/extensions/browser/api/cast_channel/cast_channel_api.cc
[modify] https://crrev.com/4a76f5dd4073c4a0d6af0d49dfb6f7e000be3a0d/extensions/browser/api/cast_channel/cast_channel_apitest.cc

Project Member

Comment 241 by bugdroid1@chromium.org, Dec 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cda4b7b809bf8ee210fb59cba72199b18c636a7b

commit cda4b7b809bf8ee210fb59cba72199b18c636a7b
Author: rhalavati@google.com <rhalavati@google.com>
Date: Fri Dec 22 07:01:12 2017

Add traffic annotation to UdpTransport class.

Network traffic annotation is added to UdpTransport class, and hence
the unnecessary default network traffic annotation value is removed from
UDPSocketPosix.

Bug: 656607
Change-Id: I442fc18207527a63d13183daf55908ce406498f4
Reviewed-on: https://chromium-review.googlesource.com/819130
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525950}
[modify] https://crrev.com/cda4b7b809bf8ee210fb59cba72199b18c636a7b/media/cast/net/udp_transport.cc
[modify] https://crrev.com/cda4b7b809bf8ee210fb59cba72199b18c636a7b/net/socket/udp_socket_posix.h

Project Member

Comment 242 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ba2f602f5979b220e7ff94cbed7904c1138182e

commit 6ba2f602f5979b220e7ff94cbed7904c1138182e
Author: rhalavati@google.com <rhalavati@google.com>
Date: Tue Jan 09 14:26:41 2018

Update traffic annotation auditor to run tests on partial repository.

Network traffic annotation auditor is updated to be able to run all
tests on a partial subset of the repository.

Bug: 690323
Bug: 656607
Change-Id: If9a97e14de116530b3fb05f5e27f2b4e2d41e871
Reviewed-on: https://chromium-review.googlesource.com/839600
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527985}
[modify] https://crrev.com/6ba2f602f5979b220e7ff94cbed7904c1138182e/tools/traffic_annotation/auditor/auditor_result.cc
[modify] https://crrev.com/6ba2f602f5979b220e7ff94cbed7904c1138182e/tools/traffic_annotation/auditor/instance.cc
[modify] https://crrev.com/6ba2f602f5979b220e7ff94cbed7904c1138182e/tools/traffic_annotation/auditor/instance.h
[modify] https://crrev.com/6ba2f602f5979b220e7ff94cbed7904c1138182e/tools/traffic_annotation/auditor/traffic_annotation_auditor.cc
[modify] https://crrev.com/6ba2f602f5979b220e7ff94cbed7904c1138182e/tools/traffic_annotation/auditor/traffic_annotation_auditor.h
[modify] https://crrev.com/6ba2f602f5979b220e7ff94cbed7904c1138182e/tools/traffic_annotation/auditor/traffic_annotation_auditor_ui.cc
[modify] https://crrev.com/6ba2f602f5979b220e7ff94cbed7904c1138182e/tools/traffic_annotation/auditor/traffic_annotation_auditor_unittest.cc
[modify] https://crrev.com/6ba2f602f5979b220e7ff94cbed7904c1138182e/tools/traffic_annotation/auditor/traffic_annotation_exporter.cc
[modify] https://crrev.com/6ba2f602f5979b220e7ff94cbed7904c1138182e/tools/traffic_annotation/auditor/traffic_annotation_exporter.h
[modify] https://crrev.com/6ba2f602f5979b220e7ff94cbed7904c1138182e/tools/traffic_annotation/auditor/traffic_annotation_id_checker.cc
[modify] https://crrev.com/6ba2f602f5979b220e7ff94cbed7904c1138182e/tools/traffic_annotation/auditor/traffic_annotation_id_checker.h

Project Member

Comment 243 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1009ad76d789cd118c778fc85019445025a4c7c8

commit 1009ad76d789cd118c778fc85019445025a4c7c8
Author: rhalavati@google.com <rhalavati@google.com>
Date: Tue Jan 09 14:46:10 2018

Update annotation auditor TSV output.

Annotation auditor's TSV output is updated:
 1- An empty line with just unique id is added for every annotation that
    belongs to other platforms.
 2- Incomplete annotations are not reported in the TSV file.
 3- A comment is added for merged annotations stating the partial
    annotations used to make them.

Bug: 656607
Bug: 690323
Change-Id: I9168e9d537e5bc4aca0b89636c778f869c0b6fd3
Reviewed-on: https://chromium-review.googlesource.com/842642
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527988}
[modify] https://crrev.com/1009ad76d789cd118c778fc85019445025a4c7c8/tools/traffic_annotation/auditor/instance.cc
[modify] https://crrev.com/1009ad76d789cd118c778fc85019445025a4c7c8/tools/traffic_annotation/auditor/instance.h
[modify] https://crrev.com/1009ad76d789cd118c778fc85019445025a4c7c8/tools/traffic_annotation/auditor/traffic_annotation_auditor_ui.cc
[modify] https://crrev.com/1009ad76d789cd118c778fc85019445025a4c7c8/tools/traffic_annotation/auditor/traffic_annotation_exporter.cc
[modify] https://crrev.com/1009ad76d789cd118c778fc85019445025a4c7c8/tools/traffic_annotation/auditor/traffic_annotation_exporter.h

Project Member

Comment 244 by bugdroid1@chromium.org, Jan 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8e880d3c8e25585160af86e842a82dae8eebcfe

commit e8e880d3c8e25585160af86e842a82dae8eebcfe
Author: rhalavati@google.com <rhalavati@google.com>
Date: Wed Jan 10 06:40:58 2018

Update traffic anntoation for WebUIURLFetcher::Start().

The cookies section of WebUIURLFetcher::Start() is updated.

Bug: 656607
Bug: 796504
Change-Id: Ib06653ce5d15d2f83d8716f190347583dcfee722
Reviewed-on: https://chromium-review.googlesource.com/839862
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528252}
[modify] https://crrev.com/e8e880d3c8e25585160af86e842a82dae8eebcfe/extensions/browser/guest_view/web_view/web_ui/web_ui_url_fetcher.cc

Project Member

Comment 245 by bugdroid1@chromium.org, Jan 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32d4b3d31268254a6aa6cda352291fc921e0b208

commit 32d4b3d31268254a6aa6cda352291fc921e0b208
Author: rhalavati@google.com <rhalavati@google.com>
Date: Wed Jan 10 07:35:28 2018

Update network traffic annotations list.

tools/traffic_annotation/summary/annotations.xml and annotation items
in tools/metrics/histograms/enums.xml are updated.

Bug:656607
Change-Id: Icad841955016a338f1f40855c9133026161a53ce

TBR=msramek

Change-Id: Icad841955016a338f1f40855c9133026161a53ce
Reviewed-on: https://chromium-review.googlesource.com/859076
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528258}
[modify] https://crrev.com/32d4b3d31268254a6aa6cda352291fc921e0b208/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/32d4b3d31268254a6aa6cda352291fc921e0b208/tools/traffic_annotation/summary/annotations.xml

Project Member

Comment 246 by bugdroid1@chromium.org, Jan 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27fb73c666780e66a2013dc27aafb5283fde6af8

commit 27fb73c666780e66a2013dc27aafb5283fde6af8
Author: rhalavati@google.com <rhalavati@google.com>
Date: Thu Jan 11 13:27:24 2018

Add traffic annotation to Socks and Socks5 Client Sockets handshakes.

Network traffic annotations required for the handshakes of Socks and
Socks5 client sockets are received from the proxy_info that is passed
to the client socket. This annotation will specify the origin of proxy
settings for the client socket and how it can be controlled.

This CL just performs the required changes to tunnel the annotation
from proxy_info to the actual socket write in the client sockets, and a
later CL will update the proxy_info's annotations.

This CL is not supposed to cause any behavioral changes to client
sockets.

Bug: 656607
Change-Id: Ia9688972534b24bbedb940dc93abd8f9032050f0
Reviewed-on: https://chromium-review.googlesource.com/824362
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528614}
[modify] https://crrev.com/27fb73c666780e66a2013dc27aafb5283fde6af8/net/proxy/proxy_info.cc
[modify] https://crrev.com/27fb73c666780e66a2013dc27aafb5283fde6af8/net/proxy/proxy_info.h
[modify] https://crrev.com/27fb73c666780e66a2013dc27aafb5283fde6af8/net/socket/client_socket_pool_manager.cc
[modify] https://crrev.com/27fb73c666780e66a2013dc27aafb5283fde6af8/net/socket/socks5_client_socket.cc
[modify] https://crrev.com/27fb73c666780e66a2013dc27aafb5283fde6af8/net/socket/socks5_client_socket.h
[modify] https://crrev.com/27fb73c666780e66a2013dc27aafb5283fde6af8/net/socket/socks5_client_socket_fuzzer.cc
[modify] https://crrev.com/27fb73c666780e66a2013dc27aafb5283fde6af8/net/socket/socks5_client_socket_unittest.cc
[modify] https://crrev.com/27fb73c666780e66a2013dc27aafb5283fde6af8/net/socket/socks_client_socket.cc
[modify] https://crrev.com/27fb73c666780e66a2013dc27aafb5283fde6af8/net/socket/socks_client_socket.h
[modify] https://crrev.com/27fb73c666780e66a2013dc27aafb5283fde6af8/net/socket/socks_client_socket_fuzzer.cc
[modify] https://crrev.com/27fb73c666780e66a2013dc27aafb5283fde6af8/net/socket/socks_client_socket_pool.cc
[modify] https://crrev.com/27fb73c666780e66a2013dc27aafb5283fde6af8/net/socket/socks_client_socket_pool.h
[modify] https://crrev.com/27fb73c666780e66a2013dc27aafb5283fde6af8/net/socket/socks_client_socket_pool_unittest.cc
[modify] https://crrev.com/27fb73c666780e66a2013dc27aafb5283fde6af8/net/socket/socks_client_socket_unittest.cc
[modify] https://crrev.com/27fb73c666780e66a2013dc27aafb5283fde6af8/net/socket/ssl_client_socket_pool_unittest.cc

Project Member

Comment 247 by bugdroid1@chromium.org, Jan 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2dfb924173c419f5c9cfeec74f8a87596f16b804

commit 2dfb924173c419f5c9cfeec74f8a87596f16b804
Author: rhalavati@google.com <rhalavati@google.com>
Date: Fri Jan 12 13:35:59 2018

Add traffic annotation auditor's executable path to md files.

The path to the latest executable of traffic annotation auditor is added
to:
tools/traffic_annotation/summary/README.md
docs/network_traffic_annotations.md

Bug: 656607
Change-Id: I5d1482e802d56ff592a4b2bbf64f2ee927d72b3d
Reviewed-on: https://chromium-review.googlesource.com/863604
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528933}
[modify] https://crrev.com/2dfb924173c419f5c9cfeec74f8a87596f16b804/docs/network_traffic_annotations.md
[modify] https://crrev.com/2dfb924173c419f5c9cfeec74f8a87596f16b804/tools/traffic_annotation/summary/README.md

Project Member

Comment 248 by bugdroid1@chromium.org, Jan 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce7438c54f3d5de91dc28536e29ef16dca2dd2a7

commit ce7438c54f3d5de91dc28536e29ef16dca2dd2a7
Author: rhalavati@google.com <rhalavati@google.com>
Date: Mon Jan 15 07:43:45 2018

Update annotations.xml.

tools/traffic_annotation/summary/annotations.xml is updated to reflect a
removed item.

TBR=msramek

Bug: 656607
Change-Id: I9d8deb63977db89be5d4930e2d589f23d8477029
Reviewed-on: https://chromium-review.googlesource.com/866495
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529222}
[modify] https://crrev.com/ce7438c54f3d5de91dc28536e29ef16dca2dd2a7/tools/traffic_annotation/summary/annotations.xml

Project Member

Comment 249 by bugdroid1@chromium.org, Jan 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbd29a85e0e8b69c62b1c29c25ed0f75f60c387b

commit fbd29a85e0e8b69c62b1c29c25ed0f75f60c387b
Author: rhalavati@google.com <rhalavati@google.com>
Date: Mon Jan 15 17:00:01 2018

Update tools/traffic_annotation readme files.

Adds a reference to 'docs/network_traffic_annotations.md' to three
readme files in 'tools/traffic_annotation', to provide a reference for
terms and more details on operations.

Bug: 656607
Change-Id: I440a9f65dcc8adb8429a4482cbc650167b6d8bd3
Reviewed-on: https://chromium-review.googlesource.com/866724
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529302}
[modify] https://crrev.com/fbd29a85e0e8b69c62b1c29c25ed0f75f60c387b/tools/traffic_annotation/README.md
[modify] https://crrev.com/fbd29a85e0e8b69c62b1c29c25ed0f75f60c387b/tools/traffic_annotation/auditor/README.md
[modify] https://crrev.com/fbd29a85e0e8b69c62b1c29c25ed0f75f60c387b/tools/traffic_annotation/summary/README.md

Project Member

Comment 250 by bugdroid1@chromium.org, Jan 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e11ac852e7a1dfa3932de7bf47ac46f750eac23

commit 3e11ac852e7a1dfa3932de7bf47ac46f750eac23
Author: rhalavati@google.com <rhalavati@google.com>
Date: Tue Jan 16 08:02:39 2018

Add network traffic annotation to bluetooth socket.

Network traffic annotation is added to bluetooth socket.

Bug: 656607
Change-Id: I753fc6bd3f4526dc73d9febeeb3872e2657a6c72
Reviewed-on: https://chromium-review.googlesource.com/859238
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529376}
[modify] https://crrev.com/3e11ac852e7a1dfa3932de7bf47ac46f750eac23/device/bluetooth/bluetooth_socket_net.cc
[modify] https://crrev.com/3e11ac852e7a1dfa3932de7bf47ac46f750eac23/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/3e11ac852e7a1dfa3932de7bf47ac46f750eac23/tools/traffic_annotation/summary/annotations.xml

Project Member

Comment 251 by bugdroid1@chromium.org, Jan 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b12916d5ec98a2a17c4753192a8b563163b004d8

commit b12916d5ec98a2a17c4753192a8b563163b004d8
Author: rhalavati@google.com <rhalavati@google.com>
Date: Tue Jan 16 17:35:51 2018

Add deprecated annotations to annotations.xml.

Deprecated annotations were dropped from annotations.xml in a former
manual updated. They are added back.

Bug: 656607
Change-Id: If0ed5e36c26b23067a86e6e7c619415f5241cce9
Reviewed-on: https://chromium-review.googlesource.com/867043
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529455}
[modify] https://crrev.com/b12916d5ec98a2a17c4753192a8b563163b004d8/tools/traffic_annotation/summary/annotations.xml

Project Member

Comment 252 by bugdroid1@chromium.org, Jan 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0ac81324793e507d14cd252b40acd73ad6b9312

commit f0ac81324793e507d14cd252b40acd73ad6b9312
Author: rhalavati@google.com <rhalavati@google.com>
Date: Tue Jan 16 20:34:41 2018

Add traffic annotation to FtpNetworkTransaction.

Network traffic annotation is passed to FtpNetworkTransaction to be
used in underlying sockets.

Bug: 656607
Change-Id: I5a1b7f1b860d40e310afadb8888ed3355cae9e29
Reviewed-on: https://chromium-review.googlesource.com/860930
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529497}
[modify] https://crrev.com/f0ac81324793e507d14cd252b40acd73ad6b9312/net/ftp/ftp_network_transaction.cc
[modify] https://crrev.com/f0ac81324793e507d14cd252b40acd73ad6b9312/net/ftp/ftp_network_transaction.h
[modify] https://crrev.com/f0ac81324793e507d14cd252b40acd73ad6b9312/net/ftp/ftp_network_transaction_unittest.cc
[modify] https://crrev.com/f0ac81324793e507d14cd252b40acd73ad6b9312/net/ftp/ftp_transaction.h
[modify] https://crrev.com/f0ac81324793e507d14cd252b40acd73ad6b9312/net/url_request/url_request_ftp_job.cc

Project Member

Comment 253 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b187ab28081fc447c06dd14d65315d8b2c281aa

commit 0b187ab28081fc447c06dd14d65315d8b2c281aa
Author: rhalavati@google.com <rhalavati@google.com>
Date: Wed Jan 17 07:12:35 2018

Add traffic annotation to sockets of DevTools.

Network traffic annotation is added to the sockets used in:
chrome/browser/devtools/device/android_device_manager.cc
chrome/browser/devtools/device/android_web_socket.cc
chrome/browser/devtools/device/port_forwarding_controller.cc
rome/browser/devtools/device/android_web_socket.cc

Bug: 656607
Change-Id: I6a8baf79cc3d4752d9b0dbc2ad9c291cdc817da4
Reviewed-on: https://chromium-review.googlesource.com/859377
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529661}
[modify] https://crrev.com/0b187ab28081fc447c06dd14d65315d8b2c281aa/chrome/browser/devtools/device/android_device_manager.cc
[modify] https://crrev.com/0b187ab28081fc447c06dd14d65315d8b2c281aa/chrome/browser/devtools/device/android_web_socket.cc
[modify] https://crrev.com/0b187ab28081fc447c06dd14d65315d8b2c281aa/chrome/browser/devtools/device/port_forwarding_controller.cc
[modify] https://crrev.com/0b187ab28081fc447c06dd14d65315d8b2c281aa/content/browser/devtools/protocol/tethering_handler.cc
[modify] https://crrev.com/0b187ab28081fc447c06dd14d65315d8b2c281aa/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/0b187ab28081fc447c06dd14d65315d8b2c281aa/tools/traffic_annotation/summary/annotations.xml

Project Member

Comment 254 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bbab1e90694b15cf9b5ccb570614400747270e9b

commit bbab1e90694b15cf9b5ccb570614400747270e9b
Author: Martin Sramek <msramek@chromium.org>
Date: Wed Jan 17 13:45:36 2018

Added the privacy team as traffic annotation owners.

Bug: 656607
Change-Id: I3328304b79da59825b0b8c7c4cd051cf434cf5b8
Reviewed-on: https://chromium-review.googlesource.com/862742
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Thiemo Nagel <tnagel@chromium.org>
Commit-Queue: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529725}
[add] https://crrev.com/bbab1e90694b15cf9b5ccb570614400747270e9b/tools/traffic_annotation/summary/OWNERS

Project Member

Comment 255 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0046bb72b2afa99c4739dc0a69e501879201872e

commit 0046bb72b2afa99c4739dc0a69e501879201872e
Author: rhalavati@google.com <rhalavati@google.com>
Date: Wed Jan 17 14:58:49 2018

Update annotations.xml.

Formating issues in tools/traffic_annotation/summary/annotations.xml are
corrected and some deprecated items are marked.

Bug: 656607
Change-Id: Id7a84d8a3d1f4e9ad3fcbb688d4e73660c146fa1
Reviewed-on: https://chromium-review.googlesource.com/870323
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529741}
[modify] https://crrev.com/0046bb72b2afa99c4739dc0a69e501879201872e/tools/traffic_annotation/summary/annotations.xml

Project Member

Comment 256 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/baee31aa70dca0f7030dec7ffde350317d684f71

commit baee31aa70dca0f7030dec7ffde350317d684f71
Author: rhalavati@google.com <rhalavati@google.com>
Date: Thu Jan 18 06:10:23 2018

Add traffic annotation to HttpStreamParser.

Network traffic annotation is added to HttpStreamParser::SendRequest to
be passed to underlying socket.

Bug: 656607
Change-Id: Ibef6a50ac5f72febcdbc918d6cc31fd9b9de2587
Reviewed-on: https://chromium-review.googlesource.com/870114
Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530069}
[modify] https://crrev.com/baee31aa70dca0f7030dec7ffde350317d684f71/net/http/http_basic_stream.cc
[modify] https://crrev.com/baee31aa70dca0f7030dec7ffde350317d684f71/net/http/http_network_transaction_unittest.cc
[modify] https://crrev.com/baee31aa70dca0f7030dec7ffde350317d684f71/net/http/http_proxy_client_socket.cc
[modify] https://crrev.com/baee31aa70dca0f7030dec7ffde350317d684f71/net/http/http_stream_parser.cc
[modify] https://crrev.com/baee31aa70dca0f7030dec7ffde350317d684f71/net/http/http_stream_parser.h
[modify] https://crrev.com/baee31aa70dca0f7030dec7ffde350317d684f71/net/http/http_stream_parser_fuzzer.cc
[modify] https://crrev.com/baee31aa70dca0f7030dec7ffde350317d684f71/net/http/http_stream_parser_unittest.cc
[modify] https://crrev.com/baee31aa70dca0f7030dec7ffde350317d684f71/net/websockets/websocket_basic_handshake_stream.cc

Project Member

Comment 257 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5f809270cb9b54e80602d9de0a7b06486bd8915

commit f5f809270cb9b54e80602d9de0a7b06486bd8915
Author: rhalavati@chromium.org <rhalavati@google.com>
Date: Thu Jan 18 07:34:30 2018

Add traffic annotation to DNSTransaction queries.

To add network traffic annotation to query commands of DNSTransaction,
Network traffic annotation is added to DNSQuery class so that the
required annotations come from the origin of the query.

Bug: 656607
Change-Id: I91403724948e896398b13ed310fe74665a5431fb
Reviewed-on: https://chromium-review.googlesource.com/824045
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530084}
[modify] https://crrev.com/f5f809270cb9b54e80602d9de0a7b06486bd8915/net/dns/dns_transaction.cc
[modify] https://crrev.com/f5f809270cb9b54e80602d9de0a7b06486bd8915/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/f5f809270cb9b54e80602d9de0a7b06486bd8915/tools/traffic_annotation/summary/annotations.xml

Project Member

Comment 258 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ff7becca72a9a1f1c3319f4e6d4c84d7b734783

commit 9ff7becca72a9a1f1c3319f4e6d4c84d7b734783
Author: rhalavati@chromium.org <rhalavati@google.com>
Date: Fri Jan 19 06:32:32 2018

Pass network traffic annotation To P2PSocketHostTcpBase.

Network traffic annotations should be passed from the request sources
to the final sockets. This CL does the annotation tunneling from
SocketDispatcherHost to the actual sockets in P2PSocketHostTcpBase.
In a next CL, we will pass the annotation from the call sources (like
WebRTC) to SocketDispatcherHost.

Bug: 656607
Change-Id: I83cd604197dec71e77df429dfd0aed5bb3edc96a
Reviewed-on: https://chromium-review.googlesource.com/859499
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530438}
[modify] https://crrev.com/9ff7becca72a9a1f1c3319f4e6d4c84d7b734783/content/browser/renderer_host/p2p/socket_dispatcher_host.cc
[modify] https://crrev.com/9ff7becca72a9a1f1c3319f4e6d4c84d7b734783/content/browser/renderer_host/p2p/socket_host.h
[modify] https://crrev.com/9ff7becca72a9a1f1c3319f4e6d4c84d7b734783/content/browser/renderer_host/p2p/socket_host_tcp.cc
[modify] https://crrev.com/9ff7becca72a9a1f1c3319f4e6d4c84d7b734783/content/browser/renderer_host/p2p/socket_host_tcp.h
[modify] https://crrev.com/9ff7becca72a9a1f1c3319f4e6d4c84d7b734783/content/browser/renderer_host/p2p/socket_host_tcp_server.cc
[modify] https://crrev.com/9ff7becca72a9a1f1c3319f4e6d4c84d7b734783/content/browser/renderer_host/p2p/socket_host_tcp_server.h
[modify] https://crrev.com/9ff7becca72a9a1f1c3319f4e6d4c84d7b734783/content/browser/renderer_host/p2p/socket_host_tcp_unittest.cc
[modify] https://crrev.com/9ff7becca72a9a1f1c3319f4e6d4c84d7b734783/content/browser/renderer_host/p2p/socket_host_udp.cc
[modify] https://crrev.com/9ff7becca72a9a1f1c3319f4e6d4c84d7b734783/content/browser/renderer_host/p2p/socket_host_udp.h
[modify] https://crrev.com/9ff7becca72a9a1f1c3319f4e6d4c84d7b734783/content/browser/renderer_host/p2p/socket_host_udp_unittest.cc

Project Member

Comment 259 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/020e72c97b9b087b18567bed7233558a716e5ca7

commit 020e72c97b9b087b18567bed7233558a716e5ca7
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Fri Jan 19 07:41:14 2018

Add network traffic annotation to SocketOutputStream.

Network traffic annotation is added to SocketOutputStream constructor to
be passed to underlying socket classes.

Bug: 656607
Change-Id: I0f1ba4a944cf785c6aefad376475fdffbf2ce168
Reviewed-on: https://chromium-review.googlesource.com/870032
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Nicolas Zea <zea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530448}
[modify] https://crrev.com/020e72c97b9b087b18567bed7233558a716e5ca7/google_apis/gcm/BUILD.gn
[modify] https://crrev.com/020e72c97b9b087b18567bed7233558a716e5ca7/google_apis/gcm/base/socket_stream.cc
[modify] https://crrev.com/020e72c97b9b087b18567bed7233558a716e5ca7/google_apis/gcm/base/socket_stream.h
[modify] https://crrev.com/020e72c97b9b087b18567bed7233558a716e5ca7/google_apis/gcm/base/socket_stream_unittest.cc
[modify] https://crrev.com/020e72c97b9b087b18567bed7233558a716e5ca7/google_apis/gcm/engine/connection_factory_impl.cc
[modify] https://crrev.com/020e72c97b9b087b18567bed7233558a716e5ca7/google_apis/gcm/engine/connection_factory_impl_unittest.cc
[modify] https://crrev.com/020e72c97b9b087b18567bed7233558a716e5ca7/google_apis/gcm/engine/connection_handler.h
[modify] https://crrev.com/020e72c97b9b087b18567bed7233558a716e5ca7/google_apis/gcm/engine/connection_handler_impl.cc
[modify] https://crrev.com/020e72c97b9b087b18567bed7233558a716e5ca7/google_apis/gcm/engine/connection_handler_impl.h
[modify] https://crrev.com/020e72c97b9b087b18567bed7233558a716e5ca7/google_apis/gcm/engine/connection_handler_impl_unittest.cc
[modify] https://crrev.com/020e72c97b9b087b18567bed7233558a716e5ca7/google_apis/gcm/engine/fake_connection_factory.cc
[modify] https://crrev.com/020e72c97b9b087b18567bed7233558a716e5ca7/google_apis/gcm/engine/fake_connection_handler.cc
[modify] https://crrev.com/020e72c97b9b087b18567bed7233558a716e5ca7/google_apis/gcm/engine/fake_connection_handler.h

Project Member

Comment 260 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7c93b3b56e5ca4d9d97123aa6123a56163ed1af

commit d7c93b3b56e5ca4d9d97123aa6123a56163ed1af
Author: rhalavati@chromium.org <rhalavati@google.com>
Date: Fri Jan 19 08:39:07 2018

Update mutable annotations comments.

Comments on definition and help doc of mutable annotations are updated
to provide a more precise set of use cases for them.

Bug: 656607
Change-Id: I72d04fd960be558222a87e2f6e4cabd1313a73f0
Reviewed-on: https://chromium-review.googlesource.com/872930
Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530452}
[modify] https://crrev.com/d7c93b3b56e5ca4d9d97123aa6123a56163ed1af/docs/network_traffic_annotations.md
[modify] https://crrev.com/d7c93b3b56e5ca4d9d97123aa6123a56163ed1af/net/traffic_annotation/network_traffic_annotation.h

Project Member

Comment 261 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98744bfa44cff1c31f33daf37e4fd839e8a8a3a4

commit 98744bfa44cff1c31f33daf37e4fd839e8a8a3a4
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Fri Jan 19 10:12:38 2018

Add network traffic annotation to Cast Channel.

Adds network traffic annotation tag to the socket writes of the
following files:
 - components/cast_channel/cast_socket.cc
 - components/cast_channel/keep_alive_delegate.cc

Bug: 656607
Change-Id: Ie504981e612e6eaa913095fa55da77dd23a9d285
Reviewed-on: https://chromium-review.googlesource.com/873411
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530466}
[modify] https://crrev.com/98744bfa44cff1c31f33daf37e4fd839e8a8a3a4/components/cast_channel/cast_socket.cc
[modify] https://crrev.com/98744bfa44cff1c31f33daf37e4fd839e8a8a3a4/components/cast_channel/keep_alive_delegate.cc
[modify] https://crrev.com/98744bfa44cff1c31f33daf37e4fd839e8a8a3a4/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/98744bfa44cff1c31f33daf37e4fd839e8a8a3a4/tools/traffic_annotation/summary/annotations.xml

Project Member

Comment 262 by bugdroid1@chromium.org, Jan 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06c8cabd79fe69845f11220b370c9b332618517a

commit 06c8cabd79fe69845f11220b370c9b332618517a
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Mon Jan 22 09:34:30 2018

Update traffic annotation auditor on Windows.

Network traffic annotation auditor is updated to pass '-Wno-comment'
switch to clang tool, so that the clang tool does not consider
multi-line comments as errors.

tools/clang/script/run_tool.py is updated to accept more than one
argument as 'tool-args' and pass them to the clang tool.

Bug: 656607
Bug: 690323
Change-Id: I2b0e662ac94ef362cdab5aa8498fa7fce97d40d3
Reviewed-on: https://chromium-review.googlesource.com/870321
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530827}
[modify] https://crrev.com/06c8cabd79fe69845f11220b370c9b332618517a/tools/clang/scripts/run_tool.py
[modify] https://crrev.com/06c8cabd79fe69845f11220b370c9b332618517a/tools/traffic_annotation/README.md
[modify] https://crrev.com/06c8cabd79fe69845f11220b370c9b332618517a/tools/traffic_annotation/auditor/traffic_annotation_auditor.cc
[modify] https://crrev.com/06c8cabd79fe69845f11220b370c9b332618517a/tools/traffic_annotation/bin/linux64/traffic_annotation_auditor.sha1

Project Member

Comment 263 by bugdroid1@chromium.org, Jan 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2940b17d232cf84f7a0496eb5ae56f2e349fefa

commit b2940b17d232cf84f7a0496eb5ae56f2e349fefa
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Thu Jan 25 12:21:59 2018

Add traffic annotation to Jingle Glue Sockets.

Network traffic annotation is added to socket writes of:
jingle/glue/chrome_async_socket.cc
jingle/glue/fake_ssl_client_socket.cc

Bug: 656607
Change-Id: I01e083c9a7154a6fc5071839a4f26007e3717ea4
Reviewed-on: https://chromium-review.googlesource.com/885812
Reviewed-by: Nicolas Zea <zea@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531867}
[modify] https://crrev.com/b2940b17d232cf84f7a0496eb5ae56f2e349fefa/jingle/glue/chrome_async_socket.cc
[modify] https://crrev.com/b2940b17d232cf84f7a0496eb5ae56f2e349fefa/jingle/glue/chrome_async_socket.h
[modify] https://crrev.com/b2940b17d232cf84f7a0496eb5ae56f2e349fefa/jingle/glue/chrome_async_socket_unittest.cc
[modify] https://crrev.com/b2940b17d232cf84f7a0496eb5ae56f2e349fefa/jingle/glue/fake_ssl_client_socket.cc
[modify] https://crrev.com/b2940b17d232cf84f7a0496eb5ae56f2e349fefa/jingle/notifier/base/xmpp_connection.cc

Project Member

Comment 265 by bugdroid1@chromium.org, Jan 30 2018

Project Member

Comment 266 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35565a5d3d623f5420d066a4bf9814e6c5075998

commit 35565a5d3d623f5420d066a4bf9814e6c5075998
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Thu Feb 01 14:49:24 2018

Add traffic annotation to SocketBIOAdapter.

Local network traffic annotation is to the socket write function in
ScoketBIOAdapter.

Bug: 656607
Change-Id: Id2008b1f877db80e006c1be3c31936f890189913
Reviewed-on: https://chromium-review.googlesource.com/873270
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533659}
[modify] https://crrev.com/35565a5d3d623f5420d066a4bf9814e6c5075998/net/socket/socket_bio_adapter.cc
[modify] https://crrev.com/35565a5d3d623f5420d066a4bf9814e6c5075998/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/35565a5d3d623f5420d066a4bf9814e6c5075998/tools/traffic_annotation/summary/annotations.xml

Project Member

Comment 267 by bugdroid1@chromium.org, Feb 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1f1ffbf7344ca19846bd2692e67f3dfe0246f0c

commit e1f1ffbf7344ca19846bd2692e67f3dfe0246f0c
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Fri Feb 02 05:51:09 2018

Add traffic annotation to Remoting Authentication.

Network traffic anntoation is added to socket writes of:
remoting/protocol/fake_authenticator.cc
remoting/protocol/ssl_hmac_channel_authenticator.cc

Bug: 656607
Change-Id: Ifd157307c70ea936194c2bcb9395deb3c95d3929
Reviewed-on: https://chromium-review.googlesource.com/885807
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533968}
[modify] https://crrev.com/e1f1ffbf7344ca19846bd2692e67f3dfe0246f0c/remoting/protocol/fake_authenticator.cc
[modify] https://crrev.com/e1f1ffbf7344ca19846bd2692e67f3dfe0246f0c/remoting/protocol/ssl_hmac_channel_authenticator.cc
[modify] https://crrev.com/e1f1ffbf7344ca19846bd2692e67f3dfe0246f0c/remoting/protocol/ssl_hmac_channel_authenticator.h
[modify] https://crrev.com/e1f1ffbf7344ca19846bd2692e67f3dfe0246f0c/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/e1f1ffbf7344ca19846bd2692e67f3dfe0246f0c/tools/traffic_annotation/summary/annotations.xml

Project Member

Comment 268 by bugdroid1@chromium.org, Feb 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/065f3687ccddb36d0a8ddc5367526488dd348bd4

commit 065f3687ccddb36d0a8ddc5367526488dd348bd4
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Sat Feb 03 09:55:14 2018

Add traffic annotation argument to P2PHostMsg_Send.

To have proper network traffic annotation in
P2PSocketDispatcherHost::OnSend, the argument is added to
P2PHostMsg_Send IPC message.

Bug: 656607
Change-Id: Ie563b8f6da7d3855013648968fa5eb36b81abf01
Reviewed-on: https://chromium-review.googlesource.com/886482
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534267}
[modify] https://crrev.com/065f3687ccddb36d0a8ddc5367526488dd348bd4/content/browser/renderer_host/p2p/socket_dispatcher_host.cc
[modify] https://crrev.com/065f3687ccddb36d0a8ddc5367526488dd348bd4/content/browser/renderer_host/p2p/socket_dispatcher_host.h
[modify] https://crrev.com/065f3687ccddb36d0a8ddc5367526488dd348bd4/content/common/p2p_messages.h
[modify] https://crrev.com/065f3687ccddb36d0a8ddc5367526488dd348bd4/content/common/p2p_socket_type.h
[modify] https://crrev.com/065f3687ccddb36d0a8ddc5367526488dd348bd4/content/renderer/p2p/socket_client_impl.cc

Project Member

Comment 269 by bugdroid1@chromium.org, Feb 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d65f7afa38d7af6374e641f95d00593c7098d5ff

commit d65f7afa38d7af6374e641f95d00593c7098d5ff
Author: Tommi <tommi@chromium.org>
Date: Sat Feb 03 13:55:57 2018

Revert "Add traffic annotation argument to P2PHostMsg_Send."

This reverts commit 065f3687ccddb36d0a8ddc5367526488dd348bd4.

Reason for revert: Breaks build:
https://ci.chromium.org/buildbot/chromium.linux/Fuchsia%20x64%20Cast%20Audio/4205

/b/c/b/linux/src/buildtools/linux64/gn gen //out/Release --check
  -> returned 1
ERROR at //content/common/p2p_socket_type.h:17:11: Include not allowed.
#include "third_party/webrtc/rtc_base/asyncpacketsocket.h"
          ^----------------------------------------------
It is not in any dependency of
  //content/common:common
The include file is in the target(s):
  //third_party/webrtc/rtc_base:rtc_base_generic
which should somehow be reachable.
GN gen failed: 1
step returned non-zero exit code: 1

Original change's description:
> Add traffic annotation argument to P2PHostMsg_Send.
> 
> To have proper network traffic annotation in
> P2PSocketDispatcherHost::OnSend, the argument is added to
> P2PHostMsg_Send IPC message.
> 
> Bug: 656607
> Change-Id: Ie563b8f6da7d3855013648968fa5eb36b81abf01
> Reviewed-on: https://chromium-review.googlesource.com/886482
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
> Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#534267}

TBR=sergeyu@chromium.org,tsepez@chromium.org,jochen@chromium.org,rhalavati@chromium.org

Change-Id: I057387dd72464dda10f5dad8a117b4cfef6ac30b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 656607
Reviewed-on: https://chromium-review.googlesource.com/899184
Reviewed-by: Tommi <tommi@chromium.org>
Commit-Queue: Tommi <tommi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534272}
[modify] https://crrev.com/d65f7afa38d7af6374e641f95d00593c7098d5ff/content/browser/renderer_host/p2p/socket_dispatcher_host.cc
[modify] https://crrev.com/d65f7afa38d7af6374e641f95d00593c7098d5ff/content/browser/renderer_host/p2p/socket_dispatcher_host.h
[modify] https://crrev.com/d65f7afa38d7af6374e641f95d00593c7098d5ff/content/common/p2p_messages.h
[modify] https://crrev.com/d65f7afa38d7af6374e641f95d00593c7098d5ff/content/common/p2p_socket_type.h
[modify] https://crrev.com/d65f7afa38d7af6374e641f95d00593c7098d5ff/content/renderer/p2p/socket_client_impl.cc

Project Member

Comment 270 by bugdroid1@chromium.org, Feb 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9c24de78326ac7276733deb4cbd82512b3329be

commit f9c24de78326ac7276733deb4cbd82512b3329be
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Mon Feb 05 12:05:36 2018

Add traffic annotation argument to P2PHostMsg_Send.

To have proper network traffic annotation in
P2PSocketDispatcherHost::OnSend, the argument is added to
P2PHostMsg_Send IPC message.

Bug: 656607
Change-Id: Ie91e4ddc4ec61624dd8835c0df19cfb7ca476235
Reviewed-on: https://chromium-review.googlesource.com/886482
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534267}

Relanding after revert: crrev.com/c/899184

TBR=tommi@chromium.org,sergeyu@chromium.org,tsepez@chromium.org,jochen@chromium.org

Change-Id: Ie91e4ddc4ec61624dd8835c0df19cfb7ca476235
Reviewed-on: https://chromium-review.googlesource.com/900783
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534368}
[modify] https://crrev.com/f9c24de78326ac7276733deb4cbd82512b3329be/content/browser/renderer_host/p2p/socket_dispatcher_host.cc
[modify] https://crrev.com/f9c24de78326ac7276733deb4cbd82512b3329be/content/browser/renderer_host/p2p/socket_dispatcher_host.h
[modify] https://crrev.com/f9c24de78326ac7276733deb4cbd82512b3329be/content/common/p2p_messages.h
[modify] https://crrev.com/f9c24de78326ac7276733deb4cbd82512b3329be/content/common/p2p_socket_type.h
[modify] https://crrev.com/f9c24de78326ac7276733deb4cbd82512b3329be/content/renderer/p2p/socket_client_impl.cc

Project Member

Comment 271 by bugdroid1@chromium.org, Feb 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9164cf3f2d9247b3549963b8a11ad3076325a5c1

commit 9164cf3f2d9247b3549963b8a11ad3076325a5c1
Author: Chris Pickel <sfiera@chromium.org>
Date: Mon Feb 05 13:32:52 2018

Revert "Add traffic annotation argument to P2PHostMsg_Send."

This reverts commit f9c24de78326ac7276733deb4cbd82512b3329be.

Reason for revert: causes breakage on Cast_Audio_Linux bots. Excerpt:

Writing """\
enable_webrtc = false
goma_dir = "/b/c/goma_client"
is_cast_audio_only = true
is_chromecast = true
is_component_build = false
is_debug = false
strip_absolute_paths_from_debug_symbols = true
use_goma = true
""" to /b/c/b/Cast_Audio_Linux/src/out/Release/args.gn.
/b/c/b/Cast_Audio_Linux/src/buildtools/linux64/gn gen //out/Release --check --runtime-deps-list-file=/b/c/b/Cast_Audio_Linux/src/out/Release/runtime_deps
  -> returned 1
ERROR at //content/common/p2p_socket_type.h:17:11: Include not allowed.
#include "third_party/webrtc/rtc_base/asyncpacketsocket.h"
          ^----------------------------------------------
It is not in any dependency of
  //content/common:common
The include file is in the target(s):
  //third_party/webrtc/rtc_base:rtc_base_generic
which should somehow be reachable.
GN gen failed: 1

Original change's description:
> Add traffic annotation argument to P2PHostMsg_Send.
> 
> To have proper network traffic annotation in
> P2PSocketDispatcherHost::OnSend, the argument is added to
> P2PHostMsg_Send IPC message.
> 
> Bug: 656607
> Change-Id: Ie91e4ddc4ec61624dd8835c0df19cfb7ca476235
> Reviewed-on: https://chromium-review.googlesource.com/886482
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
> Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#534267}
> 
> Relanding after revert: crrev.com/c/899184
> 
> TBR=tommi@chromium.org,sergeyu@chromium.org,tsepez@chromium.org,jochen@chromium.org
> 
> Change-Id: Ie91e4ddc4ec61624dd8835c0df19cfb7ca476235
> Reviewed-on: https://chromium-review.googlesource.com/900783
> Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
> Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#534368}

TBR=tommi@chromium.org,sergeyu@chromium.org,tsepez@chromium.org,jochen@chromium.org,rhalavati@chromium.org

Change-Id: I27a24819b09709088eeb630804a0ee4d619e0614
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 656607
Reviewed-on: https://chromium-review.googlesource.com/901325
Reviewed-by: Chris Pickel <sfiera@chromium.org>
Commit-Queue: Chris Pickel <sfiera@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534376}
[modify] https://crrev.com/9164cf3f2d9247b3549963b8a11ad3076325a5c1/content/browser/renderer_host/p2p/socket_dispatcher_host.cc
[modify] https://crrev.com/9164cf3f2d9247b3549963b8a11ad3076325a5c1/content/browser/renderer_host/p2p/socket_dispatcher_host.h
[modify] https://crrev.com/9164cf3f2d9247b3549963b8a11ad3076325a5c1/content/common/p2p_messages.h
[modify] https://crrev.com/9164cf3f2d9247b3549963b8a11ad3076325a5c1/content/common/p2p_socket_type.h
[modify] https://crrev.com/9164cf3f2d9247b3549963b8a11ad3076325a5c1/content/renderer/p2p/socket_client_impl.cc

Project Member

Comment 272 by bugdroid1@chromium.org, Feb 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a08cc8d8b4672a4d2780353d3bea3472b73fbc5

commit 0a08cc8d8b4672a4d2780353d3bea3472b73fbc5
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Tue Feb 06 07:46:38 2018

Remove Socket::Write() default traffic annotation.

Default network traffic annotation tag is removed from Socket::Write()
function, adding a temporary value to the few unannotated usages and all
test cases.

Bug: 656607
Change-Id: Ia42c4f4de8c9a3a15bb8aea40335ac0f260d4b17
Reviewed-on: https://chromium-review.googlesource.com/899082
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534653}
[modify] https://crrev.com/0a08cc8d8b4672a4d2780353d3bea3472b73fbc5/chrome/browser/devtools/device/adb/mock_adb_server.cc
[modify] https://crrev.com/0a08cc8d8b4672a4d2780353d3bea3472b73fbc5/components/cast_channel/cast_socket_unittest.cc
[modify] https://crrev.com/0a08cc8d8b4672a4d2780353d3bea3472b73fbc5/net/quic/chromium/quic_chromium_packet_writer.cc
[modify] https://crrev.com/0a08cc8d8b4672a4d2780353d3bea3472b73fbc5/net/server/http_server.cc
[modify] https://crrev.com/0a08cc8d8b4672a4d2780353d3bea3472b73fbc5/net/socket/client_socket_pool_base_unittest.cc
[modify] https://crrev.com/0a08cc8d8b4672a4d2780353d3bea3472b73fbc5/net/socket/sequenced_socket_data_unittest.cc
[modify] https://crrev.com/0a08cc8d8b4672a4d2780353d3bea3472b73fbc5/net/socket/socket.h
[modify] https://crrev.com/0a08cc8d8b4672a4d2780353d3bea3472b73fbc5/net/socket/socket_test_util.cc
[modify] https://crrev.com/0a08cc8d8b4672a4d2780353d3bea3472b73fbc5/net/socket/ssl_client_socket_unittest.cc
[modify] https://crrev.com/0a08cc8d8b4672a4d2780353d3bea3472b73fbc5/net/socket/ssl_server_socket_unittest.cc
[modify] https://crrev.com/0a08cc8d8b4672a4d2780353d3bea3472b73fbc5/net/socket/tcp_server_socket_unittest.cc
[modify] https://crrev.com/0a08cc8d8b4672a4d2780353d3bea3472b73fbc5/net/socket/transport_client_socket_unittest.cc
[modify] https://crrev.com/0a08cc8d8b4672a4d2780353d3bea3472b73fbc5/net/socket/unix_domain_client_socket_posix_unittest.cc
[modify] https://crrev.com/0a08cc8d8b4672a4d2780353d3bea3472b73fbc5/net/spdy/chromium/spdy_session.cc
[modify] https://crrev.com/0a08cc8d8b4672a4d2780353d3bea3472b73fbc5/net/test/embedded_test_server/http_connection.cc
[modify] https://crrev.com/0a08cc8d8b4672a4d2780353d3bea3472b73fbc5/net/test/tcp_socket_proxy.cc
[modify] https://crrev.com/0a08cc8d8b4672a4d2780353d3bea3472b73fbc5/net/test/tcp_socket_proxy_unittest.cc
[modify] https://crrev.com/0a08cc8d8b4672a4d2780353d3bea3472b73fbc5/remoting/host/security_key/security_key_socket.cc

Project Member

Comment 273 by bugdroid1@chromium.org, Feb 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90aa08ba88304c3ba76030ea92649b5a0ecc3a36

commit 90aa08ba88304c3ba76030ea92649b5a0ecc3a36
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Wed Feb 07 06:16:16 2018

Add traffic annotation to HttpServer send functions.

Network traffic annotation tag is added to the Send functions of
HttpServer class.

Bug: 656607
Change-Id: I2951b4b120714f8b3522dfe5d73b128ef294f01c
Reviewed-on: https://chromium-review.googlesource.com/898985
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Jonathon Kereliuk <kereliuk@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534932}
[modify] https://crrev.com/90aa08ba88304c3ba76030ea92649b5a0ecc3a36/chrome/test/chromedriver/net/net_util_unittest.cc
[modify] https://crrev.com/90aa08ba88304c3ba76030ea92649b5a0ecc3a36/chrome/test/chromedriver/net/test_http_server.cc
[modify] https://crrev.com/90aa08ba88304c3ba76030ea92649b5a0ecc3a36/chrome/test/chromedriver/server/chromedriver_server.cc
[modify] https://crrev.com/90aa08ba88304c3ba76030ea92649b5a0ecc3a36/components/ui_devtools/devtools_server.cc
[modify] https://crrev.com/90aa08ba88304c3ba76030ea92649b5a0ecc3a36/content/browser/devtools/devtools_http_handler.cc
[modify] https://crrev.com/90aa08ba88304c3ba76030ea92649b5a0ecc3a36/net/server/http_server.cc
[modify] https://crrev.com/90aa08ba88304c3ba76030ea92649b5a0ecc3a36/net/server/http_server.h
[modify] https://crrev.com/90aa08ba88304c3ba76030ea92649b5a0ecc3a36/net/server/http_server_fuzzer.cc
[modify] https://crrev.com/90aa08ba88304c3ba76030ea92649b5a0ecc3a36/net/server/http_server_unittest.cc
[modify] https://crrev.com/90aa08ba88304c3ba76030ea92649b5a0ecc3a36/net/server/web_socket.cc
[modify] https://crrev.com/90aa08ba88304c3ba76030ea92649b5a0ecc3a36/net/server/web_socket.h

Project Member

Comment 274 by bugdroid1@chromium.org, Feb 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5e433e66607b7308400285f49895912c96f588d

commit b5e433e66607b7308400285f49895912c96f588d
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Wed Feb 07 07:41:10 2018

Add traffic annotation to HttpRequestInfo.

Network traffic annotation tag is added to HttpRequestInfo.
Usages that send a request to HttpNetworkTransaction::Start() are
updated to have a valid tag.

Bug: 656607
Change-Id: I1cdd0c7c3e1a280461d65c2e69aa72d379a652b0
Reviewed-on: https://chromium-review.googlesource.com/891228
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534945}
[modify] https://crrev.com/b5e433e66607b7308400285f49895912c96f588d/net/http/http_network_layer_unittest.cc
[modify] https://crrev.com/b5e433e66607b7308400285f49895912c96f588d/net/http/http_network_transaction.cc
[modify] https://crrev.com/b5e433e66607b7308400285f49895912c96f588d/net/http/http_network_transaction_ssl_unittest.cc
[modify] https://crrev.com/b5e433e66607b7308400285f49895912c96f588d/net/http/http_network_transaction_unittest.cc
[modify] https://crrev.com/b5e433e66607b7308400285f49895912c96f588d/net/http/http_request_info.h
[modify] https://crrev.com/b5e433e66607b7308400285f49895912c96f588d/net/quic/chromium/quic_end_to_end_unittest.cc
[modify] https://crrev.com/b5e433e66607b7308400285f49895912c96f588d/net/quic/chromium/quic_network_transaction_unittest.cc
[modify] https://crrev.com/b5e433e66607b7308400285f49895912c96f588d/net/spdy/chromium/spdy_network_transaction_unittest.cc
[modify] https://crrev.com/b5e433e66607b7308400285f49895912c96f588d/net/traffic_annotation/network_traffic_annotation.h
[modify] https://crrev.com/b5e433e66607b7308400285f49895912c96f588d/net/url_request/url_request_ftp_job.cc
[modify] https://crrev.com/b5e433e66607b7308400285f49895912c96f588d/net/url_request/url_request_http_job.cc

Project Member

Comment 275 by bugdroid1@chromium.org, Feb 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4aaa3f5c51b5ff2a887bf0f77654b7be014ff552

commit 4aaa3f5c51b5ff2a887bf0f77654b7be014ff552
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Wed Feb 07 07:41:50 2018

Add traffic annotation argument to P2PHostMsg_Send.

To have proper network traffic annotation in
P2PSocketDispatcherHost::OnSend, the argument is added to
P2PHostMsg_Send IPC message.
The following files are moved under the 'enable_webrtc' build_flag:
content/common/p2p_socket_type.h
content/renderer/p2p/socket_client.h
content/renderer/p2p/socket_client_delegate.h

Bug: 656607
Change-Id: I0c3ca8a6eb692f69bcc7d94b5cbaf301a5c3beee
Reviewed-on: https://chromium-review.googlesource.com/886482
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#534267}
Reviewed-on: https://chromium-review.googlesource.com/901622
Cr-Commit-Position: refs/heads/master@{#534946}
[modify] https://crrev.com/4aaa3f5c51b5ff2a887bf0f77654b7be014ff552/content/browser/renderer_host/p2p/socket_dispatcher_host.cc
[modify] https://crrev.com/4aaa3f5c51b5ff2a887bf0f77654b7be014ff552/content/browser/renderer_host/p2p/socket_dispatcher_host.h
[modify] https://crrev.com/4aaa3f5c51b5ff2a887bf0f77654b7be014ff552/content/common/BUILD.gn
[modify] https://crrev.com/4aaa3f5c51b5ff2a887bf0f77654b7be014ff552/content/common/p2p_messages.h
[modify] https://crrev.com/4aaa3f5c51b5ff2a887bf0f77654b7be014ff552/content/common/p2p_socket_type.h
[modify] https://crrev.com/4aaa3f5c51b5ff2a887bf0f77654b7be014ff552/content/renderer/BUILD.gn
[modify] https://crrev.com/4aaa3f5c51b5ff2a887bf0f77654b7be014ff552/content/renderer/p2p/socket_client_impl.cc
[modify] https://crrev.com/4aaa3f5c51b5ff2a887bf0f77654b7be014ff552/content/renderer/render_thread_impl.cc

Project Member

Comment 276 by bugdroid1@chromium.org, Feb 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ff4ee938924989f0d4a6afee0ae52827e3b9a6a

commit 0ff4ee938924989f0d4a6afee0ae52827e3b9a6a
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Thu Feb 08 06:49:40 2018

Change mutable annotation CHECKs to DCHECK.

Mutable network traffic annotations were CHECKed when converted to non-
mutable ones to ensure that thay are initialized.
CHECKEs are converted to DCHECK to prevent unnecessary crash in the
very unlikely case that an uninitalized mutable annotation is passed.

Bug: 656607
Change-Id: I6849195184b8cd091e5fb1adbf860134d8167fae
Reviewed-on: https://chromium-review.googlesource.com/905307
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535320}
[modify] https://crrev.com/0ff4ee938924989f0d4a6afee0ae52827e3b9a6a/net/traffic_annotation/network_traffic_annotation.h

Project Member

Comment 277 by bugdroid1@chromium.org, Feb 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eba872843b76b3db423a3e987b93ee2c1fa97ccb

commit eba872843b76b3db423a3e987b93ee2c1fa97ccb
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Fri Feb 09 14:39:15 2018

Add test traffic annotation to /net tests.

Network traffic annotation of two tests in /net are updated and default
value of another is removed.

Bug: 656607
Change-Id: Icd16cf37c1f82d83be2a314209dd4887e003caf5
Reviewed-on: https://chromium-review.googlesource.com/910908
Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535706}
[modify] https://crrev.com/eba872843b76b3db423a3e987b93ee2c1fa97ccb/net/socket/socket_test_util.h
[modify] https://crrev.com/eba872843b76b3db423a3e987b93ee2c1fa97ccb/net/test/embedded_test_server/http_connection.cc
[modify] https://crrev.com/eba872843b76b3db423a3e987b93ee2c1fa97ccb/net/test/tcp_socket_proxy.cc

Project Member

Comment 278 by bugdroid1@chromium.org, Feb 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2650f366f5253df98d05c30ac452550529ec30b6

commit 2650f366f5253df98d05c30ac452550529ec30b6
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Mon Feb 12 06:30:25 2018

Update annotations.xml policy fields.

Update annotations.xml policy fields to match field numbers in
traffic_annotation.proto.

Bug:656607
Change-Id: Iba28b3090b9a65f06f505551812a77429801b43c

TBR=msramek@chromium.org

Change-Id: Iba28b3090b9a65f06f505551812a77429801b43c
Reviewed-on: https://chromium-review.googlesource.com/911549
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536034}
[modify] https://crrev.com/2650f366f5253df98d05c30ac452550529ec30b6/tools/traffic_annotation/summary/annotations.xml

Project Member

Comment 279 by bugdroid1@chromium.org, Feb 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/758319976d0e21ad1272b174b49097364bf2bc5b

commit 758319976d0e21ad1272b174b49097364bf2bc5b
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Tue Feb 13 09:49:48 2018

Add trafic annotation to Devtools.

Network traffic annotation is added to socket writes of:
components/ui_devtools/devtools_server.cc
content/browser/devtools/devtools_http_handler.cc

Bug: 656607
Change-Id: I52d8b1ab769bc3beb482dd58e96146d8380d37b4
Reviewed-on: https://chromium-review.googlesource.com/910909
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536318}
[modify] https://crrev.com/758319976d0e21ad1272b174b49097364bf2bc5b/components/ui_devtools/devtools_server.cc
[modify] https://crrev.com/758319976d0e21ad1272b174b49097364bf2bc5b/content/browser/devtools/devtools_http_handler.cc
[modify] https://crrev.com/758319976d0e21ad1272b174b49097364bf2bc5b/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/758319976d0e21ad1272b174b49097364bf2bc5b/tools/traffic_annotation/summary/annotations.xml

Project Member

Comment 280 by bugdroid1@chromium.org, Feb 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52f11054087c42183f9b3d83ce4c7ca5d0875034

commit 52f11054087c42183f9b3d83ce4c7ca5d0875034
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Wed Feb 14 07:55:10 2018

Add traffic annotation to CastChannelSendFunction::AsyncWorkStart().

Network traffic annotation is added to
CastChannelSendFunction::AsyncWorkStart().

Bug: 656607
Change-Id: I586c029890d07d922f159db10fbec27bc4d549b4
Reviewed-on: https://chromium-review.googlesource.com/911388
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536671}
[modify] https://crrev.com/52f11054087c42183f9b3d83ce4c7ca5d0875034/extensions/browser/api/cast_channel/cast_channel_api.cc
[modify] https://crrev.com/52f11054087c42183f9b3d83ce4c7ca5d0875034/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/52f11054087c42183f9b3d83ce4c7ca5d0875034/tools/traffic_annotation/summary/annotations.xml

Project Member

Comment 281 by bugdroid1@chromium.org, Feb 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e2c51a1f8db1baf69e97944a9023db593647204

commit 9e2c51a1f8db1baf69e97944a9023db593647204
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Wed Feb 14 07:56:20 2018

Pass annotation in HttpBasicStream::SendRequest().

Network traffic annotation that is received in HttpRequestInfo in
HttpBasicStream::InitializeStream is stored and passed in
HttpBasicStream::SendRequest.

Bug: 656607
Change-Id: I376032e31f6a4b22a45f099944990f15fcbb53c9
Reviewed-on: https://chromium-review.googlesource.com/911668
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536672}
[modify] https://crrev.com/9e2c51a1f8db1baf69e97944a9023db593647204/net/http/http_basic_state.cc
[modify] https://crrev.com/9e2c51a1f8db1baf69e97944a9023db593647204/net/http/http_basic_state.h
[modify] https://crrev.com/9e2c51a1f8db1baf69e97944a9023db593647204/net/http/http_basic_state_unittest.cc
[modify] https://crrev.com/9e2c51a1f8db1baf69e97944a9023db593647204/net/http/http_basic_stream.cc

Project Member

Comment 282 by bugdroid1@chromium.org, Feb 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c344804e9a9a0782e73aa5a3490a37730700489

commit 6c344804e9a9a0782e73aa5a3490a37730700489
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Wed Feb 14 07:57:24 2018

Add traffic annotation to HttpServer::HandleReadRequest().

Network traffic annotation is added to the handle read request of
HttpServer.

Bug: 656607
Change-Id: Ideecf50bcbb740efcb0a75b449c042d9c17e16e4
Reviewed-on: https://chromium-review.googlesource.com/910888
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536674}
[modify] https://crrev.com/6c344804e9a9a0782e73aa5a3490a37730700489/net/server/http_server.cc
[modify] https://crrev.com/6c344804e9a9a0782e73aa5a3490a37730700489/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/6c344804e9a9a0782e73aa5a3490a37730700489/tools/traffic_annotation/summary/annotations.xml

Project Member

Comment 283 by bugdroid1@chromium.org, Feb 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/683bcaa938173f9d6bfd3506fc9dd895c91f9a39

commit 683bcaa938173f9d6bfd3506fc9dd895c91f9a39
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Wed Feb 14 08:42:39 2018

Add traffic annotation to QuicChromiumClientStream constructor.

Network traffic annotation is added to the
QuicChromiumClientStream::QuicChromiumClientStream().


Bug: 656607
Change-Id: Ic425332ec2219595d0de49a5921c72333eef5e21
Reviewed-on: https://chromium-review.googlesource.com/911029
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536680}
[modify] https://crrev.com/683bcaa938173f9d6bfd3506fc9dd895c91f9a39/net/http/http_network_transaction.cc
[modify] https://crrev.com/683bcaa938173f9d6bfd3506fc9dd895c91f9a39/net/http/http_proxy_client_socket_wrapper.cc
[modify] https://crrev.com/683bcaa938173f9d6bfd3506fc9dd895c91f9a39/net/quic/chromium/bidirectional_stream_quic_impl.cc
[modify] https://crrev.com/683bcaa938173f9d6bfd3506fc9dd895c91f9a39/net/quic/chromium/quic_chromium_client_session.cc
[modify] https://crrev.com/683bcaa938173f9d6bfd3506fc9dd895c91f9a39/net/quic/chromium/quic_chromium_client_session.h
[modify] https://crrev.com/683bcaa938173f9d6bfd3506fc9dd895c91f9a39/net/quic/chromium/quic_chromium_client_session_test.cc
[modify] https://crrev.com/683bcaa938173f9d6bfd3506fc9dd895c91f9a39/net/quic/chromium/quic_chromium_client_stream.cc
[modify] https://crrev.com/683bcaa938173f9d6bfd3506fc9dd895c91f9a39/net/quic/chromium/quic_chromium_client_stream.h
[modify] https://crrev.com/683bcaa938173f9d6bfd3506fc9dd895c91f9a39/net/quic/chromium/quic_chromium_client_stream_test.cc
[modify] https://crrev.com/683bcaa938173f9d6bfd3506fc9dd895c91f9a39/net/quic/chromium/quic_http_stream.cc
[modify] https://crrev.com/683bcaa938173f9d6bfd3506fc9dd895c91f9a39/net/quic/chromium/quic_http_stream_test.cc
[modify] https://crrev.com/683bcaa938173f9d6bfd3506fc9dd895c91f9a39/net/quic/chromium/quic_proxy_client_socket_unittest.cc
[modify] https://crrev.com/683bcaa938173f9d6bfd3506fc9dd895c91f9a39/net/quic/chromium/quic_stream_factory_test.cc

Project Member

Comment 284 by bugdroid1@chromium.org, Feb 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20e949fae9117956bba1d5e3552175e56d640df7

commit 20e949fae9117956bba1d5e3552175e56d640df7
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Wed Feb 14 20:14:32 2018

Add traffic annotation to WebSocketBasicHandshakeStream.

Network traffic annotation which is received in stream initialization
via request_info, is passed to the SendRequest function of
WebSocketBasicHandshakeStream.

Bug: 656607
Change-Id: Ie0d01c9ee2b87947c6dd571c217e9ef8244d7168
Reviewed-on: https://chromium-review.googlesource.com/918862
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536794}
[modify] https://crrev.com/20e949fae9117956bba1d5e3552175e56d640df7/net/websockets/websocket_basic_handshake_stream.cc
[modify] https://crrev.com/20e949fae9117956bba1d5e3552175e56d640df7/net/websockets/websocket_handshake_stream_create_helper_test.cc

Project Member

Comment 285 by bugdroid1@chromium.org, Feb 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a621c1f3a6f598aa862692f7e1cf935ba424c353

commit a621c1f3a6f598aa862692f7e1cf935ba424c353
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Wed Feb 14 20:50:46 2018

Add more traffic annotation to remoting.

Network traffic annotation is added to:
remoting/host/security_key/security_key_socket.cc
remoting/protocol/stream_message_pipe_adapter.cc
remoting/protocol/connection_tester.cc
remoting/signaling/xmpp_signal_strategy.cc

Bug: 656607
Change-Id: I69c131096eda3ee5da06169defafed277a9afb26
Reviewed-on: https://chromium-review.googlesource.com/916061
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536809}
[modify] https://crrev.com/a621c1f3a6f598aa862692f7e1cf935ba424c353/remoting/host/security_key/security_key_socket.cc
[modify] https://crrev.com/a621c1f3a6f598aa862692f7e1cf935ba424c353/remoting/protocol/connection_tester.cc
[modify] https://crrev.com/a621c1f3a6f598aa862692f7e1cf935ba424c353/remoting/protocol/stream_message_pipe_adapter.cc
[modify] https://crrev.com/a621c1f3a6f598aa862692f7e1cf935ba424c353/remoting/signaling/xmpp_signal_strategy.cc
[modify] https://crrev.com/a621c1f3a6f598aa862692f7e1cf935ba424c353/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/a621c1f3a6f598aa862692f7e1cf935ba424c353/tools/traffic_annotation/summary/annotations.xml

Project Member

Comment 286 by bugdroid1@chromium.org, Feb 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/825b0dddc9bb9e4cf70c2bf160b077db4427b932

commit 825b0dddc9bb9e4cf70c2bf160b077db4427b932
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Fri Feb 16 08:08:08 2018

Add traffic annotation to GCM Connection Factory.

Network traffic annotation is added to:
google_apis/gcm/engine/connection_factory_impl.cc

Bug: 656607
Change-Id: Ibc0d1cc04607b67100d9922c27b867db2761c633
Reviewed-on: https://chromium-review.googlesource.com/916001
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537254}
[modify] https://crrev.com/825b0dddc9bb9e4cf70c2bf160b077db4427b932/google_apis/gcm/engine/connection_factory_impl.cc
[modify] https://crrev.com/825b0dddc9bb9e4cf70c2bf160b077db4427b932/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/825b0dddc9bb9e4cf70c2bf160b077db4427b932/tools/traffic_annotation/summary/annotations.xml

Project Member

Comment 287 by bugdroid1@chromium.org, Feb 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b93eb87f0509620ba7d9323ae228f2039f6fe4e6

commit b93eb87f0509620ba7d9323ae228f2039f6fe4e6
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Mon Feb 19 14:51:14 2018

Add traffic annotation to XmppConnection.

Network traffic annotation is added to the XmppConnection socket.

Bug: 656607
Change-Id: If7eb6984fa11d94dfee575309028a07cb0a317b4
Reviewed-on: https://chromium-review.googlesource.com/919782
Reviewed-by: Nicolas Zea <zea@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537651}
[modify] https://crrev.com/b93eb87f0509620ba7d9323ae228f2039f6fe4e6/chrome/service/cloud_print/cloud_print_proxy_backend.cc
[modify] https://crrev.com/b93eb87f0509620ba7d9323ae228f2039f6fe4e6/components/invalidation/impl/p2p_invalidator.cc
[modify] https://crrev.com/b93eb87f0509620ba7d9323ae228f2039f6fe4e6/components/invalidation/impl/push_client_channel.cc
[modify] https://crrev.com/b93eb87f0509620ba7d9323ae228f2039f6fe4e6/jingle/notifier/base/xmpp_connection.cc
[modify] https://crrev.com/b93eb87f0509620ba7d9323ae228f2039f6fe4e6/jingle/notifier/base/xmpp_connection.h
[modify] https://crrev.com/b93eb87f0509620ba7d9323ae228f2039f6fe4e6/jingle/notifier/base/xmpp_connection_unittest.cc
[modify] https://crrev.com/b93eb87f0509620ba7d9323ae228f2039f6fe4e6/jingle/notifier/communicator/login.cc
[modify] https://crrev.com/b93eb87f0509620ba7d9323ae228f2039f6fe4e6/jingle/notifier/communicator/login.h
[modify] https://crrev.com/b93eb87f0509620ba7d9323ae228f2039f6fe4e6/jingle/notifier/communicator/login_settings.cc
[modify] https://crrev.com/b93eb87f0509620ba7d9323ae228f2039f6fe4e6/jingle/notifier/communicator/login_settings.h
[modify] https://crrev.com/b93eb87f0509620ba7d9323ae228f2039f6fe4e6/jingle/notifier/communicator/login_settings_unittest.cc
[modify] https://crrev.com/b93eb87f0509620ba7d9323ae228f2039f6fe4e6/jingle/notifier/communicator/single_login_attempt.cc
[modify] https://crrev.com/b93eb87f0509620ba7d9323ae228f2039f6fe4e6/jingle/notifier/communicator/single_login_attempt_unittest.cc
[modify] https://crrev.com/b93eb87f0509620ba7d9323ae228f2039f6fe4e6/jingle/notifier/listener/fake_push_client.cc
[modify] https://crrev.com/b93eb87f0509620ba7d9323ae228f2039f6fe4e6/jingle/notifier/listener/fake_push_client.h
[modify] https://crrev.com/b93eb87f0509620ba7d9323ae228f2039f6fe4e6/jingle/notifier/listener/non_blocking_push_client.cc
[modify] https://crrev.com/b93eb87f0509620ba7d9323ae228f2039f6fe4e6/jingle/notifier/listener/non_blocking_push_client.h
[modify] https://crrev.com/b93eb87f0509620ba7d9323ae228f2039f6fe4e6/jingle/notifier/listener/non_blocking_push_client_unittest.cc
[modify] https://crrev.com/b93eb87f0509620ba7d9323ae228f2039f6fe4e6/jingle/notifier/listener/push_client.h
[modify] https://crrev.com/b93eb87f0509620ba7d9323ae228f2039f6fe4e6/jingle/notifier/listener/xmpp_push_client.cc
[modify] https://crrev.com/b93eb87f0509620ba7d9323ae228f2039f6fe4e6/jingle/notifier/listener/xmpp_push_client.h

Project Member

Comment 288 by bugdroid1@chromium.org, Feb 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cfe989ca086e5f4961878fdb6f6408f14af84cde

commit cfe989ca086e5f4961878fdb6f6408f14af84cde
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Thu Feb 22 07:18:07 2018

Add network traffic annotation to P2PSocketClientImpl.

P2PSocketClientImpl required a network traffic annotation to send the
packet. The annotation argument is added to its constructor and is
passed to it by IpcPacketSocketFactory.

Bug: 656607
Change-Id: I62dbe6cfa4678c4cee30aed385cab7e56a1be4fb
Reviewed-on: https://chromium-review.googlesource.com/924196
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538370}
[modify] https://crrev.com/cfe989ca086e5f4961878fdb6f6408f14af84cde/content/renderer/media/webrtc/peer_connection_dependency_factory.cc
[modify] https://crrev.com/cfe989ca086e5f4961878fdb6f6408f14af84cde/content/renderer/p2p/ipc_socket_factory.cc
[modify] https://crrev.com/cfe989ca086e5f4961878fdb6f6408f14af84cde/content/renderer/p2p/ipc_socket_factory.h
[modify] https://crrev.com/cfe989ca086e5f4961878fdb6f6408f14af84cde/content/renderer/p2p/socket_client_impl.cc
[modify] https://crrev.com/cfe989ca086e5f4961878fdb6f6408f14af84cde/content/renderer/p2p/socket_client_impl.h

Project Member

Comment 289 by bugdroid1@chromium.org, Feb 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7788eaf72ffde795b7cb28298cbfb1be172c14d

commit f7788eaf72ffde795b7cb28298cbfb1be172c14d
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Mon Feb 26 07:02:57 2018

Mark QuicChromiumClientStream::CreateOutgoingDynamicStream unreachable.

QuicChromiumClientSession::CreateOutgoingDynamicStream() implementation
is replaced with NOTREACHED, and moved to a new function for testing
purposes only.

Bug: 656607
Change-Id: Idfcf2f96de59fd57d61395c142f6e60dec677e26
Reviewed-on: https://chromium-review.googlesource.com/934285
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539082}
[modify] https://crrev.com/f7788eaf72ffde795b7cb28298cbfb1be172c14d/net/quic/chromium/quic_chromium_client_session.cc
[modify] https://crrev.com/f7788eaf72ffde795b7cb28298cbfb1be172c14d/net/quic/chromium/quic_chromium_client_session_peer.cc
[modify] https://crrev.com/f7788eaf72ffde795b7cb28298cbfb1be172c14d/net/quic/chromium/quic_chromium_client_session_peer.h
[modify] https://crrev.com/f7788eaf72ffde795b7cb28298cbfb1be172c14d/net/quic/chromium/quic_chromium_client_session_test.cc

Project Member

Comment 290 by bugdroid1@chromium.org, Feb 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c2160d7299a1789926d8414e12f98b05383158c

commit 7c2160d7299a1789926d8414e12f98b05383158c
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Wed Feb 28 05:08:40 2018

Add traffic annotation to QuicChromiumClientSession.

Network traffic annotation is added to:
QuicChromiumClientSession::CreateIncomingDynamicStream.

Bug: 656607
Change-Id: I307300c5ec33197bb7e29a40187234dcf82b7b94
Reviewed-on: https://chromium-review.googlesource.com/934182
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539716}
[modify] https://crrev.com/7c2160d7299a1789926d8414e12f98b05383158c/net/quic/chromium/quic_chromium_client_session.cc
[modify] https://crrev.com/7c2160d7299a1789926d8414e12f98b05383158c/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/7c2160d7299a1789926d8414e12f98b05383158c/tools/traffic_annotation/summary/annotations.xml

Project Member

Comment 291 by bugdroid1@chromium.org, Feb 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49f22300f27945e0294e02d0fd23e88c2d0e35f5

commit 49f22300f27945e0294e02d0fd23e88c2d0e35f5
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Wed Feb 28 08:07:17 2018

Add network traffic annotation to QuicChromiumPacketWriter.

Network traffic annotation tag is added to:
QuicChromiumPacketWriter::WritePacketToSocketImpl()

Bug: 656607
Change-Id: I97a40e772f70a23fc2503fe5a9dc3e62cc14d963
Reviewed-on: https://chromium-review.googlesource.com/934129
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539753}
[modify] https://crrev.com/49f22300f27945e0294e02d0fd23e88c2d0e35f5/net/quic/chromium/quic_chromium_packet_writer.cc
[modify] https://crrev.com/49f22300f27945e0294e02d0fd23e88c2d0e35f5/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/49f22300f27945e0294e02d0fd23e88c2d0e35f5/tools/traffic_annotation/summary/annotations.xml

Project Member

Comment 292 by bugdroid1@chromium.org, Feb 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ead4271f098dd2038ec8514f1bf9b59f83b0774b

commit ead4271f098dd2038ec8514f1bf9b59f83b0774b
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Wed Feb 28 18:41:27 2018

Add traffic annotation to required arguments to SpdyStream.

Network traffic annotation tag is added to
SpdyStreamRequest::StartRequest and is kept with the stream for all
subsequent socket writes.

Bug: 656607
Change-Id: Id106621ec54af003d174ea875564b049bc8f0e4a
Reviewed-on: https://chromium-review.googlesource.com/936481
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539902}
[modify] https://crrev.com/ead4271f098dd2038ec8514f1bf9b59f83b0774b/net/http/http_proxy_client_socket_wrapper.cc
[modify] https://crrev.com/ead4271f098dd2038ec8514f1bf9b59f83b0774b/net/spdy/chromium/bidirectional_stream_spdy_impl.cc
[modify] https://crrev.com/ead4271f098dd2038ec8514f1bf9b59f83b0774b/net/spdy/chromium/spdy_http_stream.cc
[modify] https://crrev.com/ead4271f098dd2038ec8514f1bf9b59f83b0774b/net/spdy/chromium/spdy_session.cc
[modify] https://crrev.com/ead4271f098dd2038ec8514f1bf9b59f83b0774b/net/spdy/chromium/spdy_session.h
[modify] https://crrev.com/ead4271f098dd2038ec8514f1bf9b59f83b0774b/net/spdy/chromium/spdy_session_fuzzer.cc
[modify] https://crrev.com/ead4271f098dd2038ec8514f1bf9b59f83b0774b/net/spdy/chromium/spdy_session_unittest.cc
[modify] https://crrev.com/ead4271f098dd2038ec8514f1bf9b59f83b0774b/net/spdy/chromium/spdy_stream.cc
[modify] https://crrev.com/ead4271f098dd2038ec8514f1bf9b59f83b0774b/net/spdy/chromium/spdy_stream.h
[modify] https://crrev.com/ead4271f098dd2038ec8514f1bf9b59f83b0774b/net/spdy/chromium/spdy_test_util_common.cc
[modify] https://crrev.com/ead4271f098dd2038ec8514f1bf9b59f83b0774b/net/spdy/chromium/spdy_write_queue.cc
[modify] https://crrev.com/ead4271f098dd2038ec8514f1bf9b59f83b0774b/net/spdy/chromium/spdy_write_queue.h
[modify] https://crrev.com/ead4271f098dd2038ec8514f1bf9b59f83b0774b/net/spdy/chromium/spdy_write_queue_unittest.cc
[modify] https://crrev.com/ead4271f098dd2038ec8514f1bf9b59f83b0774b/net/traffic_annotation/network_traffic_annotation.h
[modify] https://crrev.com/ead4271f098dd2038ec8514f1bf9b59f83b0774b/net/websockets/websocket_http2_handshake_stream.cc
[modify] https://crrev.com/ead4271f098dd2038ec8514f1bf9b59f83b0774b/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/ead4271f098dd2038ec8514f1bf9b59f83b0774b/tools/traffic_annotation/summary/annotations.xml

Project Member

Comment 293 by bugdroid1@chromium.org, Mar 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0e881afaa7928c49237a187be27f5e85b04b5c5

commit e0e881afaa7928c49237a187be27f5e85b04b5c5
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Thu Mar 01 13:52:28 2018

Add annotation to PeerConnectionFactory.

Network traffic annotation is added to
content/renderer/media/webrtc/peer_connection_dependency_factory.cc

Bug: 656607
Change-Id: Ie88c13b8ab6f28e7604f48d134c231b16ab18a61
Reviewed-on: https://chromium-review.googlesource.com/934127
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Taylor Brandstetter <deadbeef@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540148}
[modify] https://crrev.com/e0e881afaa7928c49237a187be27f5e85b04b5c5/content/renderer/media/webrtc/peer_connection_dependency_factory.cc
[modify] https://crrev.com/e0e881afaa7928c49237a187be27f5e85b04b5c5/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/e0e881afaa7928c49237a187be27f5e85b04b5c5/tools/traffic_annotation/summary/annotations.xml

Project Member

Comment 294 by bugdroid1@chromium.org, Mar 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1530220b8aaf3e075974d11d1a34d1970d0b3796

commit 1530220b8aaf3e075974d11d1a34d1970d0b3796
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Thu Mar 01 17:04:14 2018

Add network traffic annotation to CloudPrintProxyBackend.

Network traffic annotation is added for credential update of Cloud Print
Proxy Backend.

Bug: 656607
Change-Id: I0dab745bfa4efae24d6091f99b2ac1090d230f33
Reviewed-on: https://chromium-review.googlesource.com/926011
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Scott Byer <scottbyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540191}
[modify] https://crrev.com/1530220b8aaf3e075974d11d1a34d1970d0b3796/chrome/service/cloud_print/cloud_print_proxy_backend.cc
[modify] https://crrev.com/1530220b8aaf3e075974d11d1a34d1970d0b3796/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/1530220b8aaf3e075974d11d1a34d1970d0b3796/tools/traffic_annotation/summary/annotations.xml

Project Member

Comment 295 by bugdroid1@chromium.org, Mar 5 2018

Project Member

Comment 296 by bugdroid1@chromium.org, Mar 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/832c78b1bcd4bc4e50c5526db240facee080625f

commit 832c78b1bcd4bc4e50c5526db240facee080625f
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Thu Mar 08 07:16:23 2018

Add traffic annotation to SpdySession::TryCreatePushStream.

Local annotation is added to SpdySession::TryCreatePushStream.

Bug: 656607
Change-Id: I164d9d6df34b9f38e6077c5746a04f2e53a7061d
Reviewed-on: https://chromium-review.googlesource.com/951728
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541747}
[modify] https://crrev.com/832c78b1bcd4bc4e50c5526db240facee080625f/net/spdy/chromium/spdy_session.cc
[modify] https://crrev.com/832c78b1bcd4bc4e50c5526db240facee080625f/tools/traffic_annotation/summary/annotations.xml

Project Member

Comment 297 by bugdroid1@chromium.org, Mar 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b72d81cfcd93f313b712f5ade5ee281e4c34548

commit 7b72d81cfcd93f313b712f5ade5ee281e4c34548
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Thu Mar 08 07:29:16 2018

Add network traffic annotation to components/invalidation.

Network traffic annotation is added to two requests in:
components/invalidation/impl/p2p_invalidator.cc
components/invalidation/impl/push_client_channel.cc

Bug: 656607
Change-Id: I34b9dbc22b8d4035270f66225d2424c624bb6217
Reviewed-on: https://chromium-review.googlesource.com/926008
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541751}
[modify] https://crrev.com/7b72d81cfcd93f313b712f5ade5ee281e4c34548/components/invalidation/impl/p2p_invalidator.cc
[modify] https://crrev.com/7b72d81cfcd93f313b712f5ade5ee281e4c34548/components/invalidation/impl/push_client_channel.cc
[modify] https://crrev.com/7b72d81cfcd93f313b712f5ade5ee281e4c34548/tools/traffic_annotation/summary/annotations.xml

Project Member

Comment 298 by bugdroid1@chromium.org, Mar 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c96c6db257673bd838d2c1f30ee89e70e5fe708

commit 3c96c6db257673bd838d2c1f30ee89e70e5fe708
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Sun Mar 11 13:29:44 2018

Add Traffic Annotation to bidirectional stream.

Network traffic annotation is added to bidirectional_stream.cc and is
used to create Quic or Spdy bidirectional streams.

Bug: 656607
Change-Id: I3af2658d69940b66081429b9d970657b07cf1796
Reviewed-on: https://chromium-review.googlesource.com/952969
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542399}
[modify] https://crrev.com/3c96c6db257673bd838d2c1f30ee89e70e5fe708/net/http/bidirectional_stream.cc
[modify] https://crrev.com/3c96c6db257673bd838d2c1f30ee89e70e5fe708/net/http/bidirectional_stream_impl.h
[modify] https://crrev.com/3c96c6db257673bd838d2c1f30ee89e70e5fe708/net/http/http_stream_factory_impl_unittest.cc
[modify] https://crrev.com/3c96c6db257673bd838d2c1f30ee89e70e5fe708/net/quic/chromium/bidirectional_stream_quic_impl.cc
[modify] https://crrev.com/3c96c6db257673bd838d2c1f30ee89e70e5fe708/net/quic/chromium/bidirectional_stream_quic_impl.h
[modify] https://crrev.com/3c96c6db257673bd838d2c1f30ee89e70e5fe708/net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc
[modify] https://crrev.com/3c96c6db257673bd838d2c1f30ee89e70e5fe708/net/spdy/chromium/bidirectional_stream_spdy_impl.cc
[modify] https://crrev.com/3c96c6db257673bd838d2c1f30ee89e70e5fe708/net/spdy/chromium/bidirectional_stream_spdy_impl.h
[modify] https://crrev.com/3c96c6db257673bd838d2c1f30ee89e70e5fe708/net/spdy/chromium/bidirectional_stream_spdy_impl_unittest.cc
[modify] https://crrev.com/3c96c6db257673bd838d2c1f30ee89e70e5fe708/tools/traffic_annotation/summary/annotations.xml

Project Member

Comment 299 by bugdroid1@chromium.org, Mar 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363

commit ca8d525d49c7f122c84ec4531bdc6ef2d8aae363
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Mon Mar 12 05:33:49 2018

Replace ProxyConfigSource with ProxyConfigWithAnnotation.

ProxyConfigSource is removed and ProxyConfigWithAnnotation class is
added to wrap a constant ProxyConfig and its NetworkTrafficAnnotation.
To goal is to provide an annotation wherever a ProxyConfig is modified,
so that the source of configs for proxies and their changes would be
traceable and transparent.

Bug: 656607
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I64f0eaad8f37682da4571b4a9aae69d974ce584d
Reviewed-on: https://chromium-review.googlesource.com/934126
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542426}
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/android_webview/browser/net/aw_url_request_context_getter.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/chrome/browser/chromeos/arc/intent_helper/arc_settings_service.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/chrome/browser/chromeos/proxy_config_service_impl_unittest.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/chrome/browser/net/predictor_unittest.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/chrome/browser/net/proxy_config_monitor.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/chrome/browser/net/proxy_config_monitor.h
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/chrome/browser/prefs/chrome_command_line_pref_store_proxy_unittest.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/chrome/test/chromedriver/net/url_request_context_getter.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/chromeos/dbus/services/proxy_resolution_service_provider_unittest.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/chromeos/network/proxy/proxy_config_service_impl.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/chromeos/network/proxy/proxy_config_service_impl.h
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/chromeos/network/proxy/proxy_config_service_impl_unittest.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/chromeos/network/proxy/ui_proxy_config_service.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/components/cronet/stale_host_resolver_unittest.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/components/cronet/url_request_context_config_unittest.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/components/proxy_config/BUILD.gn
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/components/proxy_config/pref_proxy_config_tracker_impl.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/components/proxy_config/pref_proxy_config_tracker_impl.h
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/components/proxy_config/pref_proxy_config_tracker_impl_unittest.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/content/browser/resolve_proxy_msg_helper_unittest.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/content/test/proxy_service_mojo_unittest.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/content/test/url_request_context_builder_mojo_unittest.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/headless/lib/browser/headless_url_request_context_getter.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/ios/web/shell/shell_url_request_context_getter.mm
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/ios/web_view/internal/web_view_url_request_context_getter.mm
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/BUILD.gn
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/cert_net/cert_net_fetcher_impl_unittest.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/http/http_network_transaction_unittest.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/http/http_stream_factory_impl_job_controller_unittest.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/http/http_stream_factory_impl_unittest.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/log/net_log_util.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/network_error_logging/network_error_logging_end_to_end_test.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/proxy_resolution/pac_file_decider.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/proxy_resolution/pac_file_decider.h
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/proxy_resolution/pac_file_decider_unittest.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/proxy_resolution/pac_file_fetcher_impl_unittest.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/proxy_resolution/polling_proxy_config_service.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/proxy_resolution/polling_proxy_config_service.h
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/proxy_resolution/proxy_config.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/proxy_resolution/proxy_config.h
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/proxy_resolution/proxy_config_service.h
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/proxy_resolution/proxy_config_service_android.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/proxy_resolution/proxy_config_service_android.h
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/proxy_resolution/proxy_config_service_android_unittest.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/proxy_resolution/proxy_config_service_fixed.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/proxy_resolution/proxy_config_service_fixed.h
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/proxy_resolution/proxy_config_service_ios.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/proxy_resolution/proxy_config_service_ios.h
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/proxy_resolution/proxy_config_service_linux.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/proxy_resolution/proxy_config_service_linux.h
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/proxy_resolution/proxy_config_service_linux_unittest.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/proxy_resolution/proxy_config_service_mac.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/proxy_resolution/proxy_config_service_mac.h
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/proxy_resolution/proxy_config_service_win.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/proxy_resolution/proxy_config_service_win.h
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/proxy_resolution/proxy_config_service_win_unittest.cc
[delete] https://crrev.com/75b56e53721c0ee6ee1f1854ad6ee4449540e4de/net/proxy_resolution/proxy_config_source.cc
[delete] https://crrev.com/75b56e53721c0ee6ee1f1854ad6ee4449540e4de/net/proxy_resolution/proxy_config_source.h
[add] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/proxy_resolution/proxy_config_with_annotation.cc
[add] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/proxy_resolution/proxy_config_with_annotation.h
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/proxy_resolution/proxy_info.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/proxy_resolution/proxy_info.h
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/proxy_resolution/proxy_resolution_service.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/proxy_resolution/proxy_resolution_service.h
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/proxy_resolution/proxy_resolution_service_unittest.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/quic/chromium/quic_network_transaction_unittest.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/socket/client_socket_pool_manager.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/spdy/chromium/spdy_network_transaction_unittest.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/tools/cert_verify_tool/cert_verify_tool.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/tools/net_watcher/net_watcher.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/url_request/url_fetcher_impl_unittest.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/url_request/url_request_context_builder_unittest.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/url_request/url_request_context_unittest.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/url_request/url_request_ftp_job_unittest.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/url_request/url_request_http_job_unittest.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/url_request/url_request_unittest.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/websockets/websocket_end_to_end_test.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/net/websockets/websocket_test_util.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/services/network/http_cache_data_remover_unittest.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/services/network/network_context.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/services/network/network_context_unittest.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/services/network/network_service_unittest.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/services/network/proxy_config_service_mojo.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/services/network/proxy_config_service_mojo.h
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/services/network/proxy_config_service_mojo_unittest.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/services/network/proxy_resolving_client_socket_unittest.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/services/network/public/cpp/BUILD.gn
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/services/network/public/cpp/proxy_config.typemap
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/services/network/public/cpp/proxy_config_mojom_traits.cc
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/services/network/public/cpp/proxy_config_mojom_traits.h
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/services/network/public/cpp/proxy_config_mojom_traits_unittest.cc
[add] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/services/network/public/cpp/proxy_config_with_annotation.typemap
[add] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/services/network/public/cpp/proxy_config_with_annotation_mojom_traits.cc
[add] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/services/network/public/cpp/proxy_config_with_annotation_mojom_traits.h
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/services/network/public/cpp/typemaps.gni
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/services/network/public/mojom/BUILD.gn
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/services/network/public/mojom/network_service.mojom
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/services/network/public/mojom/proxy_config.mojom
[add] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/services/network/public/mojom/proxy_config_with_annotation.mojom
[modify] https://crrev.com/ca8d525d49c7f122c84ec4531bdc6ef2d8aae363/tools/traffic_annotation/summary/annotations.xml

Project Member

Comment 300 by bugdroid1@chromium.org, Mar 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/216426eab7ef22154bfddd86a900068253caaf20

commit 216426eab7ef22154bfddd86a900068253caaf20
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Mon Mar 12 22:13:35 2018

Pass annotation to SpdyHttpStream.

Network traffic annotation is passed from HttpRequestInfo to
SpdyHttpStream.

Bug: 656607
Change-Id: I8cfc0cade93e016c3e7f497e3a06a1dbf9894494
Reviewed-on: https://chromium-review.googlesource.com/958921
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542624}
[modify] https://crrev.com/216426eab7ef22154bfddd86a900068253caaf20/net/http/http_stream_factory_impl_unittest.cc
[modify] https://crrev.com/216426eab7ef22154bfddd86a900068253caaf20/net/spdy/chromium/spdy_http_stream.cc
[modify] https://crrev.com/216426eab7ef22154bfddd86a900068253caaf20/net/spdy/chromium/spdy_http_stream_unittest.cc

Project Member

Comment 301 by bugdroid1@chromium.org, Mar 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/902939721ddb13fbcb124592f707717ca221d1e7

commit 902939721ddb13fbcb124592f707717ca221d1e7
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Tue Mar 13 10:22:51 2018

Annotation added to Certificate Reporting Service.

Network traffic annotation is added to the report sent from Certificate
Reporting Service

Bug: 656607
Change-Id: Ic365fd2d21c9f38977220e74b38e70f4d2db4b9c
Reviewed-on: https://chromium-review.googlesource.com/947967
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542759}
[modify] https://crrev.com/902939721ddb13fbcb124592f707717ca221d1e7/chrome/browser/safe_browsing/certificate_reporting_service.cc
[modify] https://crrev.com/902939721ddb13fbcb124592f707717ca221d1e7/tools/traffic_annotation/summary/annotations.xml

Project Member

Comment 302 by bugdroid1@chromium.org, Mar 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/740e2747359c12e0208f21cbf48a457ebb8cfe55

commit 740e2747359c12e0208f21cbf48a457ebb8cfe55
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Tue Mar 13 11:01:26 2018

Update proxy annotations.

Network traffic annotation of direct, settings, and headless proxies
are updated.

Bug: 656607
Change-Id: I8513c05e7cda77aa62bb2cd85c90afb316996a90
Reviewed-on: https://chromium-review.googlesource.com/958504
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542766}
[modify] https://crrev.com/740e2747359c12e0208f21cbf48a457ebb8cfe55/components/proxy_config/pref_proxy_config_tracker_impl.cc
[modify] https://crrev.com/740e2747359c12e0208f21cbf48a457ebb8cfe55/headless/lib/browser/headless_url_request_context_getter.cc
[modify] https://crrev.com/740e2747359c12e0208f21cbf48a457ebb8cfe55/net/proxy_resolution/proxy_config_with_annotation.cc
[modify] https://crrev.com/740e2747359c12e0208f21cbf48a457ebb8cfe55/tools/traffic_annotation/summary/annotations.xml

Project Member

Comment 303 by bugdroid1@chromium.org, Mar 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ac4c912ef05708fec4778bf4c6e31894086bdb9

commit 5ac4c912ef05708fec4778bf4c6e31894086bdb9
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Tue Mar 13 18:52:19 2018

Add traffic annotation to Websocket HTTP2 Handshake.

Network traffic annotation is passed from HttpRequestInfo to
Websocket HTTP2 Handshake.

Bug: 656607
Change-Id: Ib8c40a734ec598346457a32d75f3e2caeb8cbad0
Reviewed-on: https://chromium-review.googlesource.com/959008
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542872}
[modify] https://crrev.com/5ac4c912ef05708fec4778bf4c6e31894086bdb9/net/websockets/websocket_http2_handshake_stream.cc

Project Member

Comment 304 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb8c4d8a4dda7309950c3cf560c2ca7c22edc5d2

commit bb8c4d8a4dda7309950c3cf560c2ca7c22edc5d2
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Fri Mar 16 08:04:31 2018

Pass network traffic annotation to PAC fetcher.

Network traffic annotation is passed from pac_file_fetcher to
pac_file_fetcher_impl, and the local annotation is removed.

Bug: 656607
Change-Id: I7446281e7b8f6c15bc21d49cc31c1ebcaa9ecba9
Reviewed-on: https://chromium-review.googlesource.com/964283
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543646}
[modify] https://crrev.com/bb8c4d8a4dda7309950c3cf560c2ca7c22edc5d2/chromeos/network/dhcp_pac_file_fetcher_chromeos.cc
[modify] https://crrev.com/bb8c4d8a4dda7309950c3cf560c2ca7c22edc5d2/chromeos/network/dhcp_pac_file_fetcher_chromeos.h
[modify] https://crrev.com/bb8c4d8a4dda7309950c3cf560c2ca7c22edc5d2/net/proxy_resolution/dhcp_pac_file_adapter_fetcher_win.cc
[modify] https://crrev.com/bb8c4d8a4dda7309950c3cf560c2ca7c22edc5d2/net/proxy_resolution/dhcp_pac_file_adapter_fetcher_win.h
[modify] https://crrev.com/bb8c4d8a4dda7309950c3cf560c2ca7c22edc5d2/net/proxy_resolution/dhcp_pac_file_adapter_fetcher_win_unittest.cc
[modify] https://crrev.com/bb8c4d8a4dda7309950c3cf560c2ca7c22edc5d2/net/proxy_resolution/dhcp_pac_file_fetcher.cc
[modify] https://crrev.com/bb8c4d8a4dda7309950c3cf560c2ca7c22edc5d2/net/proxy_resolution/dhcp_pac_file_fetcher.h
[modify] https://crrev.com/bb8c4d8a4dda7309950c3cf560c2ca7c22edc5d2/net/proxy_resolution/dhcp_pac_file_fetcher_win.cc
[modify] https://crrev.com/bb8c4d8a4dda7309950c3cf560c2ca7c22edc5d2/net/proxy_resolution/dhcp_pac_file_fetcher_win.h
[modify] https://crrev.com/bb8c4d8a4dda7309950c3cf560c2ca7c22edc5d2/net/proxy_resolution/dhcp_pac_file_fetcher_win_unittest.cc
[modify] https://crrev.com/bb8c4d8a4dda7309950c3cf560c2ca7c22edc5d2/net/proxy_resolution/mock_pac_file_fetcher.cc
[modify] https://crrev.com/bb8c4d8a4dda7309950c3cf560c2ca7c22edc5d2/net/proxy_resolution/mock_pac_file_fetcher.h
[modify] https://crrev.com/bb8c4d8a4dda7309950c3cf560c2ca7c22edc5d2/net/proxy_resolution/pac_file_decider.cc
[modify] https://crrev.com/bb8c4d8a4dda7309950c3cf560c2ca7c22edc5d2/net/proxy_resolution/pac_file_decider_unittest.cc
[modify] https://crrev.com/bb8c4d8a4dda7309950c3cf560c2ca7c22edc5d2/net/proxy_resolution/pac_file_fetcher.h
[modify] https://crrev.com/bb8c4d8a4dda7309950c3cf560c2ca7c22edc5d2/net/proxy_resolution/pac_file_fetcher_impl.cc
[modify] https://crrev.com/bb8c4d8a4dda7309950c3cf560c2ca7c22edc5d2/net/proxy_resolution/pac_file_fetcher_impl.h
[modify] https://crrev.com/bb8c4d8a4dda7309950c3cf560c2ca7c22edc5d2/net/proxy_resolution/pac_file_fetcher_impl_unittest.cc
[modify] https://crrev.com/bb8c4d8a4dda7309950c3cf560c2ca7c22edc5d2/tools/traffic_annotation/summary/annotations.xml

Project Member

Comment 305 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/921731ea1b3df56cee22f7a9268505cae56b7a90

commit 921731ea1b3df56cee22f7a9268505cae56b7a90
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Fri Mar 16 08:24:57 2018

Pass traffic annotation for HttpProxyClientSocket handshakes.

Network traffic annotation is passed from ProxyInfo to
HttpProxyClientSocket for handshake and control.

Bug: 656607
Change-Id: I74e3805b743de88ae604644629a05fe1cc738ec3
Reviewed-on: https://chromium-review.googlesource.com/960322
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543649}
[modify] https://crrev.com/921731ea1b3df56cee22f7a9268505cae56b7a90/net/base/test_proxy_delegate.cc
[modify] https://crrev.com/921731ea1b3df56cee22f7a9268505cae56b7a90/net/http/http_network_transaction_unittest.cc
[modify] https://crrev.com/921731ea1b3df56cee22f7a9268505cae56b7a90/net/http/http_proxy_client_socket.cc
[modify] https://crrev.com/921731ea1b3df56cee22f7a9268505cae56b7a90/net/http/http_proxy_client_socket.h
[modify] https://crrev.com/921731ea1b3df56cee22f7a9268505cae56b7a90/net/http/http_proxy_client_socket_fuzzer.cc
[modify] https://crrev.com/921731ea1b3df56cee22f7a9268505cae56b7a90/net/http/http_proxy_client_socket_pool.cc
[modify] https://crrev.com/921731ea1b3df56cee22f7a9268505cae56b7a90/net/http/http_proxy_client_socket_pool.h
[modify] https://crrev.com/921731ea1b3df56cee22f7a9268505cae56b7a90/net/http/http_proxy_client_socket_pool_unittest.cc
[modify] https://crrev.com/921731ea1b3df56cee22f7a9268505cae56b7a90/net/http/http_proxy_client_socket_unittest.cc
[modify] https://crrev.com/921731ea1b3df56cee22f7a9268505cae56b7a90/net/http/http_proxy_client_socket_wrapper.cc
[modify] https://crrev.com/921731ea1b3df56cee22f7a9268505cae56b7a90/net/http/http_proxy_client_socket_wrapper.h
[modify] https://crrev.com/921731ea1b3df56cee22f7a9268505cae56b7a90/net/http/http_proxy_client_socket_wrapper_unittest.cc
[modify] https://crrev.com/921731ea1b3df56cee22f7a9268505cae56b7a90/net/socket/client_socket_pool_manager.cc
[modify] https://crrev.com/921731ea1b3df56cee22f7a9268505cae56b7a90/net/socket/ssl_client_socket_pool_unittest.cc

Project Member

Comment 306 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b5b8baa3baf14eaebe56cb3642a016bcfa26e8f

commit 0b5b8baa3baf14eaebe56cb3642a016bcfa26e8f
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Fri Mar 16 10:40:53 2018

Add local annotation to ProxyResolutionService.

Adds a local annotation for system proxy configuration.

Bug: 656607
Change-Id: If4527e0d3de22db9546f9cbecfcdd00286da70e1
Reviewed-on: https://chromium-review.googlesource.com/960007
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543662}
[modify] https://crrev.com/0b5b8baa3baf14eaebe56cb3642a016bcfa26e8f/net/proxy_resolution/proxy_resolution_service.cc
[modify] https://crrev.com/0b5b8baa3baf14eaebe56cb3642a016bcfa26e8f/tools/traffic_annotation/summary/annotations.xml

Project Member

Comment 307 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b82f40b57ac6f38052b298be2cde69ac8e2ae61

commit 3b82f40b57ac6f38052b298be2cde69ac8e2ae61
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Fri Mar 16 13:50:19 2018

Update annotations.xml

A removed annotation is marked deprecated.

Bug: 656607
Change-Id: Ie0d56b6d6218cb261fd691b9e7b2eeaed9a352ab
Reviewed-on: https://chromium-review.googlesource.com/966382
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543688}
[modify] https://crrev.com/3b82f40b57ac6f38052b298be2cde69ac8e2ae61/tools/traffic_annotation/summary/annotations.xml

Project Member

Comment 308 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e91bd630d3038038491462bb28f63d701850c430

commit e91bd630d3038038491462bb28f63d701850c430
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Fri Mar 16 22:24:43 2018

Remove NO_TRAFFIC_ANNOTATION_BUG_656607 temporary annotation.

All usages of NO_TRAFFIC_ANNOTAITON_BUG_656607 temporary annotation are
replaced with actual annotations and this tag can be removed.

Bug: 656607
Change-Id: If38d15152cbaa3df79d4d9b4d8146d0ca9119a39
Reviewed-on: https://chromium-review.googlesource.com/960083
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543846}
[modify] https://crrev.com/e91bd630d3038038491462bb28f63d701850c430/net/traffic_annotation/network_traffic_annotation.h
[modify] https://crrev.com/e91bd630d3038038491462bb28f63d701850c430/tools/traffic_annotation/README.md
[modify] https://crrev.com/e91bd630d3038038491462bb28f63d701850c430/tools/traffic_annotation/auditor/instance.cc
[modify] https://crrev.com/e91bd630d3038038491462bb28f63d701850c430/tools/traffic_annotation/auditor/traffic_annotation_auditor.cc
[modify] https://crrev.com/e91bd630d3038038491462bb28f63d701850c430/tools/traffic_annotation/auditor/traffic_annotation_auditor_unittest.cc
[modify] https://crrev.com/e91bd630d3038038491462bb28f63d701850c430/tools/traffic_annotation/bin/linux64/traffic_annotation_auditor.sha1
[modify] https://crrev.com/e91bd630d3038038491462bb28f63d701850c430/tools/traffic_annotation/bin/win32/traffic_annotation_auditor.exe.sha1
[modify] https://crrev.com/e91bd630d3038038491462bb28f63d701850c430/tools/traffic_annotation/summary/annotations.xml

Status: Fixed (was: Started)
All URL Requests and socket writes are annotated, except the code that is not compiled on Linux or Windows.

ChromeOS specific code may be annotated later in another attempt by Enterprise team, and there is no current plan for other platforms or native API functions.

Closing.
Project Member

Comment 310 by bugdroid1@chromium.org, Apr 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c1526e363d30002718f75175bf5698b6946bc46

commit 6c1526e363d30002718f75175bf5698b6946bc46
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Fri Apr 06 05:44:38 2018

Update docs/network_traffic_annotations.md

Updates docs/network_traffic_annotations.md

Bug: 656607
Change-Id: Ib9381a89f0458bbb99134a976ea96fdad12a3959
Reviewed-on: https://chromium-review.googlesource.com/966222
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548687}
[modify] https://crrev.com/6c1526e363d30002718f75175bf5698b6946bc46/docs/network_traffic_annotations.md

Project Member

Comment 311 by bugdroid1@chromium.org, May 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50e82d59f1e4cfaf8c16fb8c4dc382e7c19426f0

commit 50e82d59f1e4cfaf8c16fb8c4dc382e7c19426f0
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Tue May 22 08:39:41 2018

Add script to update network traffic annotation sheet.

A new script added that receives network traffic annotations as a TSV
file, and updates a Google sheet with the given data.

Bug: 656607
Change-Id: I028dea45085ccb9192a7172475aecfbbeeb13b50
Reviewed-on: https://chromium-review.googlesource.com/842404
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560515}
[modify] https://crrev.com/50e82d59f1e4cfaf8c16fb8c4dc382e7c19426f0/tools/traffic_annotation/scripts/README.md
[add] https://crrev.com/50e82d59f1e4cfaf8c16fb8c4dc382e7c19426f0/tools/traffic_annotation/scripts/update_annotations_sheet.py

Showing comments 212 - 311 of 311 Older

Sign in to add a comment