New issue
Advanced search Search tips

Issue 656606 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 672680



Sign in to add a comment

Merge Compositor's ScrollbarAnimationControllers into single class

Project Member Reported by bokan@chromium.org, Oct 17 2016

Issue description

Currently, there exist two descendants of the ScrollbarAnimationController class in CC: ScrollbarAnimationControllerLinearFade for Android scrollbars and ScrollbarAnimationControllerThinning for Aura overlay scrollbars. The two have similar duties, the difference being the timing constants and the addition of a "thinning/expanding" animation in the latter for when the mouse moves near the scrollbars. Since so much is shared, it would make more sense to merge the two classes and make the behavior differences parameters.
 
Components: Blink>Scroll
Blocking: 672680
Owner: chaopeng@chromium.org
Status: Assigned (was: Available)
Status: Started (was: Assigned)
Status: Fixed (was: Started)
Code Review: https://bugs.chromium.org/p/chromium/issues/detail?id=656606

Comment 6 by bokan@chromium.org, Feb 21 2017

Presumably you meant: https://codereview.chromium.org/2692243005/ :)

In any case, not sure why the bot didn't paste the commit here.

Sign in to add a comment