Regression: Weird overlapping of download entries is seen at chrome://downloads.
Reported by
jshan...@etouch.net,
Oct 17 2016
|
|||||
Issue descriptionChrome Version: 56.0.2891.0 db45a537654c59feee0308a5643cff514ea6446e-refs/heads/master@{#425529} 32/64-bit OS: Windows (7,8,10), Mac (10.10.5, 10.11.4), Linux (14.04 LTS) URL: http://www.azurespeed.com/Azure/Download Steps: 1. Launch Chrome, navigate to above URL and download 7-10 files. 2. Pause each file while downloading from download shelf and navigate to chrome://downloads (7-10 entries is seen) 3. Scroll down the download page and again go back to previous tab (azurespeed.com). 4. Again download any one file, switch download tab (chrome://downloads), scroll up the page and observe. Actual: Unwanted overlapping of 'Incognito' download entry with the first entry is seen.(Also close icon of that entry is not clickable) Expected: No such overlapping of download entries should be seen. This is a regression issue broken in M-55, will soon update bisect info. Good build : 55.0.2879.0 Bad build : 55.0.2880.0
,
Oct 17 2016
Adding RB label as this is a recent regression
,
Oct 17 2016
are there script errors in the console when this happens?
,
Oct 20 2016
With response to comment #3, there are no script errors in the console. Please refer the attached screenshot. Thanks.
,
Oct 20 2016
dbeam@, could you please take a look and fix this issue as this is marked as M55 stable blocker. thank you
,
Oct 24 2016
Gentle Ping! Can we get any update on this issue as per comment #4
,
Oct 26 2016
I've dug fairly deeply into this one splices added outside of the range of iron-list's _virtualStart / _virtualEnd aren't being handled correctly so if the user scrolls down and a new download is started at the top (which is generally how the UI works), there can be issues ffu@/egarciad@: ideas?
,
Oct 26 2016
This PR should fix the issue: https://github.com/PolymerElements/iron-list/pull/339
,
Oct 26 2016
**** Bulk edit - please ignore if not applicable **** A friendly reminder that M55 Stable is launch is coming soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP so it gets enough baking time in Beta (before Stable promotion). Thank you!
,
Oct 26 2016
i don't think this is a "really needs a merge" change
,
Oct 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9ce83c55f556e739b053e6be5f0034870be47c37 commit 9ce83c55f556e739b053e6be5f0034870be47c37 Author: dbeam <dbeam@chromium.org> Date: Wed Oct 26 23:55:02 2016 MD Downloads: handle date hiding/showing more sanely Previously, items where created by accessing the physical DOM. As in: someElementItem.hideDate = true/false. But then hideDate was moved to an item's data. I accidentally left a property binding around. Additionally, changing .data.hideDate doesn't actually trigger observers in iron-list to fire as it's changing a sub-property of a complex object. So instead, use the .set() API to ensure iron-list is notified so it can update the template instance's data for the physical itmes it owns. It may be possible to test this, but: * we've had issues in the past testing multiple items in an iron-list (and this test would require at least 2 items to be useful) * you're not really supposed to use or depend on the physical items of an iron-list, which is actually what we'd need to check R=dpapad@chromium.org BUG= 656580 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2449853006 Cr-Commit-Position: refs/heads/master@{#427883} [modify] https://crrev.com/9ce83c55f556e739b053e6be5f0034870be47c37/chrome/browser/resources/md_downloads/crisper.js [modify] https://crrev.com/9ce83c55f556e739b053e6be5f0034870be47c37/chrome/browser/resources/md_downloads/manager.html [modify] https://crrev.com/9ce83c55f556e739b053e6be5f0034870be47c37/chrome/browser/resources/md_downloads/manager.js [modify] https://crrev.com/9ce83c55f556e739b053e6be5f0034870be47c37/chrome/browser/resources/md_downloads/vulcanized.html [modify] https://crrev.com/9ce83c55f556e739b053e6be5f0034870be47c37/chrome/browser/resources/md_history/app.crisper.js
,
Oct 27 2016
Tested the issue on Windows, Mac and Linux using Chrome# 56.0.2902.0 and is still reproducible. Attaching screen cast of the issue for further reference. Thank You.
,
Oct 27 2016
Forgot to update the revision of the Chrome Version: 56.0.2902.0 (Official Build) dev (64-bit) Revision 22203b32bdae9236d23cc89e70772721315f2d1f-refs/heads/master@{#427892} Thank You.
,
Nov 1 2016
msrchandra@: yeah, that's not surprising. there's another fix in the pipeline: https://codereview.chromium.org/2468963003
,
Nov 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb6e013c7fbe3add00dc47433357ebb43c81a693 commit bb6e013c7fbe3add00dc47433357ebb43c81a693 Author: dbeam <dbeam@chromium.org> Date: Tue Nov 01 20:56:22 2016 MD Downloads: pick up iron-list PR to fix unassigned model (stacking) R=dpapad@chromium.org BUG= 656580 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2468963003 Cr-Commit-Position: refs/heads/master@{#429103} [modify] https://crrev.com/bb6e013c7fbe3add00dc47433357ebb43c81a693/chrome/browser/resources/md_downloads/crisper.js [modify] https://crrev.com/bb6e013c7fbe3add00dc47433357ebb43c81a693/chrome/browser/resources/md_history/app.crisper.js [modify] https://crrev.com/bb6e013c7fbe3add00dc47433357ebb43c81a693/third_party/polymer/v1_0/bower.json [modify] https://crrev.com/bb6e013c7fbe3add00dc47433357ebb43c81a693/third_party/polymer/v1_0/components-chromium/iron-list/bower.json [modify] https://crrev.com/bb6e013c7fbe3add00dc47433357ebb43c81a693/third_party/polymer/v1_0/components-chromium/iron-list/iron-list-extracted.js [modify] https://crrev.com/bb6e013c7fbe3add00dc47433357ebb43c81a693/third_party/polymer/v1_0/components_summary.txt
,
Nov 3 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by hdodda@chromium.org
, Oct 17 2016Labels: hasbisect-per-revision
Owner: dbeam@chromium.org
Status: Assigned (was: Unconfirmed)