New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 656577 link

Starred by 1 user
Status: Fixed
Owner:
█ animohan@chromium.org
Last visit > 30 days ago
Closed: Jan 2017
Cc:
█ animohan@chromium.org
█ scottj@chromium.org
█ mmo...@chromium.org
█ cco3@chromium.org
mattreynolds@chromium.org
█ rzhao@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

[Physical Web] "Browse the Physical Web" button enabled even when Physical Web is OFF

Reported by billy.ja...@samsung.com, Oct 17 2016 
Steps to reproduce the problem:
1. Go to chrome://physical-web
2. Disable Bluetooth/Location/Data Connection, etc. so that Physical Web becomes OFF
3. Click the "Browse the Physical Web" Button

What is the expected behavior?
It should not be clickable

What went wrong?
The button is not disabled

Did this work before? N/A 

Chrome version: 56.0.2890.0  Channel: dev
OS Version: 
Flash Version: 

Please refer the following discussion

https://bugs.chromium.org/p/chromium/issues/detail?id=651076#c13

Comment 1 by billy.ja...@samsung.com, Oct 17 2016 

Added a patch addressing this bug:

https://codereview.chromium.org/2418403003

PTAL, thanks.

Comment 2 by krav...@chromium.org, Oct 17 2016

Owner: animohan@chromium.org
Status: Assigned (was: Unconfirmed)

Comment 3 by krav...@chromium.org, Oct 17 2016

Components: -UI Internals>PhysicalWeb
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b5a21061a6aa8be7cc3b8b6aafa56256bb91e60

commit 5b5a21061a6aa8be7cc3b8b6aafa56256bb91e60
Author: billy.jayan <billy.jayan@samsung.com>
Date: Tue Nov 08 06:00:07 2016

Enable the "Browse the Physical Web" button only when Physical Web is ON.

Enable the "Browse the Physical Web" button only when Physical Web is ON.
Currently "Browse the Physical Web" button is enabled even when Physical Web is
OFF. This patch fixes this issue.

BUG= 656577 

Review-Url: https://codereview.chromium.org/2418403003
Cr-Commit-Position: refs/heads/master@{#430530}

[modify] https://crrev.com/5b5a21061a6aa8be7cc3b8b6aafa56256bb91e60/AUTHORS
[modify] https://crrev.com/5b5a21061a6aa8be7cc3b8b6aafa56256bb91e60/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java

Comment 5 by mmo...@chromium.org, Jan 9 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment