New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 656574 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Android MediaRouter only (left Chro...
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 656563



Sign in to add a comment

New icons for media notification control buttons

Project Member Reported by zqzh...@chromium.org, Oct 17 2016

Issue description

We need new icons for playpause, nexttrack, previoustrack, seekforward, seekbackward.

Mounir, can you find a UX to help with this?
 
Blocking: 656563
Cc: mlamouri@chromium.org
Owner: zqzh...@chromium.org
Taking this.
We can use the standard material designs.
Also need to transfer the old play/pause button to the new set.
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4bf56769b5a7516544f5f5e956e71f2581ded3a

commit b4bf56769b5a7516544f5f5e956e71f2581ded3a
Author: zqzhang <zqzhang@chromium.org>
Date: Fri Oct 28 11:37:05 2016

Clean up media notification icons

* Remove unused black notification icon assets for SDK v21,
  since all clients use NotificationCompat.
* Rename file names from ic_vidcontrol_* to ic_media_control_*,
  since "vidcontrol" stands for "video_control" but we also
  have audio.

BUG= 656574 
TEST=Manual verified on SDK v21

Review-Url: https://codereview.chromium.org/2449183005
Cr-Commit-Position: refs/heads/master@{#428334}

[delete] https://crrev.com/220f57b3c7299133c089ce3c4ede7861cb8bb1e8/chrome/android/java/res/drawable-hdpi-v21/ic_vidcontrol_pause.png
[delete] https://crrev.com/220f57b3c7299133c089ce3c4ede7861cb8bb1e8/chrome/android/java/res/drawable-hdpi-v21/ic_vidcontrol_play.png
[delete] https://crrev.com/220f57b3c7299133c089ce3c4ede7861cb8bb1e8/chrome/android/java/res/drawable-hdpi-v21/ic_vidcontrol_stop.png
[add] https://crrev.com/b4bf56769b5a7516544f5f5e956e71f2581ded3a/chrome/android/java/res/drawable-hdpi/ic_media_control_pause.png
[add] https://crrev.com/b4bf56769b5a7516544f5f5e956e71f2581ded3a/chrome/android/java/res/drawable-hdpi/ic_media_control_play.png
[add] https://crrev.com/b4bf56769b5a7516544f5f5e956e71f2581ded3a/chrome/android/java/res/drawable-hdpi/ic_media_control_stop.png
[delete] https://crrev.com/220f57b3c7299133c089ce3c4ede7861cb8bb1e8/chrome/android/java/res/drawable-hdpi/ic_vidcontrol_pause.png
[delete] https://crrev.com/220f57b3c7299133c089ce3c4ede7861cb8bb1e8/chrome/android/java/res/drawable-hdpi/ic_vidcontrol_play.png
[delete] https://crrev.com/220f57b3c7299133c089ce3c4ede7861cb8bb1e8/chrome/android/java/res/drawable-hdpi/ic_vidcontrol_stop.png
[delete] https://crrev.com/220f57b3c7299133c089ce3c4ede7861cb8bb1e8/chrome/android/java/res/drawable-mdpi-v21/ic_vidcontrol_pause.png
[delete] https://crrev.com/220f57b3c7299133c089ce3c4ede7861cb8bb1e8/chrome/android/java/res/drawable-mdpi-v21/ic_vidcontrol_play.png
[delete] https://crrev.com/220f57b3c7299133c089ce3c4ede7861cb8bb1e8/chrome/android/java/res/drawable-mdpi-v21/ic_vidcontrol_stop.png
[add] https://crrev.com/b4bf56769b5a7516544f5f5e956e71f2581ded3a/chrome/android/java/res/drawable-mdpi/ic_media_control_pause.png
[add] https://crrev.com/b4bf56769b5a7516544f5f5e956e71f2581ded3a/chrome/android/java/res/drawable-mdpi/ic_media_control_play.png
[add] https://crrev.com/b4bf56769b5a7516544f5f5e956e71f2581ded3a/chrome/android/java/res/drawable-mdpi/ic_media_control_stop.png
[delete] https://crrev.com/220f57b3c7299133c089ce3c4ede7861cb8bb1e8/chrome/android/java/res/drawable-mdpi/ic_vidcontrol_pause.png
[delete] https://crrev.com/220f57b3c7299133c089ce3c4ede7861cb8bb1e8/chrome/android/java/res/drawable-mdpi/ic_vidcontrol_play.png
[delete] https://crrev.com/220f57b3c7299133c089ce3c4ede7861cb8bb1e8/chrome/android/java/res/drawable-mdpi/ic_vidcontrol_stop.png
[delete] https://crrev.com/220f57b3c7299133c089ce3c4ede7861cb8bb1e8/chrome/android/java/res/drawable-xhdpi-v21/ic_vidcontrol_pause.png
[delete] https://crrev.com/220f57b3c7299133c089ce3c4ede7861cb8bb1e8/chrome/android/java/res/drawable-xhdpi-v21/ic_vidcontrol_play.png
[delete] https://crrev.com/220f57b3c7299133c089ce3c4ede7861cb8bb1e8/chrome/android/java/res/drawable-xhdpi-v21/ic_vidcontrol_stop.png
[add] https://crrev.com/b4bf56769b5a7516544f5f5e956e71f2581ded3a/chrome/android/java/res/drawable-xhdpi/ic_media_control_pause.png
[add] https://crrev.com/b4bf56769b5a7516544f5f5e956e71f2581ded3a/chrome/android/java/res/drawable-xhdpi/ic_media_control_play.png
[add] https://crrev.com/b4bf56769b5a7516544f5f5e956e71f2581ded3a/chrome/android/java/res/drawable-xhdpi/ic_media_control_stop.png
[delete] https://crrev.com/220f57b3c7299133c089ce3c4ede7861cb8bb1e8/chrome/android/java/res/drawable-xhdpi/ic_vidcontrol_pause.png
[delete] https://crrev.com/220f57b3c7299133c089ce3c4ede7861cb8bb1e8/chrome/android/java/res/drawable-xhdpi/ic_vidcontrol_play.png
[delete] https://crrev.com/220f57b3c7299133c089ce3c4ede7861cb8bb1e8/chrome/android/java/res/drawable-xhdpi/ic_vidcontrol_stop.png
[delete] https://crrev.com/220f57b3c7299133c089ce3c4ede7861cb8bb1e8/chrome/android/java/res/drawable-xxhdpi-v21/ic_vidcontrol_pause.png
[delete] https://crrev.com/220f57b3c7299133c089ce3c4ede7861cb8bb1e8/chrome/android/java/res/drawable-xxhdpi-v21/ic_vidcontrol_play.png
[delete] https://crrev.com/220f57b3c7299133c089ce3c4ede7861cb8bb1e8/chrome/android/java/res/drawable-xxhdpi-v21/ic_vidcontrol_stop.png
[add] https://crrev.com/b4bf56769b5a7516544f5f5e956e71f2581ded3a/chrome/android/java/res/drawable-xxhdpi/ic_media_control_pause.png
[add] https://crrev.com/b4bf56769b5a7516544f5f5e956e71f2581ded3a/chrome/android/java/res/drawable-xxhdpi/ic_media_control_play.png
[add] https://crrev.com/b4bf56769b5a7516544f5f5e956e71f2581ded3a/chrome/android/java/res/drawable-xxhdpi/ic_media_control_stop.png
[delete] https://crrev.com/220f57b3c7299133c089ce3c4ede7861cb8bb1e8/chrome/android/java/res/drawable-xxhdpi/ic_vidcontrol_pause.png
[delete] https://crrev.com/220f57b3c7299133c089ce3c4ede7861cb8bb1e8/chrome/android/java/res/drawable-xxhdpi/ic_vidcontrol_play.png
[delete] https://crrev.com/220f57b3c7299133c089ce3c4ede7861cb8bb1e8/chrome/android/java/res/drawable-xxhdpi/ic_vidcontrol_stop.png
[delete] https://crrev.com/220f57b3c7299133c089ce3c4ede7861cb8bb1e8/chrome/android/java/res/drawable-xxxhdpi-v21/ic_vidcontrol_pause.png
[delete] https://crrev.com/220f57b3c7299133c089ce3c4ede7861cb8bb1e8/chrome/android/java/res/drawable-xxxhdpi-v21/ic_vidcontrol_play.png
[delete] https://crrev.com/220f57b3c7299133c089ce3c4ede7861cb8bb1e8/chrome/android/java/res/drawable-xxxhdpi-v21/ic_vidcontrol_stop.png
[add] https://crrev.com/b4bf56769b5a7516544f5f5e956e71f2581ded3a/chrome/android/java/res/drawable-xxxhdpi/ic_media_control_pause.png
[add] https://crrev.com/b4bf56769b5a7516544f5f5e956e71f2581ded3a/chrome/android/java/res/drawable-xxxhdpi/ic_media_control_play.png
[add] https://crrev.com/b4bf56769b5a7516544f5f5e956e71f2581ded3a/chrome/android/java/res/drawable-xxxhdpi/ic_media_control_stop.png
[delete] https://crrev.com/220f57b3c7299133c089ce3c4ede7861cb8bb1e8/chrome/android/java/res/drawable-xxxhdpi/ic_vidcontrol_pause.png
[delete] https://crrev.com/220f57b3c7299133c089ce3c4ede7861cb8bb1e8/chrome/android/java/res/drawable-xxxhdpi/ic_vidcontrol_play.png
[delete] https://crrev.com/220f57b3c7299133c089ce3c4ede7861cb8bb1e8/chrome/android/java/res/drawable-xxxhdpi/ic_vidcontrol_stop.png
[modify] https://crrev.com/b4bf56769b5a7516544f5f5e956e71f2581ded3a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
[modify] https://crrev.com/b4bf56769b5a7516544f5f5e956e71f2581ded3a/chrome/android/java/src/org/chromium/chrome/browser/media/MediaCaptureNotificationService.java
[modify] https://crrev.com/b4bf56769b5a7516544f5f5e956e71f2581ded3a/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java

Status: Fixed (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc56b29ef844962a6bb3e0e75a76a9339030847f

commit cc56b29ef844962a6bb3e0e75a76a9339030847f
Author: zqzhang <zqzhang@chromium.org>
Date: Wed Nov 30 17:11:12 2016

Add seek forward/backward controls in MediaNotification

This CL adds support for MediaSession seekforward and
seekbackward to MediaNotification. On pre-N, a maximum of 3
buttons is shown in BigView to improve the notification
appearance, while it is 5 for N.

BUG= 656563 , 656574 

Review-Url: https://codereview.chromium.org/2498683002
Cr-Commit-Position: refs/heads/master@{#435304}

[modify] https://crrev.com/cc56b29ef844962a6bb3e0e75a76a9339030847f/chrome/android/BUILD.gn
[add] https://crrev.com/cc56b29ef844962a6bb3e0e75a76a9339030847f/chrome/android/java/res/drawable-hdpi/ic_media_control_fast_forward.png
[add] https://crrev.com/cc56b29ef844962a6bb3e0e75a76a9339030847f/chrome/android/java/res/drawable-hdpi/ic_media_control_fast_rewind.png
[add] https://crrev.com/cc56b29ef844962a6bb3e0e75a76a9339030847f/chrome/android/java/res/drawable-mdpi/ic_media_control_fast_forward.png
[add] https://crrev.com/cc56b29ef844962a6bb3e0e75a76a9339030847f/chrome/android/java/res/drawable-mdpi/ic_media_control_fast_rewind.png
[add] https://crrev.com/cc56b29ef844962a6bb3e0e75a76a9339030847f/chrome/android/java/res/drawable-xhdpi/ic_media_control_fast_forward.png
[add] https://crrev.com/cc56b29ef844962a6bb3e0e75a76a9339030847f/chrome/android/java/res/drawable-xhdpi/ic_media_control_fast_rewind.png
[add] https://crrev.com/cc56b29ef844962a6bb3e0e75a76a9339030847f/chrome/android/java/res/drawable-xxhdpi/ic_media_control_fast_forward.png
[add] https://crrev.com/cc56b29ef844962a6bb3e0e75a76a9339030847f/chrome/android/java/res/drawable-xxhdpi/ic_media_control_fast_rewind.png
[add] https://crrev.com/cc56b29ef844962a6bb3e0e75a76a9339030847f/chrome/android/java/res/drawable-xxxhdpi/ic_media_control_fast_forward.png
[add] https://crrev.com/cc56b29ef844962a6bb3e0e75a76a9339030847f/chrome/android/java/res/drawable-xxxhdpi/ic_media_control_fast_rewind.png
[modify] https://crrev.com/cc56b29ef844962a6bb3e0e75a76a9339030847f/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java
[modify] https://crrev.com/cc56b29ef844962a6bb3e0e75a76a9339030847f/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/cc56b29ef844962a6bb3e0e75a76a9339030847f/chrome/android/java_sources.gni
[add] https://crrev.com/cc56b29ef844962a6bb3e0e75a76a9339030847f/chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaNotificationButtonComputationTest.java
[add] https://crrev.com/cc56b29ef844962a6bb3e0e75a76a9339030847f/chrome/android/junit/src/org/chromium/chrome/browser/media/ui/OWNERS
[modify] https://crrev.com/cc56b29ef844962a6bb3e0e75a76a9339030847f/third_party/WebKit/public/platform/modules/mediasession/media_session.mojom

Sign in to add a comment