New issue
Advanced search Search tips

Issue 656558 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
TT



Sign in to add a comment

Wire up AD device policy flow.

Project Member Reported by tnagel@chromium.org, Oct 17 2016

Issue description

.
 
Labels: Enterprise-Triaged
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d2791ecec5187ab2188b123ce50710d14f9b9e4

commit 8d2791ecec5187ab2188b123ce50710d14f9b9e4
Author: tnagel <tnagel@chromium.org>
Date: Fri Nov 18 10:43:13 2016

Add DeviceADPolicyManager to provide AD policy.

For Active Directory-managed devices, in BrowserPolicyConnectorChromeOS
replace the DeviceCloudPolicyManagerChromeOS ConfigurationPolicyProvider
by the new DeviceADPolicyManager ConfigurationPolicyProvider and disable
DeviceLocalAccountPolicyService and ServerBackedStateKeysBroker.  Note
that accessors to the disabled services may return nullptr now.

Policy refresh is not yet wired through to authpolicyd, instead it
triggers another load from session_manager.

BUG= 656558 
TBR=bartfab (enterprise_platform_keys_private_api.cc)
TBR=achuith (chrome/browser/ui/webui/options/chromeos)

Review-Url: https://codereview.chromium.org/2486813002
Cr-Commit-Position: refs/heads/master@{#433171}

[modify] https://crrev.com/8d2791ecec5187ab2188b123ce50710d14f9b9e4/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/8d2791ecec5187ab2188b123ce50710d14f9b9e4/chrome/browser/chromeos/login/screens/chrome_user_selection_screen.cc
[modify] https://crrev.com/8d2791ecec5187ab2188b123ce50710d14f9b9e4/chrome/browser/chromeos/login/users/avatar/user_image_manager_browsertest.cc
[modify] https://crrev.com/8d2791ecec5187ab2188b123ce50710d14f9b9e4/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
[modify] https://crrev.com/8d2791ecec5187ab2188b123ce50710d14f9b9e4/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_policy_browsertest.cc
[modify] https://crrev.com/8d2791ecec5187ab2188b123ce50710d14f9b9e4/chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc
[modify] https://crrev.com/8d2791ecec5187ab2188b123ce50710d14f9b9e4/chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h
[add] https://crrev.com/8d2791ecec5187ab2188b123ce50710d14f9b9e4/chrome/browser/chromeos/policy/device_active_directory_policy_manager.cc
[add] https://crrev.com/8d2791ecec5187ab2188b123ce50710d14f9b9e4/chrome/browser/chromeos/policy/device_active_directory_policy_manager.h
[modify] https://crrev.com/8d2791ecec5187ab2188b123ce50710d14f9b9e4/chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc
[modify] https://crrev.com/8d2791ecec5187ab2188b123ce50710d14f9b9e4/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc
[modify] https://crrev.com/8d2791ecec5187ab2188b123ce50710d14f9b9e4/chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc
[modify] https://crrev.com/8d2791ecec5187ab2188b123ce50710d14f9b9e4/chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.h
[modify] https://crrev.com/8d2791ecec5187ab2188b123ce50710d14f9b9e4/chrome/browser/chromeos/policy/device_policy_cros_browser_test.cc
[modify] https://crrev.com/8d2791ecec5187ab2188b123ce50710d14f9b9e4/chrome/browser/chromeos/policy/enrollment_handler_chromeos.cc
[modify] https://crrev.com/8d2791ecec5187ab2188b123ce50710d14f9b9e4/chrome/browser/chromeos/settings/device_settings_service.cc
[modify] https://crrev.com/8d2791ecec5187ab2188b123ce50710d14f9b9e4/chrome/browser/chromeos/settings/device_settings_service.h
[modify] https://crrev.com/8d2791ecec5187ab2188b123ce50710d14f9b9e4/chrome/browser/chromeos/settings/install_attributes.cc
[modify] https://crrev.com/8d2791ecec5187ab2188b123ce50710d14f9b9e4/chrome/browser/chromeos/settings/install_attributes.h
[modify] https://crrev.com/8d2791ecec5187ab2188b123ce50710d14f9b9e4/chrome/browser/chromeos/settings/install_attributes_unittest.cc
[modify] https://crrev.com/8d2791ecec5187ab2188b123ce50710d14f9b9e4/chrome/browser/chromeos/settings/session_manager_operation.cc
[modify] https://crrev.com/8d2791ecec5187ab2188b123ce50710d14f9b9e4/chrome/browser/chromeos/settings/session_manager_operation.h
[modify] https://crrev.com/8d2791ecec5187ab2188b123ce50710d14f9b9e4/chrome/browser/chromeos/settings/session_manager_operation_unittest.cc
[modify] https://crrev.com/8d2791ecec5187ab2188b123ce50710d14f9b9e4/chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc
[modify] https://crrev.com/8d2791ecec5187ab2188b123ce50710d14f9b9e4/chrome/browser/policy/cloud/policy_header_service_factory.cc
[modify] https://crrev.com/8d2791ecec5187ab2188b123ce50710d14f9b9e4/chrome/browser/policy/profile_policy_connector.cc
[modify] https://crrev.com/8d2791ecec5187ab2188b123ce50710d14f9b9e4/chrome/browser/policy/profile_policy_connector_factory.cc
[modify] https://crrev.com/8d2791ecec5187ab2188b123ce50710d14f9b9e4/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc
[modify] https://crrev.com/8d2791ecec5187ab2188b123ce50710d14f9b9e4/chrome/browser/ui/webui/options/chromeos/accounts_options_browsertest.cc
[modify] https://crrev.com/8d2791ecec5187ab2188b123ce50710d14f9b9e4/chrome/browser/ui/webui/options/chromeos/shared_options_browsertest.cc
[modify] https://crrev.com/8d2791ecec5187ab2188b123ce50710d14f9b9e4/chrome/browser/ui/webui/policy_ui_handler.cc
[modify] https://crrev.com/8d2791ecec5187ab2188b123ce50710d14f9b9e4/chrome/browser/ui/webui/policy_ui_handler.h
[modify] https://crrev.com/8d2791ecec5187ab2188b123ce50710d14f9b9e4/components/policy/core/common/cloud/cloud_policy_client.cc
[modify] https://crrev.com/8d2791ecec5187ab2188b123ce50710d14f9b9e4/components/policy/core/common/policy_map.cc
[modify] https://crrev.com/8d2791ecec5187ab2188b123ce50710d14f9b9e4/components/policy/core/common/policy_map.h
[modify] https://crrev.com/8d2791ecec5187ab2188b123ce50710d14f9b9e4/components/policy/core/common/policy_types.h
[modify] https://crrev.com/8d2791ecec5187ab2188b123ce50710d14f9b9e4/components/policy_strings.grdp

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd095cf6bd65478ad5e09f63aa0d4a927e85fc89

commit dd095cf6bd65478ad5e09f63aa0d4a927e85fc89
Author: tnagel <tnagel@chromium.org>
Date: Fri Nov 18 15:14:07 2016

Fix enrollment crash

Fix a crash when hitting the "Done" button after enrollment that was
introduced in 8d2791ecec5187ab2188b123ce50710d14f9b9e4.

BUG= 656558 

Review-Url: https://codereview.chromium.org/2515673002
Cr-Commit-Position: refs/heads/master@{#433199}

[modify] https://crrev.com/dd095cf6bd65478ad5e09f63aa0d4a927e85fc89/chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc

Comment 6 by tnagel@chromium.org, Nov 21 2016

Labels: TT

Comment 7 by tnagel@chromium.org, Nov 21 2016

Labels: -M-56 M-57
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f18dd0634ded648d1577bcf786555801e224401

commit 0f18dd0634ded648d1577bcf786555801e224401
Author: tnagel <tnagel@chromium.org>
Date: Mon Nov 21 17:41:21 2016

Request device policy from authpolicyd

Wire up the D-Bus call for device policy fetch in
DeviceActiveDirectoryPolicyManager::RefreshPolicies().

BUG= 656558 

Review-Url: https://codereview.chromium.org/2512733004
Cr-Commit-Position: refs/heads/master@{#433580}

[modify] https://crrev.com/0f18dd0634ded648d1577bcf786555801e224401/chrome/browser/chromeos/policy/device_active_directory_policy_manager.cc
[modify] https://crrev.com/0f18dd0634ded648d1577bcf786555801e224401/chrome/browser/chromeos/policy/device_active_directory_policy_manager.h

Comment 9 by tnagel@chromium.org, Nov 21 2016

It seems like the remaining task is setting up a timer to fetch policy at regular intervals.
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91cc209158c160afcfd6ddaccdbcc6a201db1f54

commit 91cc209158c160afcfd6ddaccdbcc6a201db1f54
Author: tnagel <tnagel@chromium.org>
Date: Tue Nov 22 10:58:31 2016

Minor PolicyStatusProvider fixes

Follow-up to https://codereview.chromium.org/2486813002/.

BUG= 656558 

Review-Url: https://codereview.chromium.org/2519023002
Cr-Commit-Position: refs/heads/master@{#433833}

[modify] https://crrev.com/91cc209158c160afcfd6ddaccdbcc6a201db1f54/chrome/browser/ui/webui/policy_ui_handler.cc

Status: Fixed (was: Started)
The only remaining task, automatic policy refresh is tracked in  issue 677304 .
Status: Verified (was: Fixed)
bulk Verify of older or not-user-facing Chromad bugs

Sign in to add a comment