New issue
Advanced search Search tips

Issue 656516 link

Starred by 3 users
Status: Archived
Owner:
horo@chromium.org
Closed: Dec 5
Cc:
shimazu@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Service Worker still partially runs when JS is disabled from DevTools

Project Member Reported by shimazu@chromium.org, Oct 17 2016 
// This issue is branched from  Issue 632823 .

Version: 55.0.2883.5
OS: Windows 10, MAC 10.11.6, Ubuntu 14.04

What steps will reproduce the problem?

1) Installed chrome and navigated to the test URL: https://googlechrome.github.io/samples/service-worker/mock-responses/index.html
2) Navigated to Dev tools and observe that Service workers are displayed in console (Attachment - before-disabled.png)
3) Disabled javaScript from Dev tools>Settings
4) Reloaded the Test URL.
5) In console observed that Only a single event was displayed in Console Log (Attachment - after-disabled.png)

What is the expected output?

All fetches skip the service worker


What do you see instead?

Only CSS was provided from the service worker.

This issue didn't happen if JS is disabled from chrome://settings/content, so I guess this might be a devtools issue.
before-disabled.png
443 KB View Download
after-disabled.png
293 KB View Download

Comment 1 by shimazu@chromium.org, Oct 17 2016

Components: -Blink>ServiceWorker

Comment 2 by horo@chromium.org, Oct 17 2016

Components: Blink>ServiceWorker
Status: Available (was: Untriaged)
When the "Disable JavaScript" checkbox in Devtools is clicked, InspectorEmulationAgent::setScriptExecutionDisabled() is called in the rendere process.
InspectorEmulationAgent::setScriptExecutionDisabled() calls DevToolsEmulator::setScriptExecutionDisabled() and blink::Setting.setScriptEnabled() is called.

But this flag is not propagated to the browser process.

So shimazu's patch https://codereview.chromium.org/2377603002 doesn't work well with the checkbox in Devtools.

Comment 3 by horo@chromium.org, Oct 17 2016

Owner: horo@chromium.org
Status: Assigned (was: Available)

Comment 4 by horo@chromium.org, Oct 31 2016

Labels: -Pri-2 Pri-3
I think the priority of this issue should be P3.

Comment 5 by pfeldman@chromium.org, Dec 5

Status: Archived (was: Assigned)
Archiving the minor edge case.
►

Sign in to add a comment