New issue
Advanced search Search tips

Issue 656459 link

Starred by 1 user
Status: Fixed
Owner:
tkent@chromium.org
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 651744



Sign in to add a comment

isPointInRage(), comparePoint(), and intersectNode() of Range interface has incorrect same-tree check

Project Member Reported by tkent@chromium.org, Oct 16 2016 
Version: 56 canary
OS: all

What steps will reproduce the problem?
(1) Open http://w3c-test.org/dom/ranges/Range-set.html and http://w3c-test.org/dom/ranges/Range-isPointInRange.html

What is the expected output?
All tests pass.

What do you see instead?
845 tests fail on Range-set.html, and 478 tests fail on Range-isPointInRange.html

Please use labels and text to provide additional information.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/001fe107daa76703b32f7db8c37980d82e60185f

commit 001fe107daa76703b32f7db8c37980d82e60185f
Author: Kent Tamura <tkent@chromium.org>
Date: Sun Oct 16 23:49:44 2016

Remove Range-set-expected.txt, and mark Range-set.html [Failure].

This is a preparation of https://codereview.chromium.org/2416963007.  In the CL,
we want to remove Range-set-expected.txt, but Rietveld can't handle changes to
1MB+ file. This CL removes it beforehand without codereview.

This CL doesn't affect production.

BUG= 656459 

Cr-Commit-Position: refs/heads/master@{#425600}

[modify] https://crrev.com/001fe107daa76703b32f7db8c37980d82e60185f/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/4b9833ae2deefd124a268633ff6054a69ef43bf4/third_party/WebKit/LayoutTests/imported/wpt/dom/ranges/Range-set-expected.txt
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a2aa879982c582f811a9d9ef75286b8d27aab84

commit 8a2aa879982c582f811a9d9ef75286b8d27aab84
Author: tkent <tkent@chromium.org>
Date: Mon Oct 17 08:07:59 2016

Range object should check root node identify instead of inActiveDocument().

https://dom.spec.whatwg.org/#dom-range-ispointinrange

According to the DOM standard, isPointInRange(), comparePoint(), and
intersectNode() should check root identity, not whether the specified node is in
an active document.

Thew new behavior matches to Firefox and Safari.

This CL fixes 1,323 failing tests in imported/wpt/dom/ranges/.

BUG= 656459 

Review-Url: https://codereview.chromium.org/2416963007
Cr-Commit-Position: refs/heads/master@{#425630}

[modify] https://crrev.com/8a2aa879982c582f811a9d9ef75286b8d27aab84/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/201585d73b60b9043147deee9e21a8c8b4b916a5/third_party/WebKit/LayoutTests/imported/wpt/dom/ranges/Range-isPointInRange-expected.txt
[modify] https://crrev.com/8a2aa879982c582f811a9d9ef75286b8d27aab84/third_party/WebKit/Source/core/dom/Range.cpp
[modify] https://crrev.com/8a2aa879982c582f811a9d9ef75286b8d27aab84/third_party/WebKit/Source/core/dom/Range.h

Comment 3 by tkent@chromium.org, Oct 17 2016

Labels: M-56
Status: Fixed (was: Started)
►

Sign in to add a comment