New issue
Advanced search Search tips

Issue 656458 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature

Blocking:
issue 510287



Sign in to add a comment

bluetooth: Return specific error if getPrimaryServices() is called without requesting access to any UUIDs.

Project Member Reported by ortuno@chromium.org, Oct 16 2016

Issue description

Rather than returning 'NotFoundError: No services found in device.' we could give a more specific error that indicates that developers need to request access to services before being able to retrieve them.

 
Owner: fbeaufort@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08303d660862c7d0d4f9deb7cb753d3dc68570dc

commit 08303d660862c7d0d4f9deb7cb753d3dc68570dc
Author: beaufort.francois <beaufort.francois@gmail.com>
Date: Tue Nov 15 15:53:14 2016

bluetooth: Return specific error if getPrimaryServices() is called without requesting access to any UUIDs.

BUG= 656458 

Review-Url: https://codereview.chromium.org/2459523002
Cr-Commit-Position: refs/heads/master@{#432186}

[modify] https://crrev.com/08303d660862c7d0d4f9deb7cb753d3dc68570dc/content/browser/bluetooth/bluetooth_allowed_devices_map.cc
[modify] https://crrev.com/08303d660862c7d0d4f9deb7cb753d3dc68570dc/content/browser/bluetooth/bluetooth_allowed_devices_map.h
[modify] https://crrev.com/08303d660862c7d0d4f9deb7cb753d3dc68570dc/content/browser/bluetooth/bluetooth_allowed_devices_map_unittest.cc
[modify] https://crrev.com/08303d660862c7d0d4f9deb7cb753d3dc68570dc/content/browser/bluetooth/web_bluetooth_service_impl.cc
[add] https://crrev.com/08303d660862c7d0d4f9deb7cb753d3dc68570dc/third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/gen-service-delayed-discovery-no-permission-for-any-service.html
[add] https://crrev.com/08303d660862c7d0d4f9deb7cb753d3dc68570dc/third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/gen-service-no-permission-for-any-service.html
[modify] https://crrev.com/08303d660862c7d0d4f9deb7cb753d3dc68570dc/third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/delayed-discovery-no-permission-present-service.html
[add] https://crrev.com/08303d660862c7d0d4f9deb7cb753d3dc68570dc/third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/gen-service-delayed-discovery-no-permission-for-any-service-with-uuid.html
[add] https://crrev.com/08303d660862c7d0d4f9deb7cb753d3dc68570dc/third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/gen-service-delayed-discovery-no-permission-for-any-service.html
[add] https://crrev.com/08303d660862c7d0d4f9deb7cb753d3dc68570dc/third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/gen-service-no-permission-for-any-service-with-uuid.html
[add] https://crrev.com/08303d660862c7d0d4f9deb7cb753d3dc68570dc/third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/gen-service-no-permission-for-any-service.html
[modify] https://crrev.com/08303d660862c7d0d4f9deb7cb753d3dc68570dc/third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/no-permission-present-service.html
[add] https://crrev.com/08303d660862c7d0d4f9deb7cb753d3dc68570dc/third_party/WebKit/LayoutTests/bluetooth/script-tests/service-delayed-discovery-no-permission-for-any-service.js
[add] https://crrev.com/08303d660862c7d0d4f9deb7cb753d3dc68570dc/third_party/WebKit/LayoutTests/bluetooth/script-tests/service-no-permission-for-any-service.js
[modify] https://crrev.com/08303d660862c7d0d4f9deb7cb753d3dc68570dc/third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp
[modify] https://crrev.com/08303d660862c7d0d4f9deb7cb753d3dc68570dc/third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom

Comment 3 by ortuno@chromium.org, Nov 24 2016

Status: Fixed (was: Started)

Sign in to add a comment