New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 656434 link

Starred by 1 user
Status: Fixed
Owner:
sahel@chromium.org
Closed: Dec 2016
Cc:
█ aelias@chromium.org
tdres...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Tap suppression should also suppress long press

Project Member Reported by rbyers@chromium.org, Oct 16 2016 
Version: 54.0.2840.50 

Browsing on Facebook I did a fling, then stabbed the screen to stop it but (don't know why) held my finger there for a few seconds.  I was surprised to see the long press action fire.  

If we're going to suppress taps after a fling, then we should probably suppress long press too, right?

Comment 1 by tdres...@chromium.org, Oct 17 2016

Owner: sahel@chromium.org
Status: Assigned (was: Untriaged)
I agree this is broken - I'm a bit surprised we haven't run into it before.

It looks like ShowPress is also firing, though the code makes it look like we try to avoid that.

Sahel, could you take a look at this at some point?

This should be a reasonable place to start.
https://cs.chromium.org/chromium/src/content/browser/renderer_host/input/gesture_event_queue.cc?rcl=1476688838&l=150

Comment 2 by sahel@chromium.org, Nov 24 2016

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d1623599ed4bd5fc9aef5ac9a835c3cfc4d6d43

commit 3d1623599ed4bd5fc9aef5ac9a835c3cfc4d6d43
Author: sahel <sahel@chromium.org>
Date: Mon Dec 12 21:42:27 2016

Suppress LongPress/Tap, and TwoFingerTap when TapDown cancels a fling.

MUST_SUPPRESS_TAP_ENDS state is added to TapSuppressionController. When
a tap end event causes to drop the stashed tap down, the controller goes
to the new state. This state shows that all following tap ends should
get suppressed till the end of the current touch sequence.

BUG= 656434 
TEST=TapSuppressionControllerTest.*SufficientlyLateTapUp

Review-Url: https://codereview.chromium.org/2542453003
Cr-Commit-Position: refs/heads/master@{#437923}

[modify] https://crrev.com/3d1623599ed4bd5fc9aef5ac9a835c3cfc4d6d43/content/browser/renderer_host/input/gesture_event_queue.cc
[modify] https://crrev.com/3d1623599ed4bd5fc9aef5ac9a835c3cfc4d6d43/content/browser/renderer_host/input/input_router_config_helper.cc
[modify] https://crrev.com/3d1623599ed4bd5fc9aef5ac9a835c3cfc4d6d43/content/browser/renderer_host/input/tap_suppression_controller.cc
[modify] https://crrev.com/3d1623599ed4bd5fc9aef5ac9a835c3cfc4d6d43/content/browser/renderer_host/input/tap_suppression_controller.h
[modify] https://crrev.com/3d1623599ed4bd5fc9aef5ac9a835c3cfc4d6d43/content/browser/renderer_host/input/tap_suppression_controller_client.h
[modify] https://crrev.com/3d1623599ed4bd5fc9aef5ac9a835c3cfc4d6d43/content/browser/renderer_host/input/tap_suppression_controller_unittest.cc
[modify] https://crrev.com/3d1623599ed4bd5fc9aef5ac9a835c3cfc4d6d43/content/browser/renderer_host/input/touchpad_tap_suppression_controller.cc
[modify] https://crrev.com/3d1623599ed4bd5fc9aef5ac9a835c3cfc4d6d43/content/browser/renderer_host/input/touchpad_tap_suppression_controller.h
[modify] https://crrev.com/3d1623599ed4bd5fc9aef5ac9a835c3cfc4d6d43/content/browser/renderer_host/input/touchscreen_tap_suppression_controller.cc
[modify] https://crrev.com/3d1623599ed4bd5fc9aef5ac9a835c3cfc4d6d43/content/browser/renderer_host/input/touchscreen_tap_suppression_controller.h

Comment 4 by sahel@chromium.org, Dec 12 2016

Status: Fixed (was: Started)

Comment 5 by dtapu...@chromium.org, Jan 6 2017

Labels: Hotlist-Input-Dev
►

Sign in to add a comment