New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 656319 link

Starred by 4 users

Issue metadata

Status: Archived
Owner: ----
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

bisect-builds-py instruction page needs to be fixed

Reported by term...@gmail.com, Oct 15 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101 Firefox/38.0

Steps to reproduce the problem:
1. Go to https://www.chromium.org/developers/bisect-builds-py
2. Refer to section 'Getting an initial revision range'
3. Instructions no longer apply to Chrome

What is the expected behavior?
Instructions should apply to Chrome. With some digging I found a working way to do it though:

- Go to chrome://version, get revision hash.
- https://blink.lc/chromium/commit/?id=<hash>
- Extract from 'Cr-Branched-From: ' at @{#NNNNNN}

---

Google Chrome	54.0.2840.59 (Official Build) m (32-bit)
Revision	5b2f167ccdaed3f1a90ec1084715fbb91b8d25b0-refs/branch-heads/2840@{#726}

https://blink.lc/chromium/commit/?id=5b2f167ccdaed3f1a90ec1084715fbb91b8d25b0

Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}
So it's 414607

---

Google Chrome	53.0.2785.143 (Official Build) m (32-bit)
Revision	f33d44362232c20d1ce2111c53ea8730698f3c88-refs/branch-heads/2785@{#925}

https://blink.lc/chromium/commit/?id=f33d44362232c20d1ce2111c53ea8730698f3c88

Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}
So it's 403382

---

python chrome-bisect-builds.py -a win -g 403382 -b 414607 --use-local-cache --verify-range -- --no-first-run  --user-data-dir=/temp

What went wrong?
I did a bisect in Windows yesterday. It was my first Chrome bisect and it was hard to figure out how to do it because the instructions are wrong.

There is no longer a number in the '(Official Build NNNNN)' text.
This no longer works: http://src.chromium.org/viewvc/chrome/branches/<branch_number>/src/

Also, in the bisect-builds.py script it says:

---

Revision numbers should use
  SVN revisions (e.g. 123456) for chromium builds, from trunk.
    Use base_trunk_revision from http://omahaproxy.appspot.com/
    for earlier revs.
    Chrome's about: build number and omahaproxy branch_revision
    are incorrect, they are from branches.

---

I thought you guys used git, and also why is there not a simple way to do this like in Firefox? When I want to bisect something in Firefox I get two build IDs and that's it. For example why can't I bisect like:
python chrome-bisect-builds.py -a win -g 53.0.2785.143 -b 54.0.2840.59

Anyway, see my answer to 'expected behavior' for how I worked around it.

Did this work before? Yes Unknown

Chrome version: <Copy from: 'about:version'>  Channel: n/a
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: Shockwave Flash 23.0 r0
 

Comment 1 by term...@gmail.com, Oct 15 2016

I read somewhere to tag this as infra but I can't see a way to do it. This should be tagged as that and please CC Stefan Zager or someone that can update that bisect-builds page, https://www.chromium.org/developers/bisect-builds-py
Cc: dimu@chromium.org szager@chromium.org
Labels: TE-NeedsTriageHelp

Comment 4 by dimu@google.com, Oct 18 2016

Cc: pras...@chromium.org anan...@chromium.org
Thank you for reporting this issue  termsrv@!
You can also use the "Version Information" tool on OmahaProxy to find out the numeric "Branch base position". I have updated the bisect-builds build with this info.

However, please note that we only support manual bisect on Chromium builds publicly. So we could only bisect based on commit position rather than official build versions.

Added prasadv@ and anantha@ if they would like to provide more info.

Comment 5 by term...@gmail.com, Oct 19 2016

Thank you for changing that. I think though more could be done to explain that the base branch position is what needs to be specified:

--
If your build of Chromium does not have the NNNNN specifier then you can use the "Version Information" tool on OmahaProxy to find out the numeric "Branch base position", which can be used as good-revision or bad-revision.
--

I don't know what it means that you only support manual bisect on Chromium builds. What I'm saying is you could do something in your program like this

bisect-builds.py ... -g 54.0.2840.59

and in the program the python equivalent of this:
curl --fail --location -sS --proto =https https://omahaproxy.appspot.com/deps.json?version=54.0.2840.59 | jq --raw-output '.chromium_base_position | select(type == "string")'

Labels: -TE-NeedsTriageHelp
Project Member

Comment 7 by sheriffbot@chromium.org, Nov 6 2017

Status: Archived (was: Unconfirmed)
Issue has not been modified or commented on in the last 365 days, please re-open or file a new bug if this is still an issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment