"org.chromium.content.browser.MediaSessionTest#testMediaResumeAfterTransientFocusLoss" is flaky |
|||||||||
Issue description"org.chromium.content.browser.MediaSessionTest#testMediaResumeAfterTransientFocusLoss" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyXwsSBUZsYWtlIlRvcmcuY2hyb21pdW0uY29udGVudC5icm93c2VyLk1lZGlhU2Vzc2lvblRlc3QjdGVzdE1lZGlhUmVzdW1lQWZ0ZXJUcmFuc2llbnRGb2N1c0xvc3MM. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Oct 17 2016
This looks like a non-infrastructure flake to me. If the sheriff is OK with accepting this flakiness into the chromium codebase, then they should close this bug.
,
Oct 17 2016
I don't *think* this is infrastructural either, however there isn't much to go on beyond some very basic crash info. This isn't happening with a high frequency and hasn't affected the main waterfall yet so assigning to a component area for triage. I 175.156s run_tests_on_device(03d12eac006adbc4) detected failure in org.chromium.content.browser.MediaSessionTest#testMediaResumeAfterTransientFocusLoss. raw output: I 175.157s run_tests_on_device(03d12eac006adbc4) INSTRUMENTATION_STATUS: numtests=1 I 175.157s run_tests_on_device(03d12eac006adbc4) INSTRUMENTATION_STATUS: stream= I 175.157s run_tests_on_device(03d12eac006adbc4) org.chromium.content.browser.MediaSessionTest: I 175.157s run_tests_on_device(03d12eac006adbc4) INSTRUMENTATION_STATUS: id=InstrumentationTestRunner I 175.157s run_tests_on_device(03d12eac006adbc4) INSTRUMENTATION_STATUS: test=testMediaResumeAfterTransientFocusLoss I 175.157s run_tests_on_device(03d12eac006adbc4) INSTRUMENTATION_STATUS: class=org.chromium.content.browser.MediaSessionTest I 175.158s run_tests_on_device(03d12eac006adbc4) INSTRUMENTATION_STATUS: current=1 I 175.158s run_tests_on_device(03d12eac006adbc4) INSTRUMENTATION_STATUS_CODE: 1 I 175.158s run_tests_on_device(03d12eac006adbc4) INSTRUMENTATION_RESULT: shortMsg=Native crash I 175.158s run_tests_on_device(03d12eac006adbc4) INSTRUMENTATION_RESULT: longMsg=Native crash: Segmentation fault I 175.158s run_tests_on_device(03d12eac006adbc4) INSTRUMENTATION_CODE: 0 I 175.159s TimeoutThread-1-for-run_tests_on_device(03d12eac006adbc4) [host]> /b/swarm_slave/w/irVJLYNP/third_party/android_tools/sdk/platform-tools/adb -s 03d12eac006adbc4 shell '( pm clear org.chromium.content_shell_apk );echo %$?' I 175.761s run_tests_on_device(03d12eac006adbc4) Finished running tests on this device. I 175.763s run_tests_on_device(06b829dd13c869d3) Finished running tests on this device. I 175.763s run_tests_on_device(03d13138006aff5e) Finished running tests on this device. I 175.763s run_tests_on_device(03d136f6006adc5e) Finished running tests on this device. I 175.763s run_tests_on_device(06b940050062253a) Finished running tests on this device. I 175.763s run_tests_on_device(03d13705006b0134) Finished running tests on this device. I 175.764s run_tests_on_device(0723021a00622e49) Finished running tests on this device. I 175.770s Main FINISHED TRY #2/3
,
Oct 17 2016
stack symbolization got lost when switching android bots to swarming, but here's the stack. In particular, the DCHECK failure message may or may not be helpful: Device(03d12eac006adbc4) 10-14 23:49:50.539 9769 9792 F chromium: [9769:9792:1014/234950:11541561801:FATAL:video_renderer_algorithm.cc(317)] Check failed: frame_queue_[last_frame_index_].drop_count <= frame_queue_[last_frame_index_].render_count (2 vs. 1) Device(03d12eac006adbc4) 10-14 23:49:50.539 9769 9792 F chromium: #00 0x75adfc27 /data/app-lib/org.chromium.content_shell_apk-1/libcontent_shell_content_view.so+0x0056bc27 Device(03d12eac006adbc4) 10-14 23:49:50.539 9769 9792 F chromium: #01 0x75fd9369 /data/app-lib/org.chromium.content_shell_apk-1/libcontent_shell_content_view.so+0x00a65369 Device(03d12eac006adbc4) 10-14 23:49:50.539 9769 9792 F chromium: #02 0x75fed185 /data/app-lib/org.chromium.content_shell_apk-1/libcontent_shell_content_view.so+0x00a79185 Device(03d12eac006adbc4) 10-14 23:49:50.539 9769 9792 F chromium: #03 0x76df62ff /data/app-lib/org.chromium.content_shell_apk-1/libcontent_shell_content_view.so+0x018822ff Device(03d12eac006adbc4) 10-14 23:49:50.539 9769 9792 F chromium: #04 0x76df6373 /data/app-lib/org.chromium.content_shell_apk-1/libcontent_shell_content_view.so+0x01882373 Device(03d12eac006adbc4) 10-14 23:49:50.539 9769 9792 F chromium: #05 0x75e8b6bf /data/app-lib/org.chromium.content_shell_apk-1/libcontent_shell_content_view.so+0x009176bf Device(03d12eac006adbc4) 10-14 23:49:50.539 9769 9792 F chromium: #06 0x75f0fd9d /data/app-lib/org.chromium.content_shell_apk-1/libcontent_shell_content_view.so+0x0099bd9d Device(03d12eac006adbc4) 10-14 23:49:50.539 9769 9792 F chromium: #07 0x75f31f75 /data/app-lib/org.chromium.content_shell_apk-1/libcontent_shell_content_view.so+0x009bdf75 Device(03d12eac006adbc4) 10-14 23:49:50.539 9769 9792 F chromium: #08 0x75ee334b /data/app-lib/org.chromium.content_shell_apk-1/libcontent_shell_content_view.so+0x0096f34b Device(03d12eac006adbc4) 10-14 23:49:50.539 9769 9792 F chromium: #09 0x75ee36d3 /data/app-lib/org.chromium.content_shell_apk-1/libcontent_shell_content_view.so+0x0096f6d3 Device(03d12eac006adbc4) 10-14 23:49:50.539 9769 9792 F chromium: #10 0x75ee3d71 /data/app-lib/org.chromium.content_shell_apk-1/libcontent_shell_content_view.so+0x0096fd71 Device(03d12eac006adbc4) 10-14 23:49:50.539 9769 9792 F chromium: #11 0x75edcf27 /data/app-lib/org.chromium.content_shell_apk-1/libcontent_shell_content_view.so+0x00968f27 Device(03d12eac006adbc4) 10-14 23:49:50.539 9769 9792 F chromium: #12 0x75edcd71 /data/app-lib/org.chromium.content_shell_apk-1/libcontent_shell_content_view.so+0x00968d71 Device(03d12eac006adbc4) 10-14 23:49:50.539 9769 9792 F chromium: #13 0x773f9d4d /data/app-lib/org.chromium.content_shell_apk-1/libcontent_shell_content_view.so+0x01e85d4d Device(03d12eac006adbc4) 10-14 23:49:50.539 9769 9792 F chromium: #14 0x773f9f41 /data/app-lib/org.chromium.content_shell_apk-1/libcontent_shell_content_view.so+0x01e85f41 Device(03d12eac006adbc4) 10-14 23:49:50.539 9769 9792 F chromium: #15 0x773fa6c3 /data/app-lib/org.chromium.content_shell_apk-1/libcontent_shell_content_view.so+0x01e866c3 Device(03d12eac006adbc4) 10-14 23:49:50.539 9769 9792 F chromium: #16 0x75ad126f /data/app-lib/org.chromium.content_shell_apk-1/libcontent_shell_content_view.so+0x0055d26f Device(03d12eac006adbc4) 10-14 23:49:50.539 9769 9792 F chromium: #17 0x75ae7525 /data/app-lib/org.chromium.content_shell_apk-1/libcontent_shell_content_view.so+0x00573525 Device(03d12eac006adbc4) 10-14 23:49:50.539 9769 9792 F chromium: #18 0x75ae77af /data/app-lib/org.chromium.content_shell_apk-1/libcontent_shell_content_view.so+0x005737af Device(03d12eac006adbc4) 10-14 23:49:50.539 9769 9792 F chromium: #19 0x75ae78b1 /data/app-lib/org.chromium.content_shell_apk-1/libcontent_shell_content_view.so+0x005738b1 Device(03d12eac006adbc4) 10-14 23:49:50.539 9769 9792 F chromium: #20 0x75ae9f01 /data/app-lib/org.chromium.content_shell_apk-1/libcontent_shell_content_view.so+0x00575f01 Device(03d12eac006adbc4) 10-14 23:49:50.539 9769 9792 F chromium: #21 0x75ae8ebb /data/app-lib/org.chromium.content_shell_apk-1/libcontent_shell_content_view.so+0x00574ebb Device(03d12eac006adbc4) 10-14 23:49:50.539 9769 9792 F chromium: #22 0x75afd9a7 /data/app-lib/org.chromium.content_shell_apk-1/libcontent_shell_content_view.so+0x005899a7 Device(03d12eac006adbc4) 10-14 23:49:50.539 9769 9792 F chromium: #23 0x75b14d2f /data/app-lib/org.chromium.content_shell_apk-1/libcontent_shell_content_view.so+0x005a0d2f Device(03d12eac006adbc4) 10-14 23:49:50.539 9769 9792 F chromium: #24 0x75b1538b /data/app-lib/org.chromium.content_shell_apk-1/libcontent_shell_content_view.so+0x005a138b Device(03d12eac006adbc4) 10-14 23:49:50.539 9769 9792 F chromium: #25 0x75b107bf /data/app-lib/org.chromium.content_shell_apk-1/libcontent_shell_content_view.so+0x0059c7bf Device(03d12eac006adbc4) 10-14 23:49:50.539 9769 9792 F chromium: #26 0x400aa173 /system/lib/libc.so+0x0000d173 Device(03d12eac006adbc4) 10-14 23:49:50.539 9769 9792 F chromium: #27 0x400aa30b /system/lib/libc.so+0x0000d30b Device(03d12eac006adbc4) 10-14 23:49:50.539 9769 9792 F chromium: #28 0xffffffff <unknown> From this trybot run: https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/160894
,
Oct 19 2016
Dale, do you know who is the owner of this flaky test? as per #4, error is on video_renderer_algorithm.cc
,
Oct 19 2016
CC Zhiqiang, however the DCHECK seems to come from the video renderer..
,
Oct 19 2016
Hmm, I can take a look at the DCHECK tomorrow. I suspect now that we use PaintSingleFrame in VRI, we're not properly dropping the not-renderered signal sent to VRA.
,
Oct 19 2016
,
Oct 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dee963030706f989b4fb7de973a916c02d2a2083 commit dee963030706f989b4fb7de973a916c02d2a2083 Author: dalecurtis <dalecurtis@chromium.org> Date: Tue Oct 25 01:31:09 2016 Fix perf and paint issues with VRI::PaintSingleFrame. This prevents repeated rendering of the first frame and ensures the algorithm knows about the frame being painted so that future calls to OnLastFrameDropped() don't muck with statistics incorrectly. Results seem slightly mixed, but maybe the official perf bot will provide stronger evidence. It's a good change regardless. BUG= 627172 , 656231 TEST=perf tests. Review-Url: https://codereview.chromium.org/2437623004 Cr-Commit-Position: refs/heads/master@{#427217} [modify] https://crrev.com/dee963030706f989b4fb7de973a916c02d2a2083/media/filters/video_renderer_algorithm.cc [modify] https://crrev.com/dee963030706f989b4fb7de973a916c02d2a2083/media/filters/video_renderer_algorithm.h [modify] https://crrev.com/dee963030706f989b4fb7de973a916c02d2a2083/media/renderers/video_renderer_impl.cc [modify] https://crrev.com/dee963030706f989b4fb7de973a916c02d2a2083/media/renderers/video_renderer_impl.h
,
Oct 25 2016
Flakes seem to have disappeared before my change went in, so closing this, but we can reopen if flakes appear.
,
Oct 26 2016
Issue 659634 has been merged into this issue.
,
Oct 26 2016
,
Oct 26 2016
Issue 659315 has been merged into this issue.
,
Oct 26 2016
,
Oct 26 2016
My first fix increased flakiness :( -- New fix here https://codereview.chromium.org/2452523004/
,
Oct 26 2016
Issue 659815 has been merged into this issue.
,
Oct 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/71bec519151a602e5a9334d420c12b1f3f9301f1 commit 71bec519151a602e5a9334d420c12b1f3f9301f1 Author: dalecurtis <dalecurtis@chromium.org> Date: Fri Oct 28 03:16:44 2016 Always count rendered frames; fixes drop flakiness. Not adding to the render count when a frame is rendered just makes handling dropped frames tricky and flaky. Instead the only thing we really care about is not carrying forward overage to the next frame after rendering starts (or restarts). BUG= 656231 TEST=new unittest. Review-Url: https://codereview.chromium.org/2452523004 Cr-Commit-Position: refs/heads/master@{#428267} [modify] https://crrev.com/71bec519151a602e5a9334d420c12b1f3f9301f1/chrome/browser/media/encrypted_media_browsertest.cc [modify] https://crrev.com/71bec519151a602e5a9334d420c12b1f3f9301f1/media/filters/video_renderer_algorithm.cc [modify] https://crrev.com/71bec519151a602e5a9334d420c12b1f3f9301f1/media/filters/video_renderer_algorithm_unittest.cc
,
Nov 3 2016
Issue 639175 has been merged into this issue.
,
Nov 3 2016
,
Nov 3 2016
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by yoichio@chromium.org
, Oct 17 2016Labels: -Sheriff-Chromium Infra-Troopers