New issue
Advanced search Search tips

Issue 656217 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

BranchUtilTest keeps failing on the master-release builder

Project Member Reported by nxia@chromium.org, Oct 15 2016

Issue description

https://uberchromegw.corp.google.com/i/chromeos/builders/master-release/builds/2489/steps/BranchUtilTest/logs/stdio



STEP_FAILURE
02:36:11: ERROR: Traceback (most recent call last):
  File "/b/cbuild/internal_master/chromite/cbuildbot/stages/generic_stages.py", line 546, in Run
    self.PerformStage()
  File "/b/cbuild/internal_master/chromite/cbuildbot/stages/branch_stages.py", line 486, in PerformStage
    self._FixUpManifests(repo_manifest)
  File "/b/cbuild/internal_master/chromite/cbuildbot/stages/branch_stages.py", line 342, in _FixUpManifests
    included_manifests = self._UpdateManifest(manifest_path)
  File "/b/cbuild/internal_master/chromite/cbuildbot/stages/branch_stages.py", line 242, in _UpdateManifest
    manifest_path=manifest_path)
  File "/b/cbuild/internal_master/chromite/lib/git.py", line 785, in Cached
    obj = cls(root, manifest_path=manifest_path)
  File "/b/cbuild/internal_master/chromite/lib/git.py", line 590, in __init__
    manifest_include_dir=manifest_include_dir)
  File "/b/cbuild/internal_master/chromite/lib/git.py", line 389, in __init__
    self._RunParser(source)
  File "/b/cbuild/internal_master/chromite/lib/git.py", line 405, in _RunParser
    self._FinalizeAllProjectData()
  File "/b/cbuild/internal_master/chromite/lib/git.py", line 720, in _FinalizeAllProjectData
    Manifest._FinalizeAllProjectData(self)
  File "/b/cbuild/internal_master/chromite/lib/git.py", line 460, in _FinalizeAllProjectData
    self._FinalizeProjectData(path_data)
  File "/b/cbuild/internal_master/chromite/lib/git.py", line 728, in _FinalizeProjectData
    Manifest._FinalizeProjectData(self, attrs)
  File "/b/cbuild/internal_master/chromite/lib/git.py", line 473, in _FinalizeProjectData
    (self.source, remote, self.remotes))
AssertionError: /tmp/cbuildbot-tmpv1GmC2/tmpCiib9d/manifest-internal/internal_full.xml: cros-internal not in {}

 
I want to blame: https://chrome-internal-review.googlesource.com/#/c/293055/
Haven't really taken a look yet.
That CL created the problem, but I don't think reverting is the right fix.
Owner: pprabhu@chromium.org
Status: Started (was: Untriaged)
BranchUtilTest is right: https://chrome-internal-review.googlesource.com/#/c/297358/ :)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 17 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/manifest-internal/+/ab3390491d5aa050e850d4ffaed8fc7757244fbc

commit ab3390491d5aa050e850d4ffaed8fc7757244fbc
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Sat Oct 15 05:45:08 2016

Status: Fixed (was: Started)
... next canary will tell.

Comment 6 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 7 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 8 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 9 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 11 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment