New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 656213 link

Starred by 3 users

Issue metadata

Status: Archived
Owner:
Closed: Sep 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Why didn't we catch memory leak in crbug.com/655434

Project Member Reported by boliu@chromium.org, Oct 15 2016

Issue description

system health tests should have caught this, in theory..

perezju: what does system health tests look like now? is it still the same cycle: load->wait->background->trim->wait->repeat? What's the latest instructions on how to run those tests?
 
Is the root cause the same as  issue 619812 ?

Comment 2 by boliu@chromium.org, Oct 17 2016

> Is the root cause the same as  issue 619812 ?

Nope. Don't need multiple webviews for this one
Our old benchmark (memory.top_10_mobile) is being deprecated in favor of several new different stories tested as part of system health:

- some are just "loading": open browser, load page, wait for a while, force gc, measure memory, close browser.
  https://cs.chromium.org/chromium/src/tools/perf/page_sets/system_health/loading_stories.py

- some are now also "browsing": open browser, load page, interact with page (e.g. scroll, click on links), force gc, measure memory, close browser.
  https://cs.chromium.org/chromium/src/tools/perf/page_sets/system_health/browsing_stories.py

The "background" cases are also now being added as new stories (for now we only have background coverage in memory.top_10_mobile, but this is changing soon).

What would trigger the leak from  issue 655434 ?

To run the set of all stories you can now do (after replacing the system webview on a device, and installing SystemWebViewShell.apk on it):

$ tools/perf/run_benchmark system_health.memory_mobile --browser android-webview

Comment 4 by boliu@chromium.org, Oct 18 2016

Does "system_health.memory_mobile" run everything? Can I just limit it to top_10_mobile? (haven't actually tried it yet)

> What would trigger the leak from  issue 655434 ?

Background + trim would run through the same code path as detach I think.

Comment 5 by boliu@chromium.org, Oct 22 2016

Cc: -perezju@chromium.org boliu@chromium.org
Owner: perezju@chromium.org
I ran memory.top_10_mobile today. The issue doesn't trigger because we dropped the trim call it seems. Was using a nexus 4 to test.

So we are still monitoring top_10_mobile before the new background tests are up right?

I think it's important to test both with and without trim, so I dunno if we want to double the amount of testing we do, if there's a compromise, or just wait for new test suite and keep detach in mind. P3 or wontfix I guess, depending on what perezju has time for..
Status: Archived (was: Assigned)
Archiving old issues which are likely no longer relevant and I probably won't work on them.

Reopen if you think an issue should be looked at again.

Sign in to add a comment