New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 656211 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Recently-introduced flake of session restore browsertests on Mac

Project Member Reported by joedow@chromium.org, Oct 15 2016

Issue description

browser_tests on Mac-10.9 failing on chromium.mac/Mac10.9 Tests

Type: build-failure

Builders failed on: 
- Mac10.9 Tests: 
  https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests


[ RUN      ] ContinueWhereILeftOffTest.LocalStorageClearedOnExit
BrowserTestBase received signal: Terminated: 15. Backtrace:
0   browser_tests                       0x000000010a051383 _ZN4base5debug10StackTraceC1Ev + 19
1   browser_tests                       0x000000010a6fd3fc _ZN7content12_GLOBAL__N_1L27DumpStackTraceSignalHandlerEi + 204
2   libsystem_platform.dylib            0x00007fff90c715aa _sigtramp + 26
3   ???                                 0x00000001199bffff 0x0 + 4724621311
4   CoreFoundation                      0x00007fff950ebe75 CFRunLoopRunSpecific + 309
5   HIToolbox                           0x00007fff9357ba0d RunCurrentEventLoopInMode + 226
6   HIToolbox                           0x00007fff9357b7b7 ReceiveNextEventCommon + 479
7   HIToolbox                           0x00007fff9357b5bc _BlockUntilNextEventMatchingListInModeWithFilter + 65
8   AppKit                              0x00007fff8d7c624e _DPSNextEvent + 1434
9   AppKit                              0x00007fff8d7c589b -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 122
10  AppKit                              0x00007fff8d7b999c -[NSApplication run] + 553
11  browser_tests                       0x000000010a078c0e _ZN4base24MessagePumpNSApplication5DoRunEPNS_11MessagePump8DelegateE + 334
12  browser_tests                       0x000000010a07821c _ZN4base24MessagePumpCFRunLoopBase3RunEPNS_11MessagePump8DelegateE + 92
13  browser_tests                       0x000000010a07544e _ZN4base11MessageLoop10RunHandlerEv + 94
14  browser_tests                       0x000000010a094271 _ZN4base7RunLoop3RunEv + 113
15  browser_tests                       0x000000010a73774f _ZN7content14RunThisRunLoopEPN4base7RunLoopE + 79
16  browser_tests                       0x000000010a701c37 _ZN7content12TitleWatcher15WaitAndGetTitleEv + 23
17  browser_tests                       0x00000001086edfa4 _ZN24BetterSessionRestoreTest10CheckTitleEP7BrowserRKNSt3__112basic_stringItN4base20string16_char_traitsENS2_9allocatorItEEEE + 564
18  browser_tests                       0x000000010a0fc18a _ZN20InProcessBrowserTest23RunTestOnMainThreadLoopEv + 218
19  browser_tests                       0x000000010a6fd15e _ZN7content15BrowserTestBase28ProxyRunTestOnMainThreadLoopEv + 270
20  browser_tests                       0x000000010a15d5de _ZN22ChromeBrowserMainParts25PreMainMessageLoopRunImplEv + 3918
21  browser_tests                       0x000000010a15c58e _ZN22ChromeBrowserMainParts21PreMainMessageLoopRunEv + 62
22  browser_tests                       0x000000010990d053 _ZN7content15BrowserMainLoop21PreMainMessageLoopRunEv + 67
23  browser_tests                       0x0000000109c0c8ff _ZN7content17StartupTaskRunner14RunAllTasksNowEv + 47
24  browser_tests                       0x000000010990b88e _ZN7content15BrowserMainLoop18CreateStartupTasksEv + 622
25  browser_tests                       0x000000010990f599 _ZN7content21BrowserMainRunnerImpl10InitializeERKNS_18MainFunctionParamsE + 537
26  browser_tests                       0x0000000109909484 _ZN7content11BrowserMainERKNS_18MainFunctionParamsE + 100
27  browser_tests                       0x000000010a03b5fd _ZN7content21ContentMainRunnerImpl3RunEv + 477
28  browser_tests                       0x000000010a03a7f6 _ZN7content11ContentMainERKNS_17ContentMainParamsE + 54
29  browser_tests                       0x000000010a6fcead _ZN7content15BrowserTestBase5SetUpEv + 1853
30  browser_tests                       0x000000010a0fb4d0 _ZN20InProcessBrowserTest5SetUpEv + 336
31  browser_tests                       0x000000010ad69a2b _ZN7testing4Test3RunEv + 299
32  browser_tests                       0x000000010ad6a804 _ZN7testing8TestInfo3RunEv + 404
33  browser_tests                       0x000000010ad6ae97 _ZN7testing8TestCase3RunEv + 455
34  browser_tests                       0x000000010ad71647 _ZN7testing8internal12UnitTestImpl11RunAllTestsEv + 919
35  browser_tests                       0x000000010ad71279 _ZN7testing8UnitTest3RunEv + 265
36  browser_tests                       0x000000010a10a77f _ZN4base9TestSuite3RunEv + 127
37  browser_tests                       0x000000010a044c4f _ZN21ChromeTestSuiteRunner12RunTestSuiteEiPPc + 31
38  browser_tests                       0x000000010a7349ae _ZN7content11LaunchTestsEPNS_20TestLauncherDelegateEiiPPc + 302
39  browser_tests                       0x000000010a044bda main + 90
40  browser_tests                       0x0000000107eff434 start + 52
41  ???                                 0x0000000000000009 0x0 + 9
[572/572] ContinueWhereILeftOffTest.LocalStorageClearedOnExit (TIMED OUT)
 

Comment 1 by joedow@chromium.org, Oct 15 2016

 Issue 656221  has been merged into this issue.
Project Member

Comment 3 by chromium...@appspot.gserviceaccount.com, Oct 17 2016

Labels: Sheriff-Chromium
Detected 3 new flakes for test/step "ContinueWhereILeftOffTest.LocalStorageClearedOnExit". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPgsSBUZsYWtlIjNDb250aW51ZVdoZXJlSUxlZnRPZmZUZXN0LkxvY2FsU3RvcmFnZUNsZWFyZWRPbkV4aXQM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Summary: Recently-introduced flake of session restore browsertests on Mac (was: ContinueWhereILeftOffTest.LocalStorageClearedOnExit timed out on Mac-10.9 failing on chromium.mac/Mac10.9 Tests)
This problem is more general: ContinueWhereILeftOffTest.CookiesClearedOnExit and SessionRestoreTest.RestoreWithNavigateSelectedTab are also experiencing flake. It looks like this flake started sometime on Friday October 14. I'm reluctant to disable the tests as it seems highly likely that there's a culprit CL that should be reverted.
 Issue 656550  has been merged into this issue.
 Issue 656551  has been merged into this issue.
 Issue 656548  has been merged into this issue.
 Issue 656566  has been merged into this issue.
This is the oldest run that I have found exhibiting this flake:

https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/31631

No CL on that run itself seems like it would have caused the flake, so maybe something Mac-specific that landed sometime slightly before that run?
Cc: marja@chromium.org
Cc: -marja@chromium.org
Owner: marja@chromium.org
Status: Assigned (was: Available)

Comment 15 by marja@chromium.org, Oct 17 2016

I'm afraid I'm not a good owner for this bug, I haven't done any Chromium-stuff for ages and I cannot look at this bug in a timely manner.

Maybe some mac people would be better (re: comment 12)?
Cc: rsesek@chromium.org pinkerton@chromium.org ellyjo...@chromium.org shrike@chromium.org
Owner: groby@chromium.org
Fishing for people who might have insight or know who to forward this on to ;).

Comment 17 by sky@chromium.org, Oct 17 2016

I'm not aware of anything that would directly trigger this. There have been a bunch of issues with activation and session restore recently. See 634248, which was addressed by https://chromium.googlesource.com/chromium/src/+/c8ca51e469c96ab4a3e1b0cd9772687077b38984 .
Project Member

Comment 18 by chromium...@appspot.gserviceaccount.com, Oct 18 2016

Detected 6 new flakes for test/step "ContinueWhereILeftOffTest.LocalStorageClearedOnExit". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPgsSBUZsYWtlIjNDb250aW51ZVdoZXJlSUxlZnRPZmZUZXN0LkxvY2FsU3RvcmFnZUNsZWFyZWRPbkV4aXQM. This message was posted automatically by the chromium-try-flakes app.
Project Member

Comment 19 by chromium...@appspot.gserviceaccount.com, Oct 18 2016

Detected 7 new flakes for test/step "SessionRestoreTest.RestoreWithNavigateSelectedTab". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPAsSBUZsYWtlIjFTZXNzaW9uUmVzdG9yZVRlc3QuUmVzdG9yZVdpdGhOYXZpZ2F0ZVNlbGVjdGVkVGFiDA. This message was posted automatically by the chromium-try-flakes app.
Project Member

Comment 20 by chromium...@appspot.gserviceaccount.com, Oct 18 2016

Detected 7 new flakes for test/step "ContinueWhereILeftOffTest.CookiesClearedOnExit". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyOQsSBUZsYWtlIi5Db250aW51ZVdoZXJlSUxlZnRPZmZUZXN0LkNvb2tpZXNDbGVhcmVkT25FeGl0DA. This message was posted automatically by the chromium-try-flakes app.
Project Member

Comment 21 by chromium...@appspot.gserviceaccount.com, Oct 18 2016

Detected 14 new flakes for test/step "SmartSessionRestoreTest.PRE_CorrectLoadingOrder". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyOgsSBUZsYWtlIi9TbWFydFNlc3Npb25SZXN0b3JlVGVzdC5QUkVfQ29ycmVjdExvYWRpbmdPcmRlcgw. This message was posted automatically by the chromium-try-flakes app.
Cc: sky@chromium.org
Disabled ContinueWhereILeftOffTest.LocalStorageClearedOnExit on Mac since it has been failing repeatedly on "mac_chromium_rel_ng" and "Mac Asan 64 Tests" bots.

See:
https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/316505
https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/23137

[ RUN      ] ContinueWhereILeftOffTest.LocalStorageClearedOnExit
[67848:51971:1018/043453:WARNING:mac_util.mm(222)] Failed to set backup exclusion for file '/private/var/folders/9x/6c6sv3cj4j53wzpzthbp4ksm0000gm/T/.org.chromium.Chromium.lsYoih/dJx01Le/Default/History': Error Domain=NSOSStatusErrorDomain Code=-50 "The operation couldn?t be completed. (OSStatus error -50.)" (paramErr: error in user parameter list) (-50)
[67848:51971:1018/043453:WARNING:mac_util.mm(222)] Failed to set backup exclusion for file '/private/var/folders/9x/6c6sv3cj4j53wzpzthbp4ksm0000gm/T/.org.chromium.Chromium.lsYoih/dJx01Le/Default/Favicons': Error Domain=NSOSStatusErrorDomain Code=-50 "The operation couldn?t be completed. (OSStatus error -50.)" (paramErr: error in user parameter list) (-50)
[67851:3335:1018/043453:WARNING:vt_video_decode_accelerator_mac.cc(174)] Failed to create VTDecompressionSession: Error Domain=NSOSStatusErrorDomain Code=-8973 "The operation couldn?t be completed. (OSStatus error -8973.)" (codecOpenErr) (-8973)
[67851:3335:1018/043453:WARNING:vt_video_decode_accelerator_mac.cc(209)] Failed to create hardware VideoToolbox session
[67851:3335:1018/043453:ERROR:vt_video_encode_accelerator_mac.cc(540)]  VTCompressionSessionCreate failed: -12908
BrowserTestBase received signal: Terminated: 15. Backtrace:
0   browser_tests                       0x000000010e8809e3 _ZN4base5debug10StackTraceC1Ev + 19
1   browser_tests                       0x00000001100da636 _ZN7content12_GLOBAL__N_1L27DumpStackTraceSignalHandlerEi + 486
2   libsystem_platform.dylib            0x00007fff936f75aa _sigtramp + 26
3   ???                                 0x0000000000000000 0x0 + 0
4   CoreFoundation                      0x00007fff97b72f15 __CFRunLoopServiceMachPort + 181
5   CoreFoundation                      0x00007fff97b72539 __CFRunLoopRun + 1161
6   CoreFoundation                      0x00007fff97b71e75 CFRunLoopRunSpecific + 309
7   HIToolbox                           0x00007fff96001a0d RunCurrentEventLoopInMode + 226
8   HIToolbox                           0x00007fff960017b7 ReceiveNextEventCommon + 479
9   HIToolbox                           0x00007fff960015bc _BlockUntilNextEventMatchingListInModeWithFilter + 65
10  AppKit                              0x00007fff9024c24e _DPSNextEvent + 1434
11  AppKit                              0x00007fff9024b89b -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 122
12  AppKit                              0x00007fff9023f99c -[NSApplication run] + 553
13  browser_tests                       0x000000010e92105e _ZN4base24MessagePumpNSApplication5DoRunEPNS_11MessagePump8DelegateE + 1022
14  browser_tests                       0x000000010e91ee5d _ZN4base24MessagePumpCFRunLoopBase3RunEPNS_11MessagePump8DelegateE + 413
15  browser_tests                       0x000000010e9112f1 _ZN4base11MessageLoop10RunHandlerEv + 817
16  browser_tests                       0x000000010e98eeb9 _ZN4base7RunLoop3RunEv + 249
17  browser_tests                       0x0000000110189dde _ZN7content14RunThisRunLoopEPN4base7RunLoopE + 126
18  browser_tests                       0x000000011018b875 _ZN7content17MessageLoopRunner3RunEv + 341
19  browser_tests                       0x00000001100ecb94 _ZN7content12TitleWatcher15WaitAndGetTitleEv + 52
20  browser_tests                       0x0000000109260762 _ZN24BetterSessionRestoreTest10CheckTitleEP7BrowserRKNSt3__112basic_stringItN4base20string16_char_traitsENS2_9allocatorItEEEE + 1554
21  browser_tests                       0x000000010eaff784 _ZN20InProcessBrowserTest23RunTestOnMainThreadLoopEv + 980
22  browser_tests                       0x00000001100d9fd5 _ZN7content15BrowserTestBase28ProxyRunTestOnMainThreadLoopEv + 869
23  browser_tests                       0x000000010ec58a9a _ZN22ChromeBrowserMainParts25PreMainMessageLoopRunImplEv + 9530
24  browser_tests                       0x000000010ec56127 _ZN22ChromeBrowserMainParts21PreMainMessageLoopRunEv + 263
25  browser_tests                       0x000000010cdb21ce _ZN7content15BrowserMainLoop21PreMainMessageLoopRunEv + 350
26  browser_tests                       0x000000010d994d2b _ZN7content17StartupTaskRunner14RunAllTasksNowEv + 299
27  browser_tests                       0x000000010cdadb7c _ZN7content15BrowserMainLoop18CreateStartupTasksEv + 1404
28  browser_tests                       0x000000010cdba91b _ZN7content21BrowserMainRunnerImpl10InitializeERKNS_18MainFunctionParamsE + 1323
29  browser_tests                       0x000000010cda6636 _ZN7content11BrowserMainERKNS_18MainFunctionParamsE + 358
30  browser_tests                       0x000000010e81f834 _ZN7content23RunNamedProcessTypeMainERKNSt3__112basic_stringIcNS0_11char_traitsIcEENS0_9allocatorIcEEEERKNS_18MainFunctionParamsEPNS_19ContentMainDelegateE + 1300
31  browser_tests                       0x000000010e8215c9 _ZN7content21ContentMainRunnerImpl3RunEv + 1529
32  browser_tests                       0x000000010e81edce _ZN7content11ContentMainERKNS_17ContentMainParamsE + 142
33  browser_tests                       0x00000001100d9414 _ZN7content15BrowserTestBase5SetUpEv + 4116
34  browser_tests                       0x000000010eafcde7 _ZN20InProcessBrowserTest5SetUpEv + 1159
35  browser_tests                       0x00000001118e00e0 _ZN7testing4Test3RunEv + 464
36  browser_tests                       0x00000001118e2143 _ZN7testing8TestInfo3RunEv + 1075
37  browser_tests                       0x00000001118e3617 _ZN7testing8TestCase3RunEv + 1287
38  browser_tests                       0x00000001118f62d7 _ZN7testing8internal12UnitTestImpl11RunAllTestsEv + 2311
39  browser_tests                       0x00000001118f591d _ZN7testing8UnitTest3RunEv + 413
40  browser_tests                       0x000000010eb2f586 _ZN4base9TestSuite3RunEv + 486
41  browser_tests                       0x000000010e855324 _ZN21ChromeTestSuiteRunner12RunTestSuiteEiPPc + 196
42  browser_tests                       0x00000001101814c8 _ZN7content11LaunchTestsEPNS_20TestLauncherDelegateEiiPPc + 1000
43  browser_tests                       0x000000010e855184 main + 244
44  browser_tests                       0x0000000107d24c34 start + 52
Labels: -Sheriff-Chromium
Project Member

Comment 24 by bugdroid1@chromium.org, Oct 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa97f3fa9c2396d9b1bc3d4183509a9043ca0d18

commit aa97f3fa9c2396d9b1bc3d4183509a9043ca0d18
Author: guidou <guidou@chromium.org>
Date: Tue Oct 18 12:45:15 2016

Disable flaky ContinueWhereILeftOffTest.LocalStorageClearedOnExit on Mac.

BUG=656211
TBR=sky@chromium.org

Review-Url: https://codereview.chromium.org/2428863002
Cr-Commit-Position: refs/heads/master@{#425944}

[modify] https://crrev.com/aa97f3fa9c2396d9b1bc3d4183509a9043ca0d18/chrome/browser/sessions/better_session_restore_browsertest.cc

Project Member

Comment 25 by chromium...@appspot.gserviceaccount.com, Oct 19 2016

Labels: Sheriff-Chromium
Detected 6 new flakes for test/step "ContinueWhereILeftOffTest.CookiesClearedOnExit". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyOQsSBUZsYWtlIi5Db250aW51ZVdoZXJlSUxlZnRPZmZUZXN0LkNvb2tpZXNDbGVhcmVkT25FeGl0DA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Project Member

Comment 26 by chromium...@appspot.gserviceaccount.com, Oct 19 2016

Detected 6 new flakes for test/step "SessionRestoreTest.RestoreWithNavigateSelectedTab". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPAsSBUZsYWtlIjFTZXNzaW9uUmVzdG9yZVRlc3QuUmVzdG9yZVdpdGhOYXZpZ2F0ZVNlbGVjdGVkVGFiDA. This message was posted automatically by the chromium-try-flakes app.
Labels: -Sheriff-Chromium
Project Member

Comment 28 by bugdroid1@chromium.org, Oct 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff8c9ac7fc9aae03a11114e35bc4871c8bd805d5

commit ff8c9ac7fc9aae03a11114e35bc4871c8bd805d5
Author: Guido Urdaneta <guidou@chromium.org>
Date: Wed Oct 19 12:39:37 2016

Disable flaky tests on Mac.

The disabled tests are:
* SessionRestoreTest.RestoreWithNavigateSelectedTab
* ContinueWhereILeftOffTest.CookiesClearedOnExit

BUG=656211
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/2430223005 .

Cr-Commit-Position: refs/heads/master@{#426159}

[modify] https://crrev.com/ff8c9ac7fc9aae03a11114e35bc4871c8bd805d5/chrome/browser/sessions/better_session_restore_browsertest.cc
[modify] https://crrev.com/ff8c9ac7fc9aae03a11114e35bc4871c8bd805d5/chrome/browser/sessions/session_restore_browsertest.cc

Project Member

Comment 29 by bugdroid1@chromium.org, Oct 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2c83a465510ed5c6677a8d6286a8d27f18cd9c1

commit e2c83a465510ed5c6677a8d6286a8d27f18cd9c1
Author: pkasting <pkasting@chromium.org>
Date: Thu Oct 20 23:04:40 2016

Actually disable tests on Mac (previous commit didn't update test names).

BUG=656211
TEST=none
TBR=guidou, sky

Review-Url: https://chromiumcodereview.appspot.com/2441513003
Cr-Commit-Position: refs/heads/master@{#426634}

[modify] https://crrev.com/e2c83a465510ed5c6677a8d6286a8d27f18cd9c1/chrome/browser/sessions/better_session_restore_browsertest.cc
[modify] https://crrev.com/e2c83a465510ed5c6677a8d6286a8d27f18cd9c1/chrome/browser/sessions/session_restore_browsertest.cc

Project Member

Comment 30 by chromium...@appspot.gserviceaccount.com, Oct 21 2016

Labels: Sheriff-Chromium
Detected 3 new flakes for test/step "ContinueWhereILeftOffTest.CookiesClearedOnExit". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyOQsSBUZsYWtlIi5Db250aW51ZVdoZXJlSUxlZnRPZmZUZXN0LkNvb2tpZXNDbGVhcmVkT25FeGl0DA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Project Member

Comment 31 by chromium...@appspot.gserviceaccount.com, Oct 21 2016

Detected 3 new flakes for test/step "SessionRestoreTest.RestoreWithNavigateSelectedTab". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPAsSBUZsYWtlIjFTZXNzaW9uUmVzdG9yZVRlc3QuUmVzdG9yZVdpdGhOYXZpZ2F0ZVNlbGVjdGVkVGFiDA. This message was posted automatically by the chromium-try-flakes app.
Project Member

Comment 32 by chromium...@appspot.gserviceaccount.com, Oct 21 2016

Detected 4 new flakes for test/step "SmartSessionRestoreTest.PRE_CorrectLoadingOrder". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyOgsSBUZsYWtlIi9TbWFydFNlc3Npb25SZXN0b3JlVGVzdC5QUkVfQ29ycmVjdExvYWRpbmdPcmRlcgw. This message was posted automatically by the chromium-try-flakes app.
Labels: -Sheriff-Chromium
Comment 30 and 31 are for flakes that happened before the CL in comment 29.
Comment 32 is for the wrong bug (should be  bug 656687 , I fixed it).

Taking out of sheriff queue.

Comment 34 by groby@chromium.org, May 15 2017

Cc: creis@chromium.org
Owner: ----
Status: Available (was: Assigned)
I have no idea who might know more - possibly creis, since SessionRestore?

Comment 35 by creis@chromium.org, May 15 2017

Owner: chrisha@chromium.org
chrisha@, did I hear that you're working on session restore now?  I haven't done much directly with it-- I usually ask sky@.
I've been picking up session restore bugs as a 20%. I've been focusing on cross-platform issues rather than any specific platform issues. I can put this on the TODO list, but there's a bunch of other higher priority functionality bugs on that list.
Project Member

Comment 37 by chromium...@appspot.gserviceaccount.com, Jun 8 2017

Labels: Sheriff-Chromium
Detected 11 new flakes for test/step "ContinueWhereILeftOffTest.LocalStorageClearedOnExit". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPgsSBUZsYWtlIjNDb250aW51ZVdoZXJlSUxlZnRPZmZUZXN0LkxvY2FsU3RvcmFnZUNsZWFyZWRPbkV4aXQM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Project Member

Comment 38 by bugdroid1@chromium.org, Jun 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c929d26527dfaa216a7727c08bd285c942700f2

commit 0c929d26527dfaa216a7727c08bd285c942700f2
Author: Dan Beam <dbeam@chromium.org>
Date: Thu Jun 08 23:10:34 2017

Disable ContinueWhereILeftOffTest.LocalStorageClearedOnExit on Windows as well

TBR=chrisha@chromium.org
BUG=656211

Change-Id: Ibc3f63b32311ff6ff70e836acf20ad512f66dd6b
Reviewed-on: https://chromium-review.googlesource.com/528309
Reviewed-by: Dan Beam <dbeam@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478118}
[modify] https://crrev.com/0c929d26527dfaa216a7727c08bd285c942700f2/chrome/browser/sessions/better_session_restore_browsertest.cc

Labels: -Sheriff-Chromium
Removing sheriff-chromium label since this now has an owner.
Project Member

Comment 40 by sheriffbot@chromium.org, Jun 11 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Assigned (was: Untriaged)
This bug has an owner, thus, it's been triaged. Changing status to "assigned".

Sign in to add a comment