New issue
Advanced search Search tips

Issue 656208 link

Starred by 2 users
Status: WontFix
Owner: ----
Closed: Oct 2016
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

chrome::ShowWebDialog has layering violation for views

Project Member Reported by jamescook@chromium.org, Oct 14 2016 
In particular, code in chrome/browser/chromeos and chrome/browser/ui/webui uses chrome::ShowWebDialog, which is implemented in chrome/browser/ui/views.

webui should not depend on views.

Arguably it's OK in this case, since it's webui spawning webui, but it really should be fixed.

Comment 1 by jamescook@chromium.org, Oct 14 2016 

(This may be there for historical reasons, like perhaps there used to be a non-views implementation of this function.)

Comment 2 by jamescook@chromium.org, Oct 17 2016

Status: WontFix (was: Untriaged)
Actually, this is a common pattern for dialogs implemented on multiple platforms (declare in c/b/ui code, implement in c/b/ui/<platform>). It just happens this one is only implemented on views.
►

Sign in to add a comment