New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 656188 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Security



Sign in to add a comment

Chrome allows kiosk app user to create directories and files without the app's knowledge

Project Member Reported by mlight@google.com, Oct 14 2016

Issue description

Version: ChromeOS 8872.7.0, M-55 Dev, and probably others.
Device: Sumo (chromebase)

While a kiosk app is executing (either in Consumer or Enterprise mode), a malicious user can save images to files, and create new directories.  This activity occurs without the kiosk app's knowledge.

What steps will reproduce the problem?
(1) Launch a kiosk app which contains at least one image.  Example:  ChromeSign running a slideshow.
(2) Either right-click on the image with a mouse, or if it has a touch-screen, press and hold a finger on the image.
(3) A pop-up menu gives the option to save the image to a file.
The user can now create new directories under "Downloads" and save the file with whatever name he/she chooses.  The next user of the app can use the same trick to see the names which the previous user created; perhaps the answers to test questions, for example.  Large image files could also consume substantial disk space, if saved enough times.

What is the expected output?
In kiosk mode, I would expect chrome to not permit creation of any files except under command of the kiosk app.


 

Comment 1 by cyrusm@chromium.org, Oct 15 2016

Cc: cyrusm@chromium.org
Labels: -Pri-3 Pri-2
Owner: vidster@chromium.org
Thanks Michael!  Has this been exploited yet?  Did you find this yourself?

This is an interesting exploit -- Vidya, how easy would it be to fix this?  Kids are certainly creative and they could theoretically exploit this in high stakes exams?

Comment 2 by cyrusm@chromium.org, Oct 15 2016

Cc: maxkirsch@chromium.org
+max for tracking

Comment 3 by mmoroz@chromium.org, Oct 15 2016

Labels: Security_Severity-Medium Security_Impact-Head OS-Chrome
Project Member

Comment 4 by sheriffbot@chromium.org, Oct 15 2016

Labels: -Security_Impact-Head Security_Impact-Beta
Project Member

Comment 5 by sheriffbot@chromium.org, Oct 15 2016

Labels: Hotlist-Google

Comment 6 by mlight@google.com, Oct 17 2016

I found this by accident on my own while trying to reproduce  issue 614771  (title bar exposed for kiosk app on a touch-screen tablet).   I haven't heard of it being used in the wild.

I think that TestNav considers this a feature rather than a bug. Not image saving per se, but they allow you to save test results to a file so that you can transfer them to a USB drive if you lose network connectivity.

Comment 8 Deleted

Wrt #7: Yes, but that feature is expressed in the UI as a button to save results/export results (exact wording escapes me) to external storage. The issue reported here bypasses the App UI, and exploits OS support for right-click / long-press, and saves to the SSD.
Project Member

Comment 10 by sheriffbot@chromium.org, Oct 21 2016

Labels: ReleaseBlock-Stable
Project Member

Comment 11 by sheriffbot@chromium.org, Oct 29 2016

vidster: Uh oh! This issue still open and hasn't been updated in the last 14 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: vidster@chromium.org
Owner: sduraisamy@chromium.org
Cc: krishna...@chromium.org
Cc: -scunning...@chromium.org
Project Member

Comment 15 by sheriffbot@chromium.org, Nov 12 2016

sduraisamy: Uh oh! This issue still open and hasn't been updated in the last 28 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Any progress on this? We are nearing 55 stable and this is marked as a blocker, if we can get a fix in the next two days we can make the targeted RC, if not we may have to punt or delay. 
Cc: sduraisamy@chromium.org
Owner: xiy...@chromium.org
Xiyuan, can you please look into it?
Status: Started (was: Assigned)
https://codereview.chromium.org/2545433004/
Project Member

Comment 19 by bugdroid1@chromium.org, Nov 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8791e3898c6d8c25fdfc416bb0c427607f223851

commit 8791e3898c6d8c25fdfc416bb0c427607f223851
Author: xiyuan <xiyuan@chromium.org>
Date: Wed Nov 30 21:49:16 2016

kiosk: Use ContextMenuContentTypeAppMode when in app mode

Give ContextMenuContentTypeAppMode higher priority than
ContextMenuContentTypeWebView so that webview in kiosk mode
does not show undesired context menu.

BUG= 656188 

Review-Url: https://codereview.chromium.org/2545433004
Cr-Commit-Position: refs/heads/master@{#435429}

[modify] https://crrev.com/8791e3898c6d8c25fdfc416bb0c427607f223851/chrome/browser/renderer_context_menu/context_menu_content_type_factory.cc

Labels: -Pri-2 M-56 Merge-Request-56 Merge-Request-55 Pri-1
Labels: -Merge-Request-55 -Merge-Request-56 Merge-Approved-56 Merge-Approved-55
Project Member

Comment 22 by sheriffbot@chromium.org, Dec 1 2016

Status: Fixed (was: Started)
Please mark security bugs as fixed as soon as the fix lands, and before requesting merges. This update is based on the merge- labels applied to this issue. Please reopen if this update was incorrect.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 23 by bugdroid1@chromium.org, Dec 1 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/105b053ee347b9df9d3ae575a378a3b7caf1d6ca

commit 105b053ee347b9df9d3ae575a378a3b7caf1d6ca
Author: Xiyuan Xia <xiyuan@google.com>
Date: Thu Dec 01 17:34:32 2016

Merge "kiosk: Use ContextMenuContentTypeAppMode when in app mode"

> Give ContextMenuContentTypeAppMode higher priority than
> ContextMenuContentTypeWebView so that webview in kiosk mode
> does not show undesired context menu.
>
> BUG= 656188 
>
> Review-Url: https://codereview.chromium.org/2545433004
> Cr-Commit-Position: refs/heads/master@{#435429}
> (cherry picked from commit 8791e3898c6d8c25fdfc416bb0c427607f223851)

Review URL: https://codereview.chromium.org/2544853002 .

Cr-Commit-Position: refs/branch-heads/2924@{#250}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/105b053ee347b9df9d3ae575a378a3b7caf1d6ca/chrome/browser/renderer_context_menu/context_menu_content_type_factory.cc

Project Member

Comment 24 by bugdroid1@chromium.org, Dec 1 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4eeca377f0c99331e0e2e1df1f3b5650bb098df9

commit 4eeca377f0c99331e0e2e1df1f3b5650bb098df9
Author: Xiyuan Xia <xiyuan@google.com>
Date: Thu Dec 01 17:46:46 2016

Merge "kiosk: Use ContextMenuContentTypeAppMode when in app mode"

> Give ContextMenuContentTypeAppMode higher priority than
> ContextMenuContentTypeWebView so that webview in kiosk mode
> does not show undesired context menu.
>
> BUG= 656188 
>
> Review-Url: https://codereview.chromium.org/2545433004
> Cr-Commit-Position: refs/heads/master@{#435429}
> (cherry picked from commit 8791e3898c6d8c25fdfc416bb0c427607f223851)

Review URL: https://codereview.chromium.org/2533353005 .

Cr-Commit-Position: refs/branch-heads/2883@{#703}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/4eeca377f0c99331e0e2e1df1f3b5650bb098df9/chrome/browser/renderer_context_menu/context_menu_content_type_factory.cc

Project Member

Comment 25 by sheriffbot@chromium.org, Dec 2 2016

Labels: Restrict-View-SecurityNotify

Comment 26 by mlight@google.com, Dec 7 2016

Status: Verified (was: Fixed)
Verified in M55-Beta and M55-Stable, build 8872.67.0, chrome 55.0.2883.82.

Labels: -ReleaseBlock-Stable
Project Member

Comment 28 by sheriffbot@chromium.org, Mar 10 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment