New issue
Advanced search Search tips

Issue 656184 link

Starred by 4 users
Status: Verified
Owner:
steve...@chromium.org
Closed: Nov 2016
Cc:
dbeam@chromium.org
tbuck...@chromium.org
bettes@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocked on:
issue 658015


Sign in to add a comment

MD Settings > Internet - Implement 'Allow proxy for shared networks'

Project Member Reported by steve...@chromium.org, Oct 14 2016 
We need to implement 'Allow proxy for shared networks' in MD Settings.

Even though this is a global preference, we should show it in the network details section above the proxy info where it is relevant. We will need to communicate clearly that this is a global preference however.

See also issue 258835 which is orthogonal, but where we eventually want to be.

Comment 1 by steve...@chromium.org, Oct 20 2016

Cc: dbeam@chromium.org bettes@chromium.org
+bettes@

Tom/Alan, we don't have any mocks for this. We should have a quick meeting to discuss this at some point. I have an implementation based on discussions from a long time a go, but a lot has changed in the overall design since.

Comment 2 by steve...@chromium.org, Oct 20 2016

Blockedon: 658015

Comment 3 by steve...@chromium.org, Nov 11 2016

Status: Started (was: Assigned)

Comment 4 by steve...@chromium.org, Nov 15 2016

Labels: -M-55 M-56

Comment 5 by dpa...@chromium.org, Nov 15 2016

Labels: Proj-MaterialDesign-WebUI
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/566a686b839d4b7653e899e5bba04c3ce87d9b82

commit 566a686b839d4b7653e899e5bba04c3ce87d9b82
Author: stevenjb <stevenjb@chromium.org>
Date: Thu Nov 17 19:07:50 2016

MD Settings: Internet: Allow Shared Proxies

Adds the 'Allow proxies for shared networks' setting to the
proxy section in the internet detail page.

This setting affects all shared networks, so we need to show
a confirmation dialog informing the user when the setting is
changed.

(In the previois Options UI, this was exposed at the top level,
which is both confusing since there is no context, and not a
good use of top level space)

BUG= 656184 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2499483002
Cr-Commit-Position: refs/heads/master@{#432929}

[modify] https://crrev.com/566a686b839d4b7653e899e5bba04c3ce87d9b82/chrome/app/settings_strings.grdp
[modify] https://crrev.com/566a686b839d4b7653e899e5bba04c3ce87d9b82/chrome/browser/extensions/api/settings_private/prefs_util.cc
[modify] https://crrev.com/566a686b839d4b7653e899e5bba04c3ce87d9b82/chrome/browser/resources/settings/controls/settings_boolean_control_behavior.js
[modify] https://crrev.com/566a686b839d4b7653e899e5bba04c3ce87d9b82/chrome/browser/resources/settings/internet_page/compiled_resources2.gyp
[modify] https://crrev.com/566a686b839d4b7653e899e5bba04c3ce87d9b82/chrome/browser/resources/settings/internet_page/network_property_list.html
[modify] https://crrev.com/566a686b839d4b7653e899e5bba04c3ce87d9b82/chrome/browser/resources/settings/internet_page/network_property_list.js
[modify] https://crrev.com/566a686b839d4b7653e899e5bba04c3ce87d9b82/chrome/browser/resources/settings/internet_page/network_proxy.html
[modify] https://crrev.com/566a686b839d4b7653e899e5bba04c3ce87d9b82/chrome/browser/resources/settings/internet_page/network_proxy.js
[modify] https://crrev.com/566a686b839d4b7653e899e5bba04c3ce87d9b82/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/566a686b839d4b7653e899e5bba04c3ce87d9b82/ui/webui/resources/cr_elements/network/cr_onc_types.js

Comment 7 by steve...@chromium.org, Nov 17 2016

Status: Fixed (was: Started)

Comment 8 by sdantul...@chromium.org, Dec 20 2016

Status: Verified (was: Fixed)
Verified on ChromeOS 	9103.0.0, 57.0.2955.0
►

Sign in to add a comment