Reenable unittests in //net/nqe/observation_buffer_unittest.cc on OS_WIN |
||||
Issue descriptionSome of the unittests in //net/nqe/observation_buffer_unittest.cc are currently disabled on OS_WIN because the functions being tested are still not called outside of the test code. The disabled tests should be reenabled as soon as the tested functions are called from the NetworkQualityEstimator class.
,
Feb 14 2017
,
Nov 8 2017
Refreshed during triage.
,
Jan 3 2018
Refreshed during triage.
,
Jan 3 2018
,
Jan 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c2c98383a8d3b376456e0089ccb9c66113001a2 commit 0c2c98383a8d3b376456e0089ccb9c66113001a2 Author: Tarun Bansal <tbansal@chromium.org> Date: Wed Jan 03 17:39:00 2018 Reenable unittests in //net/nqe/observation_buffer_unittest.cc on OS_WIN Bug: 656170 Change-Id: I44efd7c4209a0acac58c3a9857cf6842d1c9f509 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/848234 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#526728} [modify] https://crrev.com/0c2c98383a8d3b376456e0089ccb9c66113001a2/net/nqe/observation_buffer_unittest.cc
,
Jan 3 2018
,
Jan 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/24f046fcdfc54ef28748139f42098b58360ae4fb commit 24f046fcdfc54ef28748139f42098b58360ae4fb Author: Tarun Bansal <tbansal@chromium.org> Date: Thu Jan 04 01:35:25 2018 Revert "Reenable unittests in //net/nqe/observation_buffer_unittest.cc on OS_WIN" This reverts commit 0c2c98383a8d3b376456e0089ccb9c66113001a2. Reason for revert: <INSERT REASONING HERE> Original change's description: > Reenable unittests in //net/nqe/observation_buffer_unittest.cc on OS_WIN > > Bug: 656170 > Change-Id: I44efd7c4209a0acac58c3a9857cf6842d1c9f509 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Reviewed-on: https://chromium-review.googlesource.com/848234 > Commit-Queue: Ryan Sturm <ryansturm@chromium.org> > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#526728} TBR=tbansal@chromium.org,ryansturm@chromium.org Change-Id: I2cff4f9fe1d39eeaa49f0264746cb404aee605fb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 656170 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/849672 Reviewed-by: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#526890} [modify] https://crrev.com/24f046fcdfc54ef28748139f42098b58360ae4fb/net/nqe/observation_buffer_unittest.cc
,
Jan 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b1739b9b7c0436c1ca1557e4bc31cd8dbcbb1da commit 8b1739b9b7c0436c1ca1557e4bc31cd8dbcbb1da Author: Tarun Bansal <tbansal@chromium.org> Date: Thu Jan 04 01:38:43 2018 Revert "Revert "Reenable unittests in //net/nqe/observation_buffer_unittest.cc on OS_WIN"" This reverts commit 24f046fcdfc54ef28748139f42098b58360ae4fb. Reason for revert: The previous revert was by mistake. Original change's description: > Revert "Reenable unittests in //net/nqe/observation_buffer_unittest.cc on OS_WIN" > > This reverts commit 0c2c98383a8d3b376456e0089ccb9c66113001a2. > > Reason for revert: <INSERT REASONING HERE> > > Original change's description: > > Reenable unittests in //net/nqe/observation_buffer_unittest.cc on OS_WIN > > > > Bug: 656170 > > Change-Id: I44efd7c4209a0acac58c3a9857cf6842d1c9f509 > > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > > Reviewed-on: https://chromium-review.googlesource.com/848234 > > Commit-Queue: Ryan Sturm <ryansturm@chromium.org> > > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#526728} > > TBR=tbansal@chromium.org,ryansturm@chromium.org > > Change-Id: I2cff4f9fe1d39eeaa49f0264746cb404aee605fb > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 656170 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Reviewed-on: https://chromium-review.googlesource.com/849672 > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Commit-Queue: Tarun Bansal <tbansal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#526890} TBR=tbansal@chromium.org,ryansturm@chromium.org Change-Id: Ieb308bff8ea947752977a9c36c9590122c1ff7a7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 656170 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/849573 Reviewed-by: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#526891} [modify] https://crrev.com/8b1739b9b7c0436c1ca1557e4bc31cd8dbcbb1da/net/nqe/observation_buffer_unittest.cc |
||||
►
Sign in to add a comment |
||||
Comment 1 by tbansal@chromium.org
, Feb 13 2017