New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 656166 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

faft: Add test to ensure power button press wakes system from S3

Project Member Reported by sha...@chromium.org, Oct 14 2016

Issue description

We can expand firmware_ECWakeSource or firmware_ECPowerButton to test this functionality.
 
Isn't it already covered firmware_ECWakeSource?

logging.info("Suspend and wake by power button.")
self.switcher.mode_aware_reboot(
        'custom',
        lambda:self.suspend_as_reboot(self.wake_by_power_button)) 
I haven't looked at that test at all, but it depends if the DUT was suspended by closing the lid or just some `power_dbus_suspend` command. Ideally both should be tested. 
So it sounds like you want to extend suspend_as_reboot()?
Now it only suspends by powerd_dbus_suspend().
Would you like to add an argument called suspend_func() to support something like lid_switch_suspend()?
Yeah, that sounds good to me. Reading that test, I wonder why that tests for x86 only? It may just be an artifact of the past. I don't see anything immediately obvious why it would not work for ARM devices.
When I think deeper, I found this is actually weird.
If you suspend DUT by closing the lid switch, you cannot wake it up by pressing the power button since the lid switch is still closed.
Cc: jwer...@chromium.org
+jwerner

The point of that is to support the docked case. (DUT plugged into external monitor, but with lid closed).

Comment 7 by gkihumba@google.com, Mar 31 2017

Owner: dchan@chromium.org
Status: Assigned (was: Untriaged)

Comment 8 by dchan@google.com, May 19 2017

Cc: twreid@chromium.org
Owner: kmshelton@chromium.org

Sign in to add a comment