Issue 656159 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	sammiequon@chromium.org
Closed:	Oct 2016
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	1
Type:	Bug
VerifyIn-57 VerifyIn-58 VerifyIn-59 VerifyIn-60 VerifyIn-61

Pin keyboard has several dead zones.

Project Member Reported by sammiequon@chromium.org, Oct 14 2016

Issue description

(1) Enable pin unlock.
(2) Try pressing halfway between two of the numbers horizontally.
(3) Nothing gets entered.

Comment 1 by sammiequon@chromium.org, Oct 15 2016

Status: Started (was: Assigned)

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c0b4e4776ecbccdfd5a30027f306c5041275773

commit 6c0b4e4776ecbccdfd5a30027f306c5041275773
Author: sammiequon <sammiequon@chromium.org>
Date: Wed Oct 19 00:23:18 2016

cros: Removed some zones in the middle of the pin keyboard that do not accept touches.

Previously the parts of the pin keyboard which are not covered by the button ripple do nothing on touch. This includes the corners of each button as well as the space between each button horizontally. I fix this by hiding the paper-button ripple and adding a new one so that it is still compliant with mocks.

BUG=  656159 , 655306
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2425443002
Cr-Commit-Position: refs/heads/master@{#426103}

[modify] https://crrev.com/6c0b4e4776ecbccdfd5a30027f306c5041275773/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html