New issue
Advanced search Search tips

Issue 656154 link

Starred by 2 users
Status: Fixed
Owner:
qyears...@chromium.org
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 474273



Sign in to add a comment

rebaseline-cl: When an issue is passed, checking for existence of local files is not correct.

Project Member Reported by qyears...@chromium.org, Oct 14 2016 
In rebaseline_cl.py, the list of tests to rebaseline is filtered so that it only includes existing tests.

However, if an --issue is passed (so the CL being rebaselined is not the CL for the current local branch) and there are newly-added tests, then the newly-added tests will be skipped, but they shouldn't be.

Code link: https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py?l=80)

Simple fix: Don't call _filter_existing if --issue was passed.
Possibly better fix: Remove _filter_existing and make sure that _test_prefix_list would only return existing tests.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/daf1ddbd71f55b0765611a7273c74860dbd3d6b2

commit daf1ddbd71f55b0765611a7273c74860dbd3d6b2
Author: qyearsley <qyearsley@chromium.org>
Date: Wed Nov 16 17:52:02 2016

In rebaseline-cl, don't check for local file existence.

I originally added filtering of tests to only include files that exist
locally in http://crrev.com/2371803003.

But now, it seems clearer that this was the wrong choice, since:

 1. Virtual tests don't exist on the local file system
 2. When --issue is passed (when downloading baselines for try jobs
    on another CL), the files don't exist locally.

In order to stop checking for file existence, another little issue
needed to be solved, which was that when getting the list of files
that were changed, the list included deleted files, which we don't
want to rebaseline; so this CL also fixes that.

BUG= 663411 , 656154 , 649691 

Review-Url: https://codereview.chromium.org/2507613002
Cr-Commit-Position: refs/heads/master@{#432548}

[modify] https://crrev.com/daf1ddbd71f55b0765611a7273c74860dbd3d6b2/third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py
[modify] https://crrev.com/daf1ddbd71f55b0765611a7273c74860dbd3d6b2/third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld_unittest.py
[modify] https://crrev.com/daf1ddbd71f55b0765611a7273c74860dbd3d6b2/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py
[modify] https://crrev.com/daf1ddbd71f55b0765611a7273c74860dbd3d6b2/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py

Comment 2 by qyears...@chromium.org, Nov 17 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment