WelcomeHandler sometimes has browser_ null in ctor |
||||||
Issue descriptionThe variable browser_ does not always properly initialize in the constructor of WelcomeHandler. This causes a segfault when browser_->ShowModalSigninWindow() is invoked. The solution will likely be to inline the call to FindBrowserWithWebContents(), as I suspect the problem is that the Browser is not yet available at construct-time in some cases.
,
Oct 18 2016
I uploaded CL for this issue https://codereview.chromium.org/2431543003
,
Oct 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9ae964cc90a742835cd7c86d8c2d249dde19b4e4 commit 9ae964cc90a742835cd7c86d8c2d249dde19b4e4 Author: corona10 <corona10@gmail.com> Date: Tue Oct 18 23:58:12 2016 Fix WelcomeHandler crash when signin link is clicked. BUG= 656153 Review-Url: https://codereview.chromium.org/2431543003 Cr-Commit-Position: refs/heads/master@{#426092} [modify] https://crrev.com/9ae964cc90a742835cd7c86d8c2d249dde19b4e4/chrome/browser/ui/webui/welcome_handler.cc [modify] https://crrev.com/9ae964cc90a742835cd7c86d8c2d249dde19b4e4/chrome/browser/ui/webui/welcome_handler.h
,
Oct 20 2016
Verified, segfault no longer occurs.
,
Oct 20 2016
Your change meets the bar and is auto-approved for M55 (branch: 2883)
,
Oct 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c184ff72b80c664143f4968afd2a8f8b4227c16 commit 4c184ff72b80c664143f4968afd2a8f8b4227c16 Author: Anthony Vallee-Dubois <anthonyvd@chromium.org> Date: Thu Oct 20 20:12:43 2016 [Merge] Fix WelcomeHandler crash when signin link is clicked. BUG= 656153 Review-Url: https://codereview.chromium.org/2431543003 Cr-Commit-Position: refs/heads/master@{#426092} (cherry picked from commit 9ae964cc90a742835cd7c86d8c2d249dde19b4e4) Review URL: https://codereview.chromium.org/2440813002 . Cr-Commit-Position: refs/branch-heads/2883@{#220} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/4c184ff72b80c664143f4968afd2a8f8b4227c16/chrome/browser/ui/webui/welcome_handler.cc [modify] https://crrev.com/4c184ff72b80c664143f4968afd2a8f8b4227c16/chrome/browser/ui/webui/welcome_handler.h
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c184ff72b80c664143f4968afd2a8f8b4227c16 commit 4c184ff72b80c664143f4968afd2a8f8b4227c16 Author: Anthony Vallee-Dubois <anthonyvd@chromium.org> Date: Thu Oct 20 20:12:43 2016 [Merge] Fix WelcomeHandler crash when signin link is clicked. BUG= 656153 Review-Url: https://codereview.chromium.org/2431543003 Cr-Commit-Position: refs/heads/master@{#426092} (cherry picked from commit 9ae964cc90a742835cd7c86d8c2d249dde19b4e4) Review URL: https://codereview.chromium.org/2440813002 . Cr-Commit-Position: refs/branch-heads/2883@{#220} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/4c184ff72b80c664143f4968afd2a8f8b4227c16/chrome/browser/ui/webui/welcome_handler.cc [modify] https://crrev.com/4c184ff72b80c664143f4968afd2a8f8b4227c16/chrome/browser/ui/webui/welcome_handler.h
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840 |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by tmartino@chromium.org
, Oct 14 2016Labels: -Pri-3 M-55 OS-Linux OS-Mac OS-Windows Pri-1