New issue
Advanced search Search tips

Issue 656146 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

Android accessibility hit testing

Project Member Reported by dmazz...@chromium.org, Oct 14 2016

Issue description

When doing hit testing on Android, we should avoid landing
on wrapper objects like a <div>.

If there's just one "interesting" child of the div, we should return that, otherwise we should return an interesting ancestor.

See b/31152101

 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46fca134595100df7461475cc05516e94b000064

commit 46fca134595100df7461475cc05516e94b000064
Author: dmazzoni <dmazzoni@chromium.org>
Date: Sat Oct 22 01:00:23 2016

Improve Android accessible hit testing.

Take advantage of a new function we defined already for what nodes are
"interesting" on Android.

When we get a hit test result back and it's not interesting, first see if
there's a single child that's interesting. If so, return that. If not,
walk up to the first interesting ancestor.

That will avoid returning something like a wrapper <div>.

BUG= 656146 

Review-Url: https://chromiumcodereview.appspot.com/2422773002
Cr-Commit-Position: refs/heads/master@{#426938}

[modify] https://crrev.com/46fca134595100df7461475cc05516e94b000064/content/browser/accessibility/browser_accessibility_android.cc
[modify] https://crrev.com/46fca134595100df7461475cc05516e94b000064/content/browser/accessibility/browser_accessibility_android.h
[modify] https://crrev.com/46fca134595100df7461475cc05516e94b000064/content/browser/accessibility/browser_accessibility_manager_android.cc

Status: Fixed (was: Assigned)

Sign in to add a comment