New issue
Advanced search Search tips

Issue 656139 link

Starred by 3 users
Status: Fixed
Owner:
tmartino@chromium.org
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug

Blocking:
issue 618454



Sign in to add a comment

Adding Pinned Tab and Preferences-specified Tab logic to Startup Flow refactor

Project Member Reported by tmartino@chromium.org, Oct 14 2016 
The recent refactor of the Startup Flow for determining which tabs to display left TODOs in place of the logic which:
- reads tabs from the user's preferences
- gets tabs which the user had pinned in their last session

This bug tracks the effort to fill in those gaps.

Comment 2 by tmartino@chromium.org, Oct 21 2016

Labels: Merge-Request-55

Comment 3 by tmartino@chromium.org, Oct 24 2016

Status: Fixed (was: Started)

Comment 4 by dimu@google.com, Oct 24 2016

Labels: -Merge-Request-55 Merge-Review-55 Hotlist-Merge-Review
[Automated comment] There appears to be on-going work (i.e. bugroid changes), needs manual review.

Comment 5 by gov...@chromium.org, Oct 24 2016 

Before we approve merge to M55 branch 2883, could you please confirm whether this change is baked/verified in Canary and safe to merge to M55?

Comment 6 by dimu@google.com, Oct 24 2016

Labels: -Hotlist-Merge-review -Merge-Review-55 Merge-Request-55

Comment 7 by dimu@chromium.org, Oct 24 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 24 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/802b012da14ca6bbb4ac7d26e5ac9a383c2b20e4

commit 802b012da14ca6bbb4ac7d26e5ac9a383c2b20e4
Author: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Date: Mon Oct 24 21:54:10 2016

[Merge] This patch fills in the TODOs in StartupTabProvider regarding pinned tabs and user preferences-specified default tabs.

BUG= 656139 ,  248883 , 517248

Review-Url: https://chromiumcodereview.appspot.com/2396133002
Cr-Commit-Position: refs/heads/master@{#426339}
(cherry picked from commit f51ecc9beca2aadad233c44ed098406361d128a8)

Review URL: https://codereview.chromium.org/2451463002 .

Cr-Commit-Position: refs/branch-heads/2883@{#266}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/802b012da14ca6bbb4ac7d26e5ac9a383c2b20e4/chrome/browser/ui/startup/startup_browser_creator_impl.cc
[modify] https://crrev.com/802b012da14ca6bbb4ac7d26e5ac9a383c2b20e4/chrome/browser/ui/startup/startup_browser_creator_impl_unittest.cc
[modify] https://crrev.com/802b012da14ca6bbb4ac7d26e5ac9a383c2b20e4/chrome/browser/ui/startup/startup_tab_provider.cc
[modify] https://crrev.com/802b012da14ca6bbb4ac7d26e5ac9a383c2b20e4/chrome/browser/ui/startup/startup_tab_provider.h
[modify] https://crrev.com/802b012da14ca6bbb4ac7d26e5ac9a383c2b20e4/chrome/browser/ui/startup/startup_tab_provider_unittest.cc
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/802b012da14ca6bbb4ac7d26e5ac9a383c2b20e4

commit 802b012da14ca6bbb4ac7d26e5ac9a383c2b20e4
Author: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Date: Mon Oct 24 21:54:10 2016

[Merge] This patch fills in the TODOs in StartupTabProvider regarding pinned tabs and user preferences-specified default tabs.

BUG= 656139 ,  248883 , 517248

Review-Url: https://chromiumcodereview.appspot.com/2396133002
Cr-Commit-Position: refs/heads/master@{#426339}
(cherry picked from commit f51ecc9beca2aadad233c44ed098406361d128a8)

Review URL: https://codereview.chromium.org/2451463002 .

Cr-Commit-Position: refs/branch-heads/2883@{#266}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/802b012da14ca6bbb4ac7d26e5ac9a383c2b20e4/chrome/browser/ui/startup/startup_browser_creator_impl.cc
[modify] https://crrev.com/802b012da14ca6bbb4ac7d26e5ac9a383c2b20e4/chrome/browser/ui/startup/startup_browser_creator_impl_unittest.cc
[modify] https://crrev.com/802b012da14ca6bbb4ac7d26e5ac9a383c2b20e4/chrome/browser/ui/startup/startup_tab_provider.cc
[modify] https://crrev.com/802b012da14ca6bbb4ac7d26e5ac9a383c2b20e4/chrome/browser/ui/startup/startup_tab_provider.h
[modify] https://crrev.com/802b012da14ca6bbb4ac7d26e5ac9a383c2b20e4/chrome/browser/ui/startup/startup_tab_provider_unittest.cc

Comment 10 by dimu@google.com, Nov 4 2016 

[Automated comment] removing mislabelled merge-merged-2840

Comment 11 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
►

Sign in to add a comment