New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 656138 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 648728



Sign in to add a comment

Put analysis requests for flake in a task queue for asynchronous processing

Project Member Reported by st...@chromium.org, Oct 14 2016

Issue description

Currently, analysis requests for flakes from chromium-try-flakes are processed in the same http request from client side (just to decide whether a new analysis is needed or not and start one if needed).
 

Comment 1 by st...@chromium.org, Oct 17 2016

Blocking: 648728
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/e9f14cc4676df7495e28f583d2bffe383159d267

commit e9f14cc4676df7495e28f583d2bffe383159d267
Author: stgao <stgao@chromium.org>
Date: Sat Oct 22 00:03:21 2016

[Findit] Asynchronously process flake reports from chromium-try-flakes.

Since a hacky solution was implemented to map a CQ trybot step to a Waterfall buildbot step, multiple http requests have to be sent to Swarming and Isolate Server to retrieve step metadata and test output. Such http requests could lead to long processing time for a single flake report, and cause timeout on chromium-try-flakes side.

This CL is to put flake reports from chromium-try-flakes in a task queue, and then process them asynchronously.

BUG= 656138 

Review-Url: https://chromiumcodereview.appspot.com/2435983003

[modify] https://crrev.com/e9f14cc4676df7495e28f583d2bffe383159d267/appengine/findit/common/constants.py
[modify] https://crrev.com/e9f14cc4676df7495e28f583d2bffe383159d267/appengine/findit/findit_api.py
[add] https://crrev.com/e9f14cc4676df7495e28f583d2bffe383159d267/appengine/findit/handlers/process_flake_analysis_request.py
[add] https://crrev.com/e9f14cc4676df7495e28f583d2bffe383159d267/appengine/findit/handlers/test/process_flake_analysis_request_test.py
[modify] https://crrev.com/e9f14cc4676df7495e28f583d2bffe383159d267/appengine/findit/main.py
[modify] https://crrev.com/e9f14cc4676df7495e28f583d2bffe383159d267/appengine/findit/queue.yaml
[modify] https://crrev.com/e9f14cc4676df7495e28f583d2bffe383159d267/appengine/findit/test/findit_api_test.py
[modify] https://crrev.com/e9f14cc4676df7495e28f583d2bffe383159d267/appengine/findit/waterfall-backend.yaml
[modify] https://crrev.com/e9f14cc4676df7495e28f583d2bffe383159d267/appengine/findit/waterfall/flake/flake_analysis_service.py

Comment 3 by st...@chromium.org, Oct 22 2016

Owner: st...@chromium.org
Status: Fixed (was: Available)

Comment 4 by benhenry@google.com, Oct 24 2016

Labels: cit-cq

Sign in to add a comment