New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 656136 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Change welcome_ui to use LoadUrl instead of Navigate

Project Member Reported by tmartino@chromium.org, Oct 14 2016

Issue description

Small bit of tech debt. Currently, when whisking the user away to the NTP, the Welcome UI invokes the Navigate method, rather than the more specific LoadUrl.

per feedback from pmonette@:

> The chrome::Navigate() function is the generalized version where you don't have access to a WebContents. Internally, it will call LoadURL from the controller.
> 
> Also, using chrome::Navigate() requires an inefficient call to GetBrowserForWebContents() (loops over all WebContents of the browser process).
> 
> IMO we should change the navigate in welcome_ui.cc too.
 
Cc: msrchandra@chromium.org tmartino@chromium.org ranjitkan@chromium.org nyerramilli@chromium.org
 Issue 680436  has been merged into this issue.
Labels: -M-56 -Pri-3 Pri-2
A side effect of the current call to Navigate is that, if the Welcome page is open but sign-in is completed from another tab (e.g., chrome://md-settings), that tab is navigated to the NTP, whether or not that navigation is desired.
Status: Assigned (was: Untriaged)

Sign in to add a comment